Re: [openstreetmap/openstreetmap-website] Split directions engine select into modes and providers (PR #5652)

@hlfan commented on this pull request. > -}); - } - - function setEngine(index) { -chosenEngine = engines[index]; -select.val(index); + function setEngine(id) { +const engines = OSM.Directions.engines; +const desired = engines.find(engine => engine.id() === id); +if (!

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > + +<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg", + :alt => social_link.parsed[:platform].nil? ? "other" : social_link.parsed[:platform], + :

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > +# Indexes +# +# index_social_links_on_user_id (user_id) +# +# Foreign Keys +# +# fk_rails_... (user_id => users.id) +# + +class SocialLink < ApplicationRecord + belongs_to :user + + validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :messag

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > @@ -10,6 +10,35 @@ $(document).ready(function () { var defaultHomeZoom = 12; var map, marker, deleted_lat, deleted_lon; + if ($("#social_links").length) { +$("#add-social-link").click(function (event) { + event.preventDefault(); + c

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > + + validates :url, :format => { :with => %r{\Ahttps?://.+\z}, :message => :http_parse_error } + + URL_PATTERNS = { +:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)}, +:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA-Z0-9.

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > + URL_PATTERNS = { +:discord => %r{\Ahttps?://(?:www\.)?discord\.com/users/(\d+)}, +:facebook => %r{\Ahttps?://(?:www\.)?facebook\.com/([a-zA-Z0-9.]+)}, +:github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)}, +:gitlab => %r{\Ah

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > @@ -0,0 +1,8 @@ +<% social_links.each do |social_link| %> + +<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg", + :alt => social_link.parsed[:platform].nil? ? "oth

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@HolgerJeromin commented on this pull request. > +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)} + }.freeze + + NO_USERNAME_PLATFORMS = %w[discord line skype slack].freeze + + def parsed +URL_PATTERNS.each do |platform, pattern| + names = url.match(patt

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > @@ -0,0 +1,8 @@ +<% social_links.each do |social_link| %> + +<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg", + :alt => social_link.parsed[:platform].nil? ? "oth

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > @@ -0,0 +1,8 @@ +<% social_links.each do |social_link| %> + +<%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' : social_link.parsed[:platform]}.svg", `:size => "16"` was added to the `` tag to avoid text jumps. Thanks

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc commented on this pull request. > +:bluesky => %r{\Ahttps?://(?:www\.)?bsky\.app/profile/([a-zA-Z0-9\._-]+)} + }.freeze + + NO_USERNAME_PLATFORMS = %w[discord line skype slack].freeze + + def parsed +URL_PATTERNS.each do |platform, pattern| + names = url.match(pattern) +

Re: [openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

@nertc pushed 1 commit. 418929188fbc31a640defff703b102ddbf354afe Add social profile links -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/6d3d9316d353ab824a9046f2c92dc94039fd23b4..418929188fbc31a640defff703b102ddbf354afe You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] Split directions engine select into modes and providers (PR #5652)

@AntonKhorev commented on this pull request. > +for (const mode of new Set(modes)) { + modeGroup.append(``); + modeGroup.append(``); +} +$(".routing_modes input#" + chosenEngine.mode).prop("checked", true); + +const providers = engines + .filter(engine => engine.mo

Re: [openstreetmap/openstreetmap-website] Split directions engine select into modes and providers (PR #5652)

@AntonKhorev commented on this pull request. > +modeGroup.html(""); +for (const mode of new Set(modes)) { + modeGroup.append(``); + modeGroup.append(``); +} Are you sure you want to redraw the buttons instead of adding them once in the html template? Even if you plan for

Re: [openstreetmap/openstreetmap-website] Split directions engine select into modes and providers (PR #5652)

@AntonKhorev commented on this pull request. > -}); - } - - function setEngine(index) { -chosenEngine = engines[index]; -select.val(index); + function setEngine(id) { +const engines = OSM.Directions.engines; +const desired = engines.find(engine => engine.id() === id); +

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 3 commits. c0a8e2418b742d00142ae870efe067e1ee6f4c17 Make api changeset show path resourceful 28f4cfc81a3f2f6d36c9d7d1fa60cf081449248e Create api changeset download resource f50e000f3999b9d2dc9e1a3845781dc175ce20bc Rewrite changeset download show test -- View it on GitHub:

Re: [openstreetmap/openstreetmap-website] API changeset resources - index path (PR #5713)

github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5713) 1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Gener

[openstreetmap/openstreetmap-website] API changeset resources - index path (PR #5713)

Like #5591 but for changesets, with the same modification for `create` action. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5713 -- Commit Summary -- * Make api create changeset path resourceful * Move api chang

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 3 commits. 3f32cac1a00c18657be11b2e8a00b84a6fcd7997 Make api changeset show path resourceful 220e5fada2e539791deb0547a9fe5828a6f0b599 Create api changeset download resource ea5cbc34401a8ec8f815bb04e24d3aec53346ed9 Rewrite changeset download show test -- View it on GitHub:

Re: [openstreetmap/openstreetmap-website] API element and changeset resources (PR #5590)

@AntonKhorev pushed 3 commits. d479a3781a1c5437620010c5254039befec30f5c Make api create changeset path resourceful bcf066ff9c42c7b868de15e2ae251986ab19fe61 Move api changeset index tests up 0b751a4b1b5328724fc1e4bb09385c9590dfb82c Make api changeset index path resourceful -- View it on GitH

[openstreetmap/openstreetmap-website] Displays "unknown" description for notes with missing opening comment (PR #5712)

### Description It seems there are some notes in database with a missing opening comment ([here](https://github.com/openstreetmap/openstreetmap-website/pull/5667#discussion_r1957131929)). This PR adds displaying "unknown" as description for such notes and remaining comments (if available) as pa

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

hlfan left a comment (openstreetmap/openstreetmap-website#5700) That was done for Potlatch in https://github.com/openstreetmap/openstreetmap-website/commit/50fafa14f86a9ff02458c1e055f24c199f14a8eb -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetm

[openstreetmap/openstreetmap-website] Set zoom in id iframe data (PR #5711)

Follow-up to #5700 to include the zoom as well You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5711 -- Commit Summary -- * Set zoom in id iframe data -- File Changes -- M app/assets/javascripts/edit/id.js.erb (

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

hlfan left a comment (openstreetmap/openstreetmap-website#5700) I already wanted to increase the zoom in general in https://github.com/openstreetmap/openstreetmap-website/pull/5632#discussion_r1948124352 but if we already have a zoom set in the [site_controller](https://github.com/openstreetmap

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

tomhughes left a comment (openstreetmap/openstreetmap-website#5700) Well that's a matter of opinion anyway and not everybody will have the same opinion - while 16 might be a bit low I think 20 might be a bit high for example. -- Reply to this email directly or view it on GitHub: https://github

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

davidpnewton left a comment (openstreetmap/openstreetmap-website#5700) This doesn't entirely fix the problem. The centre of the screen is now in the correct place. However the zoom level is utterly inappropriate for the features in question. For a single node it goes to zoom level 16 by default

Re: [openstreetmap/openstreetmap-website] Allow getting a GPX in the browser outside openstreetmap.org (Issue #5639)

tomhughes left a comment (openstreetmap/openstreetmap-website#5639) Well we don't want to allow `OPTIONS` as such, but the `OPTIONS` request that is used to query CORS should be allowed - if we add `:options` there then that is saying that, if asked, Rask::Cors should say that `OPTIONS` is allow

Re: [openstreetmap/openstreetmap-website] Allow getting a GPX in the browser outside openstreetmap.org (Issue #5639)

mmd-osm left a comment (openstreetmap/openstreetmap-website#5639) Elsewhere I've seen that `:options` has been added to the list of methods in cors.rb (e.g. https://github.com/mastodon/mastodon/blob/main/config/initializers/cors.rb#L23), while it's not included in our version: https://github.c

Re: [openstreetmap/openstreetmap-website] Center secondary nav when collapsed (PR #5702)

Merged #5702 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5702#event-16369983777 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Center secondary nav when collapsed (PR #5702)

tomhughes left a comment (openstreetmap/openstreetmap-website#5702) Looks good to me now, thanks. It would be nice if we could get it to balance the lines better when there are multiple lines but I don't think there's an easy way to do that. -- Reply to this email directly or view it on GitHub

Re: [openstreetmap/openstreetmap-website] Test changeset tags in api changeset show responses (PR #5703)

Merged #5703 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5703#event-16369983765 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove current user check from dashboard view (PR #5705)

Merged #5705 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5705#event-16369983780 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Enable exporting direction paths (PR #5694)

@hlfan commented on this pull request. > @@ -36,6 +36,9 @@ OSM.Directions = function (map) { OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED, endpointDragCallback, endpointChangeCallback) ]; + const exportGroup = L.layerGroup([...endpoints.map(m => m.marker),

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.1 (PR #5708)

dependabot[bot] left a comment (openstreetmap/openstreetmap-website#5708) OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore

Re: [openstreetmap/openstreetmap-website] Remove current user check from dashboard view (PR #5705)

tomhughes left a comment (openstreetmap/openstreetmap-website#5705) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5705#issuecomment-2669405485 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Test changeset tags in api changeset show responses (PR #5703)

tomhughes left a comment (openstreetmap/openstreetmap-website#5703) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5703#issuecomment-2669398650 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

Merged #5707 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5707#event-16369805391 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.1 (PR #5708)

Closed #5708 via #5707. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5708#event-16369805839 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-de

Re: [openstreetmap/openstreetmap-website] Associate search input with route destination instead of departure (PR #5710)

Merged #5710 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5710#event-16369805376 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Bump nokogiri from 1.18.2 to 1.18.3 (PR #5709)

Merged #5709 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5709#event-16369805352 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Associate search input with route destination instead of departure (PR #5710)

tomhughes left a comment (openstreetmap/openstreetmap-website#5710) I agree with @gravitystorm that most people will expect the place they search for to become the destination, so this looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetm

Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

tomhughes left a comment (openstreetmap/openstreetmap-website#5707) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5707#issuecomment-2669378066 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] Add button for directions from location (PR #5635)

@hlfan commented on this pull request. > @@ -11,7 +11,7 @@ OSM.Search = function (map) { e.preventDefault(); const query = $(this).closest("form").find("input[name=query]").val(); let search = ""; -if (query) search = "?" + new URLSearchParams({ from: query }); +if (query)

Re: [openstreetmap/openstreetmap-website] Add button for directions from location (PR #5635)

@hlfan pushed 1 commit. b9ffd2fe4e83c2ffab659ce54196ccab7c1f62d0 Add button for directions from location -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5635/files/1cbe5968808f831e40280986ef475a50cd5f65b8..b9ffd2fe4e83c2ffab659ce54196ccab7c1f62d0 You are recei

[openstreetmap/openstreetmap-website] Associate search input with route destination instead of departure (PR #5710)

Split out of #5635 by the maintainers' suggestion. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5710 -- Commit Summary -- * Associate search input with route destination instead of departure -- File Changes --

Re: [openstreetmap/openstreetmap-website] Add button for directions from location (PR #5635)

@tomhughes commented on this pull request. > @@ -11,7 +11,7 @@ OSM.Search = function (map) { e.preventDefault(); const query = $(this).closest("form").find("input[name=query]").val(); let search = ""; -if (query) search = "?" + new URLSearchParams({ from: query }); +if (qu

Re: [openstreetmap/openstreetmap-website] Add button for directions from location (PR #5635)

@hlfan commented on this pull request. > @@ -11,7 +11,7 @@ OSM.Search = function (map) { e.preventDefault(); const query = $(this).closest("form").find("input[name=query]").val(); let search = ""; -if (query) search = "?" + new URLSearchParams({ from: query }); +if (query)

Re: [openstreetmap/openstreetmap-website] Add a page to view active blocks (PR #5524)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#5524) I'm thinking if it's important to handle the situation where you're blocked while using a token from one account but logged into osm-website with another account. If it is important, sending blocked users to `/account/blocks`

Re: [openstreetmap/openstreetmap-website] Add button for directions from location (PR #5635)

@gravitystorm commented on this pull request. > @@ -581,6 +581,15 @@ header .search_forms, } } +.search_forms { We try hard to avoid writing custom CSS for features on the website - typically, we only use Bootstrap classes applied directly to the elements. Most existing CSS in this file

Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#5706) > but they're not integrated into the website https://github.com/openstreetmap/openstreetmap-website/pull/2028 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/

Re: [openstreetmap/openstreetmap-website] Add optional two-factor authentication for user accounts (Issue #3476)

gy-mate left a comment (openstreetmap/openstreetmap-website#3476) I'd recommend using passkeys instead of TOTP: https://www.w3.org/TR/webauthn-3/ They are much easier to use and are already supported by Chrome and Safari. -- Reply to this email directly or view it on GitHub: https://github.com/o

[openstreetmap/openstreetmap-website] Bump nokogiri from 1.18.2 to 1.18.3 (PR #5709)

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.2 to 1.18.3.

Release notes

Sourced from nokogiri's releases.

v1.18.3 / 2025-02-18

Security

Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

2025-02-19 Thread Tom Hughes via rails-dev

tomhughes left a comment (openstreetmap/openstreetmap-website#5707) Ah I missed that the prefix was defined by the import. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5707#issuecomment-2668602496 You are receiving this because

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.0 (PR #5704)

2025-02-19 Thread dependabot[bot] via rails-dev

Closed #5704. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5704#event-16364604166 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.0 (PR #5704)

2025-02-19 Thread dependabot[bot] via rails-dev

dependabot[bot] left a comment (openstreetmap/openstreetmap-website#5704) Superseded by #5708. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5704#issuecomment-2668475566 You are receiving this because you are subscribed to this

[openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.1 (PR #5708)

2025-02-19 Thread dependabot[bot] via rails-dev

Bumps [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js) from 3.1.0 to 4.0.1.

Release notes

Sourced from @​stylis




Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

2025-02-19 Thread Holger Jeromin via rails-dev

HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5707) > Is this actually working? yes:  > If you go with > https://eslint.style/guide/migration#approach-1-migrate-to-single-plugin and > i

Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

2025-02-19 Thread Tom Hughes via rails-dev

tomhughes left a comment (openstreetmap/openstreetmap-website#5707) Is this actually working? According to https://eslint.style/guide/migration#approach-2-migrate-to-1-to-1-plugins if you only import the `@stylistic/eslint-plugin-js` module then you need to use `@stylistic/js/...` for the rule

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.0 (PR #5704)

2025-02-19 Thread Marwin Hochfelsner via rails-dev

hlfan left a comment (openstreetmap/openstreetmap-website#5704) > not sure if that is the issue though [seems to be](https://eslint.style/guide/migration#approach-1-migrate-to-single-plugin:~:text=In%20v4,ESM%2Donly) -- Reply to this email directly or view it on GitHub: https://github.com/open

Re: [openstreetmap/openstreetmap-website] Remove current user check from dashboard view (PR #5705)

2025-02-19 Thread Nenad Vujicic via rails-dev

@nenad-vujicic approved this pull request. This works great on my side. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5705#pullrequestreview-2626299497 You are receiving this because you are subscribed to this thread.

Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

2025-02-19 Thread Marwin Hochfelsner via rails-dev

@hlfan approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5707#pullrequestreview-2626122848 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

2025-02-19 Thread Holger Jeromin via rails-dev

HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5707) I could have kept the name in the end, but having the standard `.mjs` module extension feels not too bad. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/570

Re: [openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

2025-02-19 Thread Holger Jeromin via rails-dev

@HolgerJeromin pushed 1 commit. 0f767263926ef8d3e8bd01aee7dce3e34c6cad94 Migrate eslint config to esmodules -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5707/files/e867f1783f2eecf8ad09afe08db6bb8ecd5b4731..0f767263926ef8d3e8bd01aee7dce3e34c6cad94 You are rec

[openstreetmap/openstreetmap-website] Migrate eslint config to esmodules (PR #5707)

2025-02-19 Thread Holger Jeromin via rails-dev

And upgrade `@stylistic/eslint-plugin-js` to `4.0.x` closes #5704 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5707 -- Commit Summary -- * Migrate eslint config to esmodules -- File Changes -- M .overcommi

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.0 (PR #5704)

2025-02-19 Thread Holger Jeromin via rails-dev

HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5704) I am working on migrating to clean esmodules for this config. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5704#issuecomment-2667914850 You are receiving t

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.0 (PR #5704)

2025-02-19 Thread Tom Hughes via rails-dev

tomhughes left a comment (openstreetmap/openstreetmap-website#5704) We're going this: ``` const stylisticJs = require("@stylistic/eslint-plugin-js"); ``` while their documentation uses import in the example: ``` import stylistic from '@stylistic/eslint-plugin' ``` not sure if that is the issue

Re: [openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.0 (PR #5704)

2025-02-19 Thread Holger Jeromin via rails-dev

HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5704) fails with > Error [ERR_REQUIRE_ESM]: require() of ES Module > /home/runner/work/openstreetmap-website/openstreetmap-website/node_modules/@stylistic/eslint-plugin-js/dist/index.js > from > /home/runner/work/openstreetmap-we