Re: [openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)

2025-02-18 Thread Paul Norman via rails-dev
pnorman left a comment (openstreetmap/openstreetmap-website#5706) > In case _Contributor Terms_ or _Terms of Use_ were updated since last > agreeing to them The Contributor Terms and Terms of use are different. The Contributor Terms are what grants the OSMF the right to distribute your data and

[openstreetmap/openstreetmap-website] Allow to agree to new terms if already agreed to old terms (PR #5706)

2025-02-18 Thread Anton Khorev via rails-dev
In case *Contributor Terms* or *Terms of Use* were updated since last agreeing to them, which is supposedly the case for many people, it's impossible to accept the new terms. This PR makes it possible by - telling when the terms were accepted in *My Account* - linking to the *Terms* page ![im

Re: [openstreetmap/openstreetmap-website] Justify secondary nav (PR #5702)

2025-02-18 Thread Marwin Hochfelsner via rails-dev
@hlfan pushed 1 commit. 9df0872ce8adf9e3c55ec56a8d92cf4546d4ec61 Center secondary nav -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5702/files/3eaa53225fc58b8c4516005034d8e6e94dfcf734..9df0872ce8adf9e3c55ec56a8d92cf4546d4ec61 You are receiving this because yo

Re: [openstreetmap/openstreetmap-website] Remove current user check from dashboard view (PR #5705)

2025-02-18 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 50bf0a6379ed8ffb31719a29d63d17f8e72fc07b Remove current user check from dashboard view -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5705/files/44c5af236ede61d8c65c629c9e889fb2d35e4e2d..50bf0a6379ed8ffb31719a29d63d17f8e72fc07b Y

[openstreetmap/openstreetmap-website] Remove current user check from dashboard view (PR #5705)

2025-02-18 Thread Anton Khorev via rails-dev
Dashboard view only outputs its contents if this condition is true: ```ruby if current_user and @user.id == current_user.id ``` But it's always true. The page is only accessible when authorized, therefore `current_user` is set. `current_user` is assigned to `@user`, so the `id`s are also always

Re: [openstreetmap/openstreetmap-website] Test changeset tags in api changeset show responses (PR #5703)

2025-02-18 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 2 commits. c3dc1b77704d5a12213a92f1ae57cc707756155d Convert json changeset tags and comments test to tags test 532275fa93e3286e97bc45fd9e38e50e9c79c1b4 Add xml changeset tags test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5703/files/

[openstreetmap/openstreetmap-website] Bump @stylistic/eslint-plugin-js from 3.1.0 to 4.0.0 (PR #5704)

2025-02-18 Thread dependabot[bot] via rails-dev
Bumps [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js) from 3.1.0 to 4.0.0.
Release notes

Sourced from @​stylis


[openstreetmap/openstreetmap-website] Test changeset tags in api changeset show responses (PR #5703)

Tags were tested in json responses but together with comments, however tests for comments already exist with various conditions (hidden comments, hidden comments shown to moderators). Tags in xml responses weren't tested. You can view, comment on, or merge this pull request online at: https:/

Re: [openstreetmap/openstreetmap-website] Justify secondary nav (PR #5702)

AntonKhorev left a comment (openstreetmap/openstreetmap-website#5702) The menu is left-aligned to avoid jumping around horizontally when the page is loaded: [Screencast from 19.02.2025 01:28:08.webm](https://github.com/user-attachments/assets/9e958aca-dfc6-454c-9632-ff83f8de507a) -- Reply to

[openstreetmap/openstreetmap-website] Justify secondary nav (PR #5702)

Making the secondary nav flushed right while expanded and centered while in the small nav You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5702 -- Commit Summary -- * Justify secondary nav -- File Changes -- M

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

Merged #5700 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5700#event-16353474936 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

tomhughes left a comment (openstreetmap/openstreetmap-website#5700) Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5700#issuecomment-2666568722 You are receiving this because you are subscribed to this t

Re: [openstreetmap/openstreetmap-website] New Changeset Commenting Rate Limit? (Issue #5701)

tomhughes left a comment (openstreetmap/openstreetmap-website#5701) No, there has been no change to the limits, but multiple factors feed into the limits - most likely somebody has reported an issue with some of your comments and that has caused you to be more strictly limited until the investig

Re: [openstreetmap/openstreetmap-website] New Changeset Commenting Rate Limit? (Issue #5701)

Closed #5701 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5701#event-16353063548 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

[openstreetmap/openstreetmap-website] New Changeset Commenting Rate Limit? (Issue #5701)

pa5cal created an issue (openstreetmap/openstreetmap-website#5701) ### URL _No response_ ### How to reproduce the issue? I have never previously encountered any problems with rate limits when commenting on changesets using my account ([pitscheplatsch](https://www.openstreetmap.org/user/pitsch

Re: [openstreetmap/openstreetmap-website] Adds non-mutable note tags support (PR #5344)

@nenad-vujicic commented on this pull request. > +# Table name: note_tags +# +# note_id :bigint(8)not null, primary key +# k :string default(""), not null, primary key +# v :string default(""), not null +# +# Foreign Keys +# +# note_tags_id_fkey (note

Re: [openstreetmap/openstreetmap-website] Adds non-mutable note tags support (PR #5344)

@nenad-vujicic commented on this pull request. > @@ -0,0 +1,12 @@ +class CreateNoteTags < ActiveRecord::Migration[7.2] + def change +# Create a table, primary and foreign keys +create_table :note_tags, :primary_key => [:note_id, :k] do |t| + t.column "note_id", :bigint, :null => fa

Re: [openstreetmap/openstreetmap-website] Pre-center objects with embed-data (PR #5700)

tyrasd left a comment (openstreetmap/openstreetmap-website#5700) Yeah, this seems good to me. Thanks @hlfan -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5700#issuecomment-2665645883 You are receiving this because you are subsc

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

Closed #5698. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#event-16347893361 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] don't set map coords if mapParams contains object, but no "map" in hash (PR #5698)

tyrasd left a comment (openstreetmap/openstreetmap-website#5698) closing in favour of #5700 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5698#issuecomment-2665640851 You are receiving this because you are subscribed to this thr

Re: [openstreetmap/openstreetmap-website] Move edit account action to show (PR #5696)

gravitystorm left a comment (openstreetmap/openstreetmap-website#5696) > Thanks. I don't know what the answer is on the redirects but I'll merge this > - we can always remove those later if we can confirm they're not being used. I've always assumed that any "GET" page might be linked from elsewh

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

@kcne pushed 2 commits. dd5eb6401e8267d2a1edcd88425fda4721001757 Add heatmap data caching and query for user contributions ba919c3aa637a01bf413ec7430456faa0b096c07 Add tests for heatmap data in UsersController -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/

Re: [openstreetmap/openstreetmap-website] Add user profile heatmap visualization for contributions (PR #5402)

@kcne pushed 2 commits. d9a1d198ff59957bc3cd5861df0ea71957ec666d Add heatmap data caching and query for user contributions 377e33aa9aa294d4711f64837e194c7bad00b45b Add tests for heatmap data in UsersController -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/