@hlfan commented on this pull request.
> @@ -189,6 +192,20 @@ OSM.Directions = function (map) {
turnByTurnTable.append(row);
});
+ const download = exportGroup.toGeoJSON();
+ for (const i in endpoints) {
+download.features[i].properties["marker-color"] =
endp
@HolgerJeromin commented on this pull request.
> @@ -189,6 +192,20 @@ OSM.Directions = function (map) {
turnByTurnTable.append(row);
});
+ const download = exportGroup.toGeoJSON();
+ for (const i in endpoints) {
+download.features[i].properties["marker-color"]
Make `assert_single_changeset` check attributes that are always present in
changeset responses.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5697
-- Commit Summary --
* Always check changes/comments counts in sin
@AntonKhorev pushed 9 commits.
84c4ed3fa8e203aa4c84cbf4d735bfcbe456be8c Add base old element redactions
controller
984dd624dd27140ea554c305117fd5a175a595a2 Create node version redaction resource
8ccdc50313737f43d5f007b299977568ee0e8689 Create way version redaction resource
edaca6995c7be6817375
@AntonKhorev pushed 2 commits.
5887392fce50af9114597ff579a77df053c2bdc8 Update account path on web pages
2476985f22c9e03327e61305be57348e59f43278 Remove /account/edit path name
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5696/files/207ae6795d30f54ea03d1aaa
@AntonKhorev pushed 1 commit.
207ae6795d30f54ea03d1aaa01c4a535f72c7549 Remove /account/edit path name
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5696/files/0461efc7949c14ebc23317811c4ed53a985ca001..207ae6795d30f54ea03d1aaa01c4a535f72c7549
You are receiving
Does this
https://github.com/openstreetmap/openstreetmap-website/pull/5453#issuecomment-2661441402,
replacing `/account/edit` paths with `/account`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5696
-- Commit Summa
@AntonKhorev pushed 2 commits.
38a8a57a90cceacce0e4f4ce83cc60c77b372ece Don't display error messages when
second scheduled rc command fails
de4c09cbfd0511a0fc927921b84ac4b649fb69fa Return promise from
sendRemoteEditCommand()
--
View it on GitHub:
https://github.com/openstreetmap/openstreetma
@AntonKhorev pushed 1 commit.
5374ebd497ce7d26e79c44f44cb90a8d2b066992 Support unwrapped bbox values in
changeset history queries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473/files/d4a1e7574c097934c9b4af61e02ddd6e2380f784..5374ebd497ce7d26e79c44f44cb90
@AntonKhorev pushed 1 commit.
b42a3a5b4dc16eecc45301025c33aa60c3d20d6a Set directions starting point to
"Show My Location"
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5671/files/31639fbf840c7189864617a0bdc2457e481e63cf..b42a3a5b4dc16eecc45301025c33aa60c3d2
mmd-osm left a comment (openstreetmap/openstreetmap-website#5619)
> even the question of how much point there is in treating the two
> separately but that's another can of worms.
The idea to get rid of current tables in one way or another isn't entirely new.
Back in 2009, the infamous "Rant
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5692)
That is good:
> Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and
> will be fully unsupported by 2025-04-01
https://github.com/actions/runner-images/issues/11101
--
Reply to this email directly or
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5656)
Added a parameter on old routes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5656#issuecomment-2661532643
You are receiving this because you are subscribed
@AntonKhorev pushed 6 commits.
36619bcba1a97aea3896bc2c2dbf716c5a03246e Add base old element redactions
controller
8971795633e1c7ecd0f2df94dd354348efcc51b7 Create node version redaction resource
772b49fa589b026a88d477aad8974f47c9d1fae9 Create way version redaction resource
b987b768b36dcee86aad
tomhughes left a comment (openstreetmap/openstreetmap-website#5589)
I mean maybe it wasn't actually possible, but that was the logical effect of
the code.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5589#issuecomment-26615188
mmd-osm left a comment (openstreetmap/openstreetmap-website#5589)
> [...] if they were part of an invisible way that had nodes inside the
> bounding box [...]
Tbh, I don't really understand this use case, and I didn't find a corresponding
unit test for this specific scenario.
As soon as we de
tomhughes left a comment (openstreetmap/openstreetmap-website#5695)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5695#issuecomment-2661515266
You are receiving this because you are subscribed to this t
Merged #5695 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5695#event-16324658628
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 1 commit.
00d44580539494b7e85b56b294eafe523c6a4338 Enable exporting direction paths
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5694/files/42bb6d5bac6f7b4c7999abdf81cddc88806efc75..00d44580539494b7e85b56b294eafe523c6a4338
You are receiving thi
These were not needed at the end of most tests for quite some time, since rails
clears them by default for controller and integration tests, and also no longer
required in system tests after #5691
There's still some calls that could be removed, for example by also
automatically clearing `job` t
### Description
Closes #5224 by adding a link below the instructions table to download the
route as a geoJSON:
### How has this been tested?
The functionality? Locally.
The translation? Not yet...
You can v
gravitystorm left a comment (openstreetmap/openstreetmap-website#5692)
Yes, I agree. I used to think this was useful, but see all my previous mentions
of "Github flavoured Ubuntu" that shows it is of limited utility.
--
Reply to this email directly or view it on GitHub:
https://github.com/opens
Merged #5692 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5692#event-16324606222
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5693 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5693#event-16324570891
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5693)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5693#issuecomment-2661496978
You are receiving this because you are subscribed to this t
Tests for bugs fixed in #5679.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5693
-- Commit Summary --
* Test map panning when visiting changeset and note comment links
-- File Changes --
A test/system/browse
There's generally no point running on multiple versions as the important
things like ruby are note the OS versions in any case and production runs on
Debian now not Ubuntu.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pu
@tomhughes pushed 1 commit.
eaf084759bbc2f98f9b0953f8d37661e564c5f79 Allow users to delete their own diary
entries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4540/files/579c99fd1e90cdc361afae1627c442c037f704aa..eaf084759bbc2f98f9b0953f8d37661e564c5f79
You
@hlfan pushed 1 commit.
cc458d1870ed22e2d3d1b8dceab69716ade2e8d0 Split engines into providers and modes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652/files/850471ee5841a486d08ffeeaa6fd35f077fe28ef..cc458d1870ed22e2d3d1b8dceab69716ade2e8d0
You are receivi
@hlfan pushed 2 commits.
89e63d149b12ecd77a22fe29eecdcc1513315c7a Add button for directions from
location
1cbe5968808f831e40280986ef475a50cd5f65b8 Associate search input with route
destination instead of departure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/p
mmd-osm left a comment (openstreetmap/openstreetmap-website#5619)
> I can see that changeset_subscribers is accessed by cgimap, for example.
> Would that be a blocker?
I don't think so. The code you've found in cgimap is not used in production.
Rails is taking care of the changeset create endp
Closed #5687 as completed via #5691.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5687#event-16324419577
You are receiving this because you are subscribed to this thread.
Message ID:
_
Closed #5687 as completed via 8fcd4513fcbffec76cc2c1a807810f7ab9b3446f.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5687#event-16324419587
You are receiving this because you are subscribed to this thread.
Message ID:
__
gravitystorm left a comment (openstreetmap/openstreetmap-website#5691)
Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5691#issuecomment-2661465853
You are receiving this because you are subscribed to this thread.
Message
gravitystorm left a comment (openstreetmap/openstreetmap-website#5690)
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5690#issuecomment-2661465692
You are receiving this because you are subscribed to this thread.
Merged #5691 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5691#event-16324419542
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5690 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5690#event-16324416245
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Make sure system tests clear deliveries before and after running as controller
and integration tests already do.
Fixes #5687.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5691
-- Commit Summary --
* Clear test d
tomhughes left a comment (openstreetmap/openstreetmap-website#5687)
So the `ActionMailer::TestCase::ClearTestDeliveries` module you pointed at is
already included in `ActionDispatch::IntegrationTest` by rails and is therefore
used by controller and integration tests but not by system tests.
--
Adds ruby 3.4 to the test matrix...
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5690
-- Commit Summary --
* Add ruby 3.4 to test matrix
-- File Changes --
M .github/workflows/tests.yml (2)
-- Patch Links -
Merged #5688 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5688#event-16324354818
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5689 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5689#event-16324350553
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5689)
Merged, thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5689#issuecomment-2661453329
You are receiving this because you are subscribed to this thread.
gravitystorm left a comment (openstreetmap/openstreetmap-website#5619)
> Have you also evaluated the other way around, i.e. change the model names to
> match the db table names?
Yes, I've considered it. But I think that in some cases this would not be
wanted - for example, renaming the `Follow
@tomhughes pushed 2 commits.
a87cd780d6f37518e7e7ff19ec4027b3b1323518 Only count reports from distinct
users in spam checks
b68aa8f3ddeb4e644915b4970d46a6cb169733db Make reports trigger a spam check on
the reported user
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-web
tomhughes left a comment (openstreetmap/openstreetmap-website#5688)
Added a test, and also fixed the scoring to prevent one user making multiple
reports to increase the score.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5688#
Closed #5670 as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#event-16324305188
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
This is the cleanups from #5453 without the main change to switch to turbo.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5689
-- Commit Summary --
* Replace count.zero? with empty?
* Move errors from email to ne
@gravitystorm requested changes on this pull request.
Needs tests. Mostly just to demonstrate to other developers what it's supposed
to achieve, but also so that if we add auto-close for issues (or similar) in
future, we don't accidentally break this part during refactoring.
--
Reply to this
gravitystorm left a comment (openstreetmap/openstreetmap-website#5453)
I think I would prefer something similar to #5449 (reasoning at
https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2578415862
).
--
Reply to this email directly or view it on GitHub:
https://githu
gravitystorm left a comment (openstreetmap/openstreetmap-website#5670)
> Reporting failed job as success would not be really better in this case.
If I understand correctly, this is not failed jobs but jobs with errors. So if
the job runs, but for example the overall coverage is too low, then the
tomhughes left a comment (openstreetmap/openstreetmap-website#5685)
This looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5685#issuecomment-2661431109
You are receiving this because you are subscribed to t
As suggested in #5676 this triggers a spam check on a reported user after the
report is saved, as their score may have changed.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5688
-- Commit Summary --
* Make report
Merged #5685 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5685#event-16324225038
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> +# Table name: note_tags
+#
+# note_id :bigint(8)not null, primary key
+# k :string default(""), not null, primary key
+# v :string default(""), not null
+#
+# Foreign Keys
+#
+# note_tags_id_fkey (note_id
@tomhughes commented on this pull request.
> @@ -34,17 +34,17 @@ OSM.NewNote = function (map) {
});
function createNote(location, text, callback) {
-$.ajax({
- url: "/api/0.6/notes.json",
- type: "POST",
- oauth: true,
- data: {
+fetch("/api/0.6/notes.json?",
tomhughes left a comment (openstreetmap/openstreetmap-website#5278)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5278#issuecomment-2661425824
You are receiving this because you are subscribed to this t
Merged #5278 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5278#event-16324208408
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -34,17 +34,17 @@ OSM.NewNote = function (map) {
});
function createNote(location, text, callback) {
-$.ajax({
- url: "/api/0.6/notes.json",
- type: "POST",
- oauth: true,
- data: {
+fetch("/api/0.6/notes.json?",
gravitystorm left a comment (openstreetmap/openstreetmap-website#5676)
Merged thanks. As discussed, a followup could be for the report creation
process to also trigger the `user.spam_check` process
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
@hlfan commented on this pull request.
> @@ -34,17 +34,17 @@ OSM.NewNote = function (map) {
});
function createNote(location, text, callback) {
-$.ajax({
- url: "/api/0.6/notes.json",
- type: "POST",
- oauth: true,
- data: {
+fetch("/api/0.6/notes.json?", {
D
Merged #5558 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#event-16324026567
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5676 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5676#event-16324034251
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
gravitystorm left a comment (openstreetmap/openstreetmap-website#5558)
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#issuecomment-2661394390
You are receiving this because you are subscribed to this thread.
gravitystorm created an issue (openstreetmap/openstreetmap-website#5687)
In the last few days I've seen a lot of test suite failures with messages
similar to:
```
Failure:
UserSignupTest#test_Sign_up_with_confirmation_email
[test/system/user_signup_test.rb:37]:
expected to find text "new_user_a
Closed #648 as completed via 793757a6ff4a6ca3cb7ad5454fec1c51fe63804f.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/648#event-16323960799
You are receiving this because you are subscribed to this thread.
Message ID:
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2619602000
You are receiving this because you are subscribed to this thread.
Message ID:
__
tomhughes left a comment (openstreetmap/openstreetmap-website#5686)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5686#issuecomment-2661381664
You are receiving this because you are subscribed to this t
@tomhughes pushed 2 commits.
f83424aeb20cf371925094c6640ff407185cc0a4 Update eslint to prefer let/const
over var
c47cb299a842a2eb7d022fcf4f0d02c08001f928 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Merged #5686 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5686#event-16323960802
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5683 as completed via #5686.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5683#event-16323960837
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tyrasd pushed 1 commit.
793757a6ff4a6ca3cb7ad5454fec1c51fe63804f don't pan map wen
closing/reopening/commenting a note, fixes #648
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5686/files/3a016a5f164ea40ebdc29cc6d3fdf799700172c2..793757a6ff4a6ca3cb7ad5454fe
Fixes #5683 (a regression in #5679): the problem was that when clicking on a
new note on the map, the URL hash with the `map` parameter is cleared somewhere
before `pushstate` gets called, resulting in the map to be panned in
`map.addObject` during the `initialize` step. It's now solved by pass
tyrasd left a comment (openstreetmap/openstreetmap-website#5683)
sorry, this was an unintended side effect of #5679. working on a fix now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5683#issuecomment-2661343897
You are rece
tomhughes left a comment (openstreetmap/openstreetmap-website#5656)
I've just discussed this with @gravitystorm and we think the fallback code
should only be enabled when the old route is used - the best way to do that is
probably to have the route set a flag parameter and then make the action o
@tomhughes pushed 2 commits.
887ec6f6ef56ce660a43306dd771d8768e7b58b5 Update eslint to prefer let/const
over var
a2de8402b34f3d68e49260bd52b71fa837f83a4a Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
tomhughes left a comment (openstreetmap/openstreetmap-website#5558)
I've rebased this now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#issuecomment-2661341416
You are receiving this because you are subscribed to this thre
### Description
Remove the prefilter file entirely while moving the requests that use OAuth to
fetch.
### How has this been tested?
partially
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5685
-- Commit Summary --
@gravitystorm approved this pull request.
Needs rebase, but otherwise looks good to me. I agree it would be good to merge
this as soon as we can.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2619575372
Merged #4359 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4359#event-16323706600
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#4359)
This looks good to me. Thanks for keeping it alive for so long.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4359#issuecomment-2661332529
You are receiving thi
tomhughes left a comment (openstreetmap/openstreetmap-website#5684)
I usually just hack to code temporarily to do that, but it looks good to me,
thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5684#issuecomment-2661320634
Merged #5684 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5684#event-16323643765
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
83 matches
Mail list logo
