matkoniecz left a comment (openstreetmap/openstreetmap-website#5670)
Reporting failed job as success would not be really better in this case.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#issuecomment-2661279575
You are r
matkoniecz left a comment (openstreetmap/openstreetmap-website#5683)
@tyrasd Is it intentional that clicking on note zooms you out?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5683#issuecomment-2661278889
You are receiving t
Continues #5672.
System test normally run in a headless browser, which is what you want if you
run the entire test suite. But when writing and running a single test, it's
useful to see what's happening. This PR adds a setting to choose whether
tests should run in a headless Firefox.
You can vie
Closed #3167 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3167#event-16323056436
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
AntonKhorev left a comment (openstreetmap/openstreetmap-website#3167)
"My Settings" were renames to "My Account" in #5681, addressing
https://github.com/openstreetmap/openstreetmap-website/issues/3167#issuecomment-921037992.
I think this issue is mostly done.
--
Reply to this email directly or
HolgerJeromin left a comment (openstreetmap/openstreetmap-website#5558)
Can we merge this please?
At least I hesitate to do small things which only creates conflicts with this
PR
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#5682)
Superseded by #5683.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5682#issuecomment-2661083972
You are receiving this because you are subscribed to this
ntaulbut left a comment (openstreetmap/openstreetmap-website#5683)
> This issue might be a regression from
> [#5679](https://github.com/openstreetmap/openstreetmap-website/pull/5679).
Looks like it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
danieldegroot2 left a comment (openstreetmap/openstreetmap-website#5683)
This issue might be a regression from #5679.
It has similar behavior to #648.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5683#issuecomment-2661071336
ntaulbut created an issue (openstreetmap/openstreetmap-website#5683)
### Problem
Recently a behaviour was introduced where selecting a note centres the map on
the note, and zooms out to a certain level if currently zoomed in further than
that level. This is a problem:
1. When browsing notes, w
matkoniecz left a comment (openstreetmap/openstreetmap-website#5682)
closing as someone else told me that they make issue about this with more info
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5682#issuecomment-2661059075
You
Closed #5682 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5682#event-16322445435
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
matkoniecz created an issue (openstreetmap/openstreetmap-website#5682)
### URL
_No response_
### How to reproduce the issue?
zoom to https://www.openstreetmap.org/#map=19/51.213986/3.251690&layers=N
click on left note
clink on right note
you get zoomed out which is unwanted and pointless
#
gravitystorm left a comment (openstreetmap/openstreetmap-website#5677)
Could do with some tests, and there's no handling of error states if you (ahem)
make a mistake when entering IP subnets.
But otherwise looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.c
Merged #5677 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5677#event-16322233551
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5681)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5681#issuecomment-2661018313
You are receiving this because you are subscribed to this t
Merged #5681 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5681#event-16322231598
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5680 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680#event-16322230328
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5680)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680#issuecomment-2661018021
You are receiving this because you are subscribed to this t
@gravitystorm pushed 1 commit.
2edceb4b613c572ca330e5bb1fcd9974f23119d5 Use title case consistently for nav
tab labels
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680/files/552f82ad4e37c5dffc2d2d3b18822a6eedefea2e..2edceb4b613c572ca330e5bb1fcd9974f23119d5
It's hard to make a distinction between 'Preferences' and
'Settings' in some languages, and many other sites use the term
'Account' for things like changing email.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5681
@gravitystorm pushed 1 commit.
b9b1c73f23c9aedb08ebeb9a6b5815e0f666ef1c Use title case consistently for nav
tab labels
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680/files/0a4977c0654e91bf8643e2495d42878056a2834b..b9b1c73f23c9aedb08ebeb9a6b5815e0f666ef1c
Merged #4926 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4926#event-16322170908
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #1810 as completed via #4926.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1810#event-16322170959
You are receiving this because you are subscribed to this thread.
Message ID:
_
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5678)
Merged, thanks.
Not for anyone checking this update: it doesn't necessarily invalidate already
incorrectly cached pages.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
Closed #669 as completed via #4926.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/669#event-16322170965
You are receiving this because you are subscribed to this thread.
Message ID:
___
tomhughes left a comment (openstreetmap/openstreetmap-website#4926)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4926#issuecomment-2661006657
You are receiving this because you are subscribed to this t
Merged #5678 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5678#event-16322163362
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@gravitystorm pushed 1 commit.
552f82ad4e37c5dffc2d2d3b18822a6eedefea2e Use title case consistently for nav
tab labels
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5680/files/b9b1c73f23c9aedb08ebeb9a6b5815e0f666ef1c..552f82ad4e37c5dffc2d2d3b18822a6eedefea2e
Closed #5663 as completed via b1397d9fc34ef0e7da061d94963d7610d1b9cf34.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5663#event-16322163364
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #4301 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4301#event-16322133133
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
In almost all tab navs we already use [title
case](https://en.wikipedia.org/wiki/Title_case), and this PR changes the
remaining few to match.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5680
-- Commit Summary --
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5277)
Merged in #5131.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5277#issuecomment-2660997895
You are receiving this because you are subscribed to this thread.
@tomhughes approved this pull request.
This looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4301#pullrequestreview-2619458543
You are receiving this because you are subscribed to this thread.
Messa
Closed #5277.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5277#event-16322116634
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@AntonKhorev pushed 2 commits.
1f59507e78e16a281407f16b804e2111323bc767 Add changeset comment search api with
filtering by author and time
2a5051376aac75c95cc57e3f39c3868cd5cf7c9f Add changeset comment search api json
format
--
View it on GitHub:
https://github.com/openstreetmap/openstreetma
Merged #5131 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5131#event-16322096668
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5131)
Most of the discussion here seems to be about whether this goes far enough but
I don't see any significant complaints about the things this does do, and it
looks good to me so I'm going to merge it.
If people want to propose ad
@AntonKhorev pushed 2 commits.
fd206473207d4e1c6c67c6a062676b678103ba45 Test more block attributes in show
call
6569ed24e4bcc74b8fcbdd70591d4c4a6d907691 Add user block api call
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4301/files/fef78b57db11f9bcb2434d4
tomhughes left a comment (openstreetmap/openstreetmap-website#5679)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5679#issuecomment-2660989708
You are receiving this because you are subscribed to this t
Merged #5679 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5679#event-16322047643
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #865 as completed via b14965e4b211ad7eece9b8a77b984c140744dc8f.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/865#event-16322047640
You are receiving this because you are subscribed to this thread.
Message ID:
@AntonKhorev pushed 6 commits.
d92fc6e526c90ffb2e2f4536f1e8f931bb450ee4 Move common query limit method of
changesets and notes to mixin
989b110bfc804e2c681b12523f20940af205680d Add changeset comment query limit
settings; use common query limit in changeset comment feeds
500c1bddf2640c0b59e8d76
@tomhughes pushed 2 commits.
b3e0a7b5fd43680e3ca992ac7c31a9bfb09c47a6 Update eslint to prefer let/const
over var
61760af161bab1b8a91dc08df63d139d70185e1c Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Fix for #865. Unfortunately, the code is slightly different between OSM objects
(nodes/ways/relations), notes and changesets. I tried to make it somewhat more
coherent by always using the `map.addObject({}, callback)` approach to zoom to
the location if the `hash` parameters had no location info
@AntonKhorev pushed 5 commits.
c9e3a20dc0484b891dd703edbea27205bd6c3f30 Move http-equiv and viewport meta
tags to meta template
328c4fce50037c6e9b294effbd7180a9e41201db Use system font on error pages
fa58f34b2c14391e3d737a1c73494613b5db10eb Adjust logo css on error pages
3ba243a66a8865b8f7cdf4
@AntonKhorev pushed 4 commits.
bd443cdfb11248b24f188857dfa6a8c83a273916 Add empty account home page
aec885815ec49c0a6b7f71ed87758b6e7902e4bf Show/hide marker in account home js
controller
5c019cd2eef41a4e75a2640f19f674431cf67733 Add "Go to Home Location" to every
page, link it to account home
tomhughes left a comment (openstreetmap/openstreetmap-website#5672)
Thanks, this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5672#issuecomment-2660980120
You are receiving this because you are subscribed
Merged #5672 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5672#event-16321978619
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5607.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5607#event-16321975637
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
mmd-osm left a comment (openstreetmap/openstreetmap-website#5607)
It seems there's no need to support optional attribution. I'm going to close
this PR and create another one for this webp one liner:
```
diff --git a/app/assets/javascripts/leaflet.share.js
b/app/assets/javascripts/leaflet.share.
@AntonKhorev commented on this pull request.
> @@ -182,3 +182,5 @@ smtp_password: null
# -BEGIN PRIVATE KEY-
# ...
# -END PRIVATE KEY-
+# Override Firefox binary used in system tests
+#system_test_firefox_binary:
Moved to `config/settings/test.yml`.
Then we have to update
@AntonKhorev pushed 1 commit.
b58a70262ec52a8d1ed5701badac75ae9f84afd0 Add option to override Firefox binary
used in system tests
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5672/files/20c7c020303157a38d92946983746553bc678eba..b58a70262ec52a8d1ed5701badac7
@tomhughes commented on this pull request.
> @@ -182,3 +182,5 @@ smtp_password: null
# -BEGIN PRIVATE KEY-
# ...
# -END PRIVATE KEY-
+# Override Firefox binary used in system tests
+#system_test_firefox_binary:
Actually the github workflow does run it with `RAILS_ENV=test`
@AntonKhorev commented on this pull request.
> @@ -182,3 +182,5 @@ smtp_password: null
# -BEGIN PRIVATE KEY-
# ...
# -END PRIVATE KEY-
+# Override Firefox binary used in system tests
+#system_test_firefox_binary:
Is teaspoon supposed to be run in test environment?
--
Rep
@tomhughes commented on this pull request.
> @@ -182,3 +182,5 @@ smtp_password: null
# -BEGIN PRIVATE KEY-
# ...
# -END PRIVATE KEY-
+# Override Firefox binary used in system tests
+#system_test_firefox_binary:
That's actually an excellent question - my answer would be yes
@AntonKhorev pushed 1 commit.
d4a1e7574c097934c9b4af61e02ddd6e2380f784 Support unwrapped bbox values in
changeset history queries
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473/files/b6d2f261b579a803f68d4b69ba9f45ce20bc2bac..d4a1e7574c097934c9b4af61e02dd
tomhughes left a comment (openstreetmap/openstreetmap-website#5233)
This looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5233#issuecomment-2660969747
You are receiving this because you are subscribed
@AntonKhorev pushed 5 commits.
e7723f86457e14e9f18ab537a439f37a3e63586c Add empty account blocks page
d4e3323856eb62a356f896e5636ea2f9509bfcad Add redirect from accounts block page
to needs_view block
60c9ff9b641052bda05f771881e5579ffaf5fd0c Add redirect from accounts block page
to active blo
Merged #5233 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5233#event-16321895028
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5678)
We already have the same problem with Turbo where we do frame updates promoted
to page visits. We only do this in newer/older pagination. See #5175.
--
Reply to this email directly or view it on GitHub:
https://github.com/ope
tomhughes left a comment (openstreetmap/openstreetmap-website#5521)
It still seems to be restricted to half the screen for me:
--
Reply to this email directly or view it on GitHub:
https://github.com/open
Long term we should fix the sidebar to use turbo but for now this fixes #5663.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5678
-- Commit Summary --
* Prevent caching a partial XHR response as a full page URL
--
tomhughes left a comment (openstreetmap/openstreetmap-website#5663)
That change does indeed seem to be the cause.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5663#issuecomment-2660963705
You are receiving this because you ar
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5521)
Left sidebar used to cover the entire screen in the small layout. Later a fix
which I can't find was applied to make it cover only a half. This PR probably
fixes that fix.
--
Reply to this email directly or view it on GitHub
tomhughes left a comment (openstreetmap/openstreetmap-website#5667)
> How will that code know if the first comment has been already deleted for a
> given note? It can't just be `all_comments.drop(1)` for example, since that
> won't work after the next migration has completed.
I was imagining de
@tomhughes commented on this pull request.
> + note_ids = notes.pluck(:id)
+
+ sql_query = <<-SQL.squish
+WITH first_comment AS(
+ SELECT DISTINCT ON (note_id) *
+ FROM note_comments
+ WHERE note_id BETWEEN #{note_ids.min} AND #{note_ids.max}
+
Closed #2621.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2621#event-16321817270
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Merged #5521 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521#event-16321799200
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks for the fix - this looks good to me now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521#pullrequestreview-2619424293
You are receiving this because you are subscribed to this t
This enhances the user list view for administrators to include a search
parameter bar at the top, to allow searching by IP subnet, and to properly
preserve all search fields in links.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap
Merged #5363 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5363#event-16321783639
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #4130 as completed via #5363.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4130#event-16321783673
You are receiving this because you are subscribed to this thread.
Message ID:
_
gravitystorm left a comment (openstreetmap/openstreetmap-website#5363)
This looks good to me, and in particular I'm grateful for the move towards
resolving #4130.
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5
gravitystorm left a comment (openstreetmap/openstreetmap-website#5514)
Merged, thanks @AntonKhorev
I also agree with @simonpoole, and I would be happy to remove the check box
entirely and drop the database column too. However, I feel that this would be a
topic that would benefit from wider fee
Merged #5514 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5514#event-16321709529
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@deevroman pushed 1 commit.
8e1e1e47134b652bd1a5facba44280f05cc802fa Fix left/right sidebar resizing on
mobile devices
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/b6cc806f76c46e5a416fd4de7314b531a60c7f16..8e1e1e47134b652bd1a5facba44280f05cc802fa
I think this should be reasonably safe - it will need three reports to trigger
a suspension or possibly less if there are already links in the content adding
to a score.
Given the negative influence of edits on the score it's unlikely that
people reporting users for map spam will manage to trig
@gravitystorm commented on this pull request.
> @@ -347,15 +347,22 @@ L.OSM.Map = L.Map.extend({
},
setSidebarOverlaid: function (overlaid) {
-var sidebarWidth = 350;
+var mobileDeviceWidth =
window.getComputedStyle(document.documentElement).getPropertyValue("--bs-breakpoint-md"
gravitystorm left a comment (openstreetmap/openstreetmap-website#865)
This is also a problem with the notes comment feed, which contains links with
fragments (targetting the comment id).
`curl
https://www.openstreetmap.org/api/0.6/notes/feed?bbox=8.1706155,51.8144663,8.5269845,51.9737924`
```
tomhughes left a comment (openstreetmap/openstreetmap-website#2621)
It's been pointed out on #5200 that this could be simplified by using the
`tag2link` npm package and loading the JSON data it includes - we'd probably
want to only link things with a rank of `preferred` if only to avoid having
@tomhughes commented on this pull request.
This mostly looks fine for me and seems to work well, or at least much better
than what we have now! I've just added one inline comment.
> @@ -347,15 +347,22 @@ L.OSM.Map = L.Map.extend({
},
setSidebarOverlaid: function (overlaid) {
-var sid
deevroman left a comment (openstreetmap/openstreetmap-website#5521)
Okay, it seems that this PR at least does not make it worse.
The only regression I noticed was a noticeable shift of the map with the note
marker when opening the left and right sidebars at the same time. But I think
this is a
gabortim left a comment (openstreetmap/openstreetmap-website#5200)
You can use [JOSM/tag2link](https://github.com/JOSM/tag2link) to eliminate the
need for manually adding new tags. It includes a static JSON file suitable for
deployment. Since it's a built-in component of JOSM, if it functions co
gravitystorm left a comment (openstreetmap/openstreetmap-website#5656)
I think my main comment here is about the resource naming. It doesn't feel
quite right to say that we are creating a "redaction" since we need to pass a
redaction_id while doing so. It feels to me like the resource name is no
@gravitystorm commented on this pull request.
I would also interested in what the next step will be. How do you propose
removing the first comments, when they are no longer used? That migration will
need to work in an "online" manner, i.e. there needs to be code that runs
before the migration,
@tomhughes requested changes on this pull request.
> @@ -0,0 +1,10 @@
+class CreateSocialLinks < ActiveRecord::Migration[7.2]
+ def change
+create_table :social_links do |t|
+ t.references :user, :null => false, :foreign_key => true
+ t.string :url
This should have `:null => fals
@deevroman pushed 1 commit.
b6cc806f76c46e5a416fd4de7314b531a60c7f16 Fix left/right sidebar resizing on
mobile devices
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521/files/898ea3d1bc17468e3cfef0e36b6127e9208e70c0..b6cc806f76c46e5a416fd4de7314b531a60c7f16
Merged #5452 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5452#event-16321353285
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5521)
This PR is marked as draft - if it's ready for review can you clear the draft
flag please?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5521#issuecomment-2660
@tomhughes pushed 2 commits.
acabad71a669c632bea8b96e9edbf0e37a763e43 Update eslint to prefer let/const
over var
83dde9e78e9ea4eb6a7be3e5cb43bf740082f6b2 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Closed #5662.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5662#event-16321102866
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
tomhughes left a comment (openstreetmap/openstreetmap-website#5662)
Superseded by #5669.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5662#issuecomment-2660832367
You are receiving this because you are subscribed to this thread
Merged #5669 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#event-16321099868
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks for the changes. I think this all looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#pullrequestreview-2619362102
You are receiving this because you are subscribed
tomhughes left a comment (openstreetmap/openstreetmap-website#5673)
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5673#issuecomment-2660823586
You are receiving this because you are subscribed to this t
Merged #5674 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5674#event-16321062445
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5675 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5675#event-16321062448
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5673 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5673#event-16321062450
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5674)
Yes I was thinking much the same thing the other day... Looks good to me,
thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5674#issuecomment-2660823042
Yo
1 - 100 of 102 matches
Mail list logo
