You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5675
-- Commit Summary --
* Use changeset tag factory in api changeset json test
-- File Changes --
M test/controllers/api/changesets_controller_test.rb (15)
--
Previously it was possible to create a note while authorized but having no
write_notes scope. The scope check was added to fix #4362.
Currently it's not possible to create notes in this manner and there's
a test for that:
https://github.com/openstreetmap/openstreetmap-website/blob/f5af8befa9ffe0
Unreachable because if there's no `doorkeeper_token`, there's also no
`current_user`.
This is the only place in the api where `current_user` is set:
https://github.com/openstreetmap/openstreetmap-website/blob/f5af8befa9ffe0c95f4a3c58d2fbb63a2e971ab0/app/controllers/api_controller.rb#L105
You can
pnorman left a comment (openstreetmap/openstreetmap-website#5607)
I was originally in favour of optional attribution, but @matkoniecz arguments
persuade me to think it should always be there.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
gravitystorm left a comment (openstreetmap/openstreetmap-website#5667)
In my own projects, we use a different approach for data migrations.
* First, we avoid using rails built-in database migrations. These are great for
structure changes, but not for data changes, since they can't be tested. And
Addresses #5488 by providing a setting instead of workarounds such as modifying
`test/application_system_test_case.rb`.
I'm also using these workarounds and it's annoying because you can
accidentally commit them. But if there's a setting, I can put it in some
file that's ignored by git, for exa
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5671#pullrequestreview-2618029199
You are receiving this because you are subscribed to this thread.
Message ID:
__
hlfan left a comment (openstreetmap/openstreetmap-website#5652)
I wanted to split the translations first and move to an engine select and
transport mode radio toggle buttons later, as restructuring the engines in an
intermediate step seemed the best way to go about it.
Doing it as three smaller
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5671)
Updated
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5671#issuecomment-2659435388
You are receiving this because you are subscribed to this thread.
Message
AntonKhorev left a comment (openstreetmap/openstreetmap-website#5652)
Why would you do lego instead of two selects for mode and provider?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652#issuecomment-2659415286
You are receivi
@AntonKhorev pushed 1 commit.
31639fbf840c7189864617a0bdc2457e481e63cf Set directions starting point to
"Show My Location"
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5671/files/31bd74c83ea69efc9bd0f8b92fccd29dd1af656a..31639fbf840c7189864617a0bdc2457e481e
@nertc commented on this pull request.
> @@ -10,6 +10,35 @@ $(document).ready(function () {
var defaultHomeZoom = 12;
var map, marker, deleted_lat, deleted_lon;
+ if ($("#social_links").length) {
+$("#add-social-link").click(function (event) {
+ event.preventDefault();
+ c
@nertc pushed 1 commit.
75cdfa75197d927b7723c87a8b79606a5b318130 Add social profile links
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439/files/922a34e9903a0f5ec7dde390d9a225895ef8d1ab..75cdfa75197d927b7723c87a8b79606a5b318130
You are receiving this becaus
@AntonKhorev commented on this pull request.
> @@ -4,24 +4,24 @@
"@aashutoshrathi/word-wrap@^1.2.3":
version "1.2.6"
- resolved
"https://registry.yarnpkg.com/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz#bd9154aec9983f77b3a034ecaa015c2e4201f6cf";
+ resolved
"https://registry.npmjs.or
hlfan left a comment (openstreetmap/openstreetmap-website#5558)
> All occurrences of `var` are changed with `let/const`. Checked all changed
> variables and `let` and `const` are set accordingly (every variable that is
> not changed after declaration, is `const`).
[ESLint
concurs](https://gith
nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5667)
> I think this will do the job, obviously with batches of note IDs in the CTE
> expression:
>
Thanks! I think I fixed it (with the latest push). Here is the code:
```ruby
Note.in_batches(:of => 1000) do |notes|
note_ids =
@nenad-vujicic pushed 1 commit.
dbd15559df90af44f226d8843b9ca312a8672649 Copies description, user_id and
user_ip to notes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5667/files/757e22a1d37b83b1e5bb2ae6da390dcf4e1d002e..dbd15559df90af44f226d8843b9ca312a8672
@nertc approved this pull request.
All occurrences of `var` are changed with `let/const`. Checked all changed
variables and `let` and `const` are set accordingly (every variable that is not
changed after declaration, is `const`). Also spent some time on website to test
it generally, if any page
@AntonKhorev pushed 3 commits.
6d558003aa5672a27362ae3f42627df50bd81ad1 Add active blocks list api endpoint
with empty response
9ec7e8c888cc534bcdc2632a34f27e5853bb4241 Skip blocks check when getting active
blocks list
f6572e3712630666a219a6cd6d2fcfcde8cea66c Output active blocks list
--
Vi
@AntonKhorev pushed 6 commits.
953502d226b377d5a8ade8c00c6fd61b1158 Add base old element redactions
controller
98f8f7d4438ab9e6485d6496510ca52311ed36e9 Create node version redaction resource
e5dcc8b045c1bb5e8336045c7717c1e5df6d5f76 Create way version redaction resource
01d489f753bea836dcf4
AntonKhorev left a comment (openstreetmap/openstreetmap-website#2631)
> When a user comments on a changeset, they will be automatically subscribed
> anyway, and the permission should also include those operations.
I'm not sure what to do with subscribe/unsubscribe. Commenting a changeset
subscr
@hlfan pushed 2 commits.
e87a71dca1a3001b736ddbc2486de9fb0de8acb3 Add button for directions from
location
1296aeec2920a1a9834c55129132db63efe5b02b Associate search input with route
destination instead of departure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/p
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#pullrequestreview-2617098758
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan pushed 1 commit.
bf194952d78d3d3a0ca0f61bb6142168ad28f1ad Transition more requests to fetch
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669/files/282fd28207cc7287ed5a4c22360f7e6ce3675749..bf194952d78d3d3a0ca0f61bb6142168ad28f1ad
You are receiving th
24 matches
Mail list logo
