hlfan left a comment (openstreetmap/openstreetmap-website#5671)
This will set the starting point marker regardless of whether the user is on
the directions page.
--
Reply to this email directly or view i
@hlfan pushed 1 commit.
282fd28207cc7287ed5a4c22360f7e6ce3675749 Transition more requests to fetch
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669/files/659162256f7eec6dcd6afdea7d18cb6a5d565fd0..282fd28207cc7287ed5a4c22360f7e6ce3675749
You are receiving th
@hlfan commented on this pull request.
> @@ -71,30 +71,28 @@ OSM.initializeNotesLayer = function (map) {
var size = bounds.getSize();
if (size <= OSM.MAX_NOTE_REQUEST_AREA) {
- var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" +
bounds.toBBoxString();
+ var url = "
@hlfan commented on this pull request.
>method: "POST",
- data: {
+ headers: { "Content-Type": "application/x-www-form-urlencoded" },
Removed all three.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#dis
@hlfan commented on this pull request.
>
$(this).hide();
div.find(".loader").show();
-params[csrf_param] = csrf_token;
+params.append(csrf_param, csrf_token);
Nope, fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
@hlfan commented on this pull request.
>$("#browse_status").empty();
-}
-
-if (XMLHttpRequest.status === 400 && XMLHttpRequest.responseText) {
- displayLoadError(XMLHttpRequest.responseText, closeError);
-} else if (XMLHttpRequest.statusText) {
-
@hlfan pushed 1 commit.
659162256f7eec6dcd6afdea7d18cb6a5d565fd0 Transition more requests to fetch
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669/files/942fc190ebffe9dca6cb1f709da470034dccc823..659162256f7eec6dcd6afdea7d18cb6a5d565fd0
You are receiving th
@hlfan commented on this pull request.
>
- noteLoader = null;
+ for (var id in oldNotes) {
+noteLayer.removeLayer(oldNotes[id]);
+ }
+})
+.catch(() => {})
> have a no-op catch on all of them?
Currently, I only put catches on fetches with Abo
Answers the question
https://github.com/openstreetmap/openstreetmap-website/pull/5635#issuecomment-2646420820.
If the location was already acquired with *Show My Location*, it is used as a
starting location in *Directions* if
- the starting location is empty AND
- no `route` param was provided (
Closed #2631 as completed via #5666.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2631#event-16303361719
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5666 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5666#event-16303361525
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Thanks - this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5666#pullrequestreview-2616323774
You are receiving this because you are subscribed to this thread.
Message ID
@AntonKhorev commented on this pull request.
> allow_write_prefs: modify their user preferences
allow_write_diary: create diary entries and comments
-allow_write_api: modify the map
-allow_read_gpx:read their private GPS traces
-allow_write_gpx:
@AntonKhorev pushed 11 commits.
1632d010d3158cc0765fd4cd20cc46d784a31028 Rename api changeset comment tests
4073e0fc4784794eefa9922964cba1f807515e63 Split api changeset comment create
fail tests
c9057188aab64e39635c4230b117bf98ce667307 Split api changeset comment create
scope and terms tests
@tomhughes commented on this pull request.
>
- noteLoader = null;
+ for (var id in oldNotes) {
+noteLayer.removeLayer(oldNotes[id]);
+ }
+})
+.catch(() => {})
So this is what I wasn't sure about - what happens if a fetch is rejected and
noth
@hlfan commented on this pull request.
>
- noteLoader = null;
+ for (var id in oldNotes) {
+noteLayer.removeLayer(oldNotes[id]);
+ }
+})
+.catch(() => {})
Didn't have them there until I tested frantic map movement and AboetErrors
started to
@hlfan commented on this pull request.
> @@ -71,30 +71,28 @@ OSM.initializeNotesLayer = function (map) {
var size = bounds.getSize();
if (size <= OSM.MAX_NOTE_REQUEST_AREA) {
- var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" +
bounds.toBBoxString();
+ var url = "
@tomhughes commented on this pull request.
>$("#browse_status").empty();
-}
-
-if (XMLHttpRequest.status === 400 && XMLHttpRequest.responseText) {
- displayLoadError(XMLHttpRequest.responseText, closeError);
-} else if (XMLHttpRequest.statusText) {
-
Merged #5665 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5665#event-16301553789
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5668 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5668#event-16301553813
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
tomhughes left a comment (openstreetmap/openstreetmap-website#5667)
I think this will do the job, obviously with batches of note IDs in the CTE
expression:
```sql
WITH first_comment AS(
SELECT DISTINCT ON (note_id) *
FROM note_comments
WHERE note_id BETWEEN 1000 AND 2000
ORDER BY note_id
tomhughes left a comment (openstreetmap/openstreetmap-website#5667)
If it needs to be that complex then it should probably be a rake task not a
migration, but I'm pretty sure that is overengineered to an extraordinary
degree for something we're going to run once.
Why exactly are we getting "fai
@tomhughes requested changes on this pull request.
> allow_write_prefs: modify their user preferences
allow_write_diary: create diary entries and comments
-allow_write_api: modify the map
-allow_read_gpx:read their private GPS traces
-allow_write_g
hlfan created an issue (openstreetmap/openstreetmap-website#5670)
### URL
https://github.com/openstreetmap/openstreetmap-website/actions/workflows/tests.yml
### How to reproduce the issue?
Ehm...
1. Make sure the Coveralls API is in maintenance mode or something like that
2. Have a CI task try
hlfan left a comment (openstreetmap/openstreetmap-website#5668)
This planned outage was supposed to have ended about two hours from now:
https://status.coveralls.io
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5668#issuecommen
matkoniecz left a comment (openstreetmap/openstreetmap-website#5668)
CI failed as Coveralls (
https://github.com/openstreetmap/openstreetmap-website/actions/runs/13311873880/job/37176216996#step:15:183
) died with `Error: Method Not Allowed (405)`
--
Reply to this email directly or view it on
### Description
Moves all AJAX requests that don't need OAuth to fetch. (except Matomo as
this fetches a script)
### How has this been tested?
Logpoints and quite a bit of erratic map movement to check for aborts
You can view, comment on, or merge this pull request online at:
https://github.c
github-actions[bot] left a comment (openstreetmap/openstreetmap-website#5668)
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Gener