### Description
Adds a button into the directions search form:
| before | after |
|||
|
|
|
You c
@hlfan commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat=" + latlng
@hlfan pushed 1 commit.
cdacfafd11bd5265cc8d8b69468bca36010434ee Further usage of URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634/files/080062d7ce75309abbe6542ec948068a727d7d64..cdacfafd11bd5265cc8d8b69468bca36010434ee
You are receiving thi
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5632#pullrequestreview-2604130700
You are receiving this because you are subscribed to this thread.
Message ID:
__
@HolgerJeromin commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat="
@hlfan pushed 1 commit.
55d16a42172be67ee33e95bb85343b18b45754dd Skip jQuery
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5633/files/a3089c574efd1543cf0942e14791940ec5b8c1f0..55d16a42172be67ee33e95bb85343b18b45754dd
You are receiving this because you are sub
@hlfan pushed 3 commits.
572029358a82e5e7925b92f21413376324a4fdb5 Reduce condition complexity
559ac7a9c7be9e8a86aa702baa6d7445c8e775f5 Lessen code repetition
a3089c574efd1543cf0942e14791940ec5b8c1f0 Remove IE<10 workaround
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-w
Dropping
https://github.com/hlfan/openstreetmap-website/commit/7f3a036483f626684c5cb1d286f8050d0335dd91
as tests didn't like it
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634#issuecomment-2646073042
You are receiving this b
@hlfan commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat=" + latlng
@hlfan pushed 1 commit.
080062d7ce75309abbe6542ec948068a727d7d64 Further usage of URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634/files/2606a0a83134c954570a2c13c3de133ced69f772..080062d7ce75309abbe6542ec948068a727d7d64
You are receiving thi
@hlfan pushed 0 commits.
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5634/files/7f3a036483f626684c5cb1d286f8050d0335dd91..2606a0a83134c954570a2c13c3de133ced69f772
You are receiving this because you are subscribed to this thread.
Message ID:
__
@AntonKhorev pushed 2 commits.
835872afc9860daa422091c3969009cc43dc1071 Split api old element redacted index
tests
4706bfe9ce3164377b7284cfba1abe085e7b2687 Split api old element redacted show
tests
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/f
@AntonKhorev pushed 3 commits.
bbcc274b3072e4bba2d39336d6d8a9256d398d32 Move api way version test to
integration tests
8db24a640506415a32ad211aba48c51b15e70200 Test api old way show action without
integration
fb0c9ada6e496e8b09ff6e6baad099e25e377d07 Remove unused api old relation test
code
@AntonKhorev pushed 12 commits.
83a23c3ba79cbbaa6b0483ea108507dd2bfa9fa3 Declare api node ways as nested
resources
b8189ee645cea2e6db87ac7cd1986ca785439ccf Declare api node relations as nested
resources
5235aec9d68cf63b61a47910f99ac300f6c361af Declare api way relations as nested
resources
8e
@AntonKhorev commented on this pull request.
> +function update3dMapUrl() {
+ var el = document.getElementById("terrain_3d_url");
+
+ if (el) {
+var c = map.getCenter();
+var zoom = map.getZoom() - 1;
+var precision = Math.ceil(((zoom * Math.LN2) + Math.log(
Actually i18n files don't pass, they're excluded elsewhere:
https://github.com/openstreetmap/openstreetmap-website/blob/4027d0c30abb5c50ac61785a57a8699de000ddd7/lib/tasks/eslint.rake#L13
That was added in
https://github.com/openstreetmap/openstreetmap-website/commit/d67b0578511e585fabebeb4800cb1
Merged #5631 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5631#event-16236779489
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@HolgerJeromin commented on this pull request.
> @@ -61,13 +61,9 @@ OSM.Changeset = function (map) {
});
content.find("textarea").on("input", function (e) {
- var form = e.target.form;
-
- if ($(e.target).val() === "") {
-$(form.comment).prop("disabled", true);
-
@HolgerJeromin commented on this pull request.
> @@ -61,13 +61,9 @@ OSM.Changeset = function (map) {
});
content.find("textarea").on("input", function (e) {
- var form = e.target.form;
-
- if ($(e.target).val() === "") {
-$(form.comment).prop("disabled", true);
-
@HolgerJeromin commented on this pull request.
> @@ -124,7 +124,7 @@ OSM.DirectionsEndpoint = function Endpoint(map, input,
> iconUrl, dragCallback, ch
function getReverseGeocode() {
var latlng = endpoint.latlng.clone();
-var reverseGeocodeUrl = OSM.NOMINATIM_URL + "reverse?lat="
Another few steps in embracing URLSearchParams.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5634
-- Commit Summary --
* Further usage of URLSearchParams
* Build search params only after update
-- File Changes
Simplifying if-else structures and condensing repeated expressions.
At least the things I found with my regex search.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5633
-- Commit Summary --
* Reduce condition compl
Splitting parameter population and assignment, enabling a singular later
default zoom value definition.
A new take on what was dropped in #5597.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5632
-- Commit Summary --
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5631#pullrequestreview-2603997470
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5621 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621#event-16236180714
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev pushed 1 commit.
ac4f7c9c9d5fcb19697b4911ad8f1035620b61c8 Move api node version integration
tests to their own class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/ace11c8bf16284c73324e3b936bc6bfc2ac59895..ac4f7c9c9d5fcb19697b4911ad8f1
@AntonKhorev pushed 1 commit.
ace11c8bf16284c73324e3b936bc6bfc2ac59895 Move api node version integration
tests to their own class
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/0901d62419646d69292a91119dbafd6cbdf2be2a..ace11c8bf16284c73324e3b936bc6
@tomhughes pushed 2 commits.
619a4b9958eebe7eddfcc8f086eefcadd0e976a6 Update eslint to prefer let/const
over var
f6416cd4d41c9e4c5979da4a831af2850c29569f Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Merged #5611 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5611#event-16236180715
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5572 as completed via #5611.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5572#event-16236180742
You are receiving this because you are subscribed to this thread.
Message ID:
_
Looks good to me, and as a bonus it makes route segment highlighting for for
Valhalla! Thanks for the work.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621#issuecomment-2645868109
You are receiving this because you are subscr
@AntonKhorev pushed 1 commit.
0901d62419646d69292a91119dbafd6cbdf2be2a Make api old element show paths
resourceful
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/80df3d063ddcfe1ea0780c65acf8f6ebee660507..0901d62419646d69292a91119dbafd6cbdf2be2a
You
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5611#issuecomment-2645846186
You are receiving this because you are subscribed to this thread.
Message ID:
___
This was presumably required at some point but the i18n files seem to pass
eslint fine now and even if they didn't it would probably be better to
ignore them in the eslint config.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-web
Merged #5630 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5630#event-16236075393
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I think this looks fine from a code point of view - my only question is how we
use this without effectively turning this URL into API that is baked into
clients.
Is you plan that we include this URL in the error the API returns, with the
intention that clients will display that error to the use
That PR was marked as draft after it was ignored for months and I gave up on
maintaining it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5616#issuecomment-2645799527
You are receiving this because you are subscribed to this
@AntonKhorev pushed 7 commits.
6a50a5e871db2e35eeb20f5707e467fe1442583b Declare api node ways as nested
resources
a6e614e44e0735160c8d9ca9e3b43fd295e7e514 Declare api node relations as nested
resources
2a38dca0b780b972ff93b4cae1bc37c1d476dffa Declare api way relations as nested
resources
f69
@AntonKhorev pushed 6 commits.
6a50a5e871db2e35eeb20f5707e467fe1442583b Declare api node ways as nested
resources
a6e614e44e0735160c8d9ca9e3b43fd295e7e514 Declare api node relations as nested
resources
2a38dca0b780b972ff93b4cae1bc37c1d476dffa Declare api way relations as nested
resources
f69
Updated for resourceful routes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3715#issuecomment-2645775214
You are receiving this because you are subscribed to this thread.
Message ID:
__
@AntonKhorev pushed 5 commits.
4b68c038a7a7ef6d369ef3e08fb849b7453b451a Test required parameter message in
element multi fetch
62d1ec379efc25389138cec8922a31cf964c764d Add generic api elements controller
for multi fetches
b30545f10781a4e33665fd65f32ae7c552d65fe0 Add basic version support to e
@1ec5 commented on this pull request.
> @@ -9,6 +14,43 @@ L.extend(L.LatLngBounds.prototype, {
}
});
+if (OSM.MAPTILER_KEY) {
+ maplibregl.setRTLTextPlugin(
+
"https://api.mapbox.com/mapbox-gl-js/plugins/mapbox-gl-rtl-text/v0.2.3/mapbox-gl-rtl-text.js";,
To avoid this external depend
42 matches
Mail list logo
