@HolgerJeromin pushed 2 commits.
c855d86bf8ca9e1c240e6f0fa803deb3f69e5e6c Mark valid usecases for alert
eee793f5e6e534442793c88f06caca2ccb5c12d1 change eslint rule no-alert to error
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614/files/b189286288238fe5615
@nertc commented on this pull request.
> +if params[:format] == "json"
+ render :html => @results.pluck(:name).join(", ")
PR was updated. Instead of HTML now `format=json` returns JSON array. I thought
about plaintext, but I think, JSON object is much more versatile. Plus, it
contain
@hlfan pushed 1 commit.
3528239e2c938965303ab75262f9e45d0de5236c Refactor direction engines and unify
structure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621/files/a56c74c1cd5a4cafe3e61c3f7f68a7292f9ab889..3528239e2c938965303ab75262f9e45d0de5236c
You ar
@nertc pushed 1 commit.
47191675b5aaea734dff6afa0cac4c961963c264 Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/cce58d16a4c4a48b06bd1b4d3b5eca5182865f3f..47191675b5aaea734dff6afa0cac4c961963c264
You are receiving this because yo
@nertc pushed 1 commit.
cce58d16a4c4a48b06bd1b4d3b5eca5182865f3f Add profile location
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/ea0667a47a41ed957f10dcf10b5aa8d9f46e15fd..cce58d16a4c4a48b06bd1b4d3b5eca5182865f3f
You are receiving this because yo
Please assign me this issue i would like to work on it
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5616#issuecomment-2638886316
You are receiving this because you are subscribed to this thread.
Message ID:
> > So my proposal is to rename the tables to match the model names.
>
> Have you also evaluated the other way around, i.e. change the model names to
> match the db table names? Assuming that's feasible, that's significantly less
> risk and effort for anything non-Rails (planetdump-ng, osmdbt, c
@kcne pushed 2 commits.
840decddc6af04be60ff5ef398f9fffd113b407e Add heatmap data caching and query
for user contributions
38f909333e62e46665f0e0bb123573b79023bc87 Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
@kcne commented on this pull request.
> @@ -3300,6 +3300,10 @@ en:
show_address: Show address
query_features: Query features
centre_map: Centre map here
+heatmap:
+ tooltip:
+contributions: "%{count} contributions on %{date}"
Updated keys and js code respec
@kcne pushed 2 commits.
7a2fd38e7a2b86aaa1cfb13f91972b8480b1d2c9 Add javascript logic, styles and
heatmap in view
a068ef7ad03658871fbd1723e20449126f76f32d Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402/file
@zdila pushed 1 commit.
fd2e5620f7fa151baa72d8364ad2df294bdc12e3 update language switching
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/79ac1ff323e2122c779486668ac63fdb85247b27..fd2e5620f7fa151baa72d8364ad2df294bdc12e3
You are receiving this becau
@tomhughes commented on this pull request.
> -
-if (mapParams.object) {
- params.set("id", mapParams.object.type + "/" + mapParams.object.id);
- mapParams = OSM.parseHash(location.hash);
- if (mapParams.center) {
-params.set("map", mapParams.zoom + "/" + mapParams.cent
@hlfan pushed 1 commit.
a56c74c1cd5a4cafe3e61c3f7f68a7292f9ab889 Refactor direction engines and unify
structure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5621/files/0f20bf9ffb02cd92507b541e4bd34c8bf1ff694f..a56c74c1cd5a4cafe3e61c3f7f68a7292f9ab889
You ar
@tomhughes pushed 2 commits.
bb4cf067d7a12bb8a07564ae4aec345efbaa4393 Update eslint to prefer let/const
over var
9be16a11a0696d677e1d3e15d3eed6e6d30e9020 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Oh, yes. Will fix the pr tomorrow
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614#issuecomment-2637828616
You are receiving this because you are subscribed to this thread.
Message ID:
@tomhughes approved this pull request.
This looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5597#pullrequestreview-2596749889
You are receiving this because you are subscribed to this thread.
Messa
Closed #5599 as completed via #5603.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5599#event-16199645525
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5603 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5603#event-16199645306
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@HolgerJeromin commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5603#issuecomment-2637816071
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5620 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5620#event-16199480335
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5597 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5597#event-16199594499
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@HolgerJeromin commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
@mmd-osm pushed 1 commit.
f6f75d6e844f04fcea3b27e604428eb0a883e9b6 Add copyright/attribution message to
downloaded map images
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5607/files/68a1ce22dcac71dd1500c190eee34339a83698d4..f6f75d6e844f04fcea3b27e604428eb0a
@tomhughes commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
+
> So my proposal is to rename the tables to match the model names.
Have you also evaluated the other way around, i.e. change the model names to
match the db table names? Assuming that's feasible, that's significantly less
risk and effort for anything non-Rails.
--
Reply to this email directl
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5620#issuecomment-2637779527
You are receiving this because you are subscribed to this thread.
Message ID:
___
@hlfan pushed 1 commit.
1e57668c7ec25382bd50e135cb44d06ecd03f0ae Simplify initialisation of iD
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5597/files/242951579e20b8626cef12f644c1967f0f955048..1e57668c7ec25382bd50e135cb44d06ecd03f0ae
You are receiving this b
Merged #5604 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604#event-16199346935
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604#issuecomment-2637754685
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #5610 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5610#event-16199196644
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
Merged #5612 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5612#event-16199110718
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Untangling `FOSSGISOSRMEngine` and moving from `push`ing `for` loops to
`.map()` for the other engines.
### Description
The three routing engines' code now follows a similar structure:
```js
const ...Engine = function (id, ...) {
function _processDirections(...) {...}
return {
...,
g
@tomhughes requested changes on this pull request.
Looks like you missed one?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5614#pullrequestreview-2596651448
You are receiving this because you are subscribed to this thread.
M
> You don't need to touch every single line via indenting if you write the
> globals as
> const DemoEngine = function (...) { ... };
Then we would have `DemoEngine` poluting the global scope...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
Closed #5554 as completed via #5612.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5554#event-16199110953
You are receiving this because you are subscribed to this thread.
Message ID:
_
@tomhughes commented on this pull request.
> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
- const width = Math.max(100, Math.min(screen.width, initialWidth));
- const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
+
So as https://eslint.org/docs/latest/rules/no-process-env explains there is a
replacement (in a plugin) for `no-process-env` but as it's a Node.js specific
rule it doesn't really concern us anyway and as `process.env` doesn't exist in
our setup it will alert in other ways as @HolgerJeromin says.
As far as I can tell that initialiser isn't really needed - removing it
produces no new errors or warnings so whatever the problem was with those
generated files no longer appears to be an issue.
Even if it was we could use a global ignore rule in the eslint config file
instead to tell eslint t
Actually what I think what the user would expect in this case, would be to see
a map with an orange line indicating how version 1 looked. I guess that's
probably kind of difficult because the background map would not match up with
the orange line in that case.
So maybe like you said perhaps r
`full` is not a standard action name, but it's also not really a nested
resource. Here I'm mapping them to `show` action with a parameter. A
similar thing is done with changeset discussions where the discussion/comment
elements are extra things added to the usual `show` output if a parameter is
Merged #5615 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5615#event-16198841794
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5615#issuecomment-2637668980
You are receiving this because you are subscribed to this thread.
Message ID:
___
Closed #5601 as completed via 3dda236509445e3e9f37dc4fd718dc0ff68de00c.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5601#event-16198841713
You are receiving this because you are subscribed to this thread.
Message ID:
__
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5605#issuecomment-2637651666
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5605 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5605#event-16198736456
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5602 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5602#event-16198708270
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Nice, flattered that you use my plugin now at openstreetmap ;) If anything is
not working, just [open an
issue](https://github.com/Splines/eslint-plugin-erb). And feel free to leave a
GitHub star should you like it 😊
--
Reply to this email directly or view it on GitHub:
https://github.com/open
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5602#issuecomment-2637645564
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5617#issuecomment-2637626916
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5617 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5617#event-16198604586
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
For historical reasons, we've ended up with quite a few database tables names
that aren't aligned with the model names. I think in every case we prefer the
model names (since these are easier to change, they tend to have been changed
already without renaming the underlying table).
```bash
andy@
"Details" there is a link to the current version. Maybe renaming it would work
but there has to be a distinction between *the current version at this moment
that's not going to change* and *the current version at any moment that may
change*.
--
Reply to this email directly or view it on GitHub
Visit https://www.openstreetmap.org/way/576529969
Okay now on the bottom select version 1.
Okay now select view details.
Hey we're looking at the details of version 2. I thought you were going to give
us the details of version 1!
--
Reply to this email directly or view it on GitHub:
https:/
Follows #5591.
Renames `delete` actions to standard `destroy`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5617
-- Commit Summary --
* Make api show/update/destroy node actions resourceful
* Make api show/upda
We have an amount of html building being created using JavaScript code. For
example, in `leaflet.share.js` there is a substantial amount of html
construction:
https://github.com/openstreetmap/openstreetmap-website/blob/7cf9bf0e553a141acab2afea53842f97eddd0a40/app/assets/javascripts/leaflet.share
@AntonKhorev pushed 18 commits.
3b0be171b9193c9939252f3e60a685dd1aa0af13 Make api show/update/destroy node
actions resourceful
35fc840b41d1257fe3560af777c291a2852ac749 Make api show/update/destroy way
actions resourceful
18f65b78ebe02d96861991880056c7abb07c299e Make api show/update/destroy re
See #5601 for discussion
---
Closes #5601
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5615
-- Commit Summary --
* Image lazy loading
-- File Changes --
M config/initializers/sanitize.rb (6)
-- Patch Li
Closed # as not planned.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/#event-16198172170
You are receiving this because you are subscribed to this thread.
Message ID:
___
r
Hi @maro-21 it would be great if you can answer the questions from the other
developers about your browser version. In the meantime, I'm going to close this
issue, since without this information there's nothing else that we can do.
--
Reply to this email directly or view it on GitHub:
https://g
Looks good to me. Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5591#issuecomment-2637541807
You are receiving this because you are subscribed to this thread.
Message ID:
@hlfan commented on this pull request.
You don't need to touch every single line if you write the globals as
```js
const DemoEngine = function (id, costing) {
...
};
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613#pul
Merged #5591 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5591#event-16198140376
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5608 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5608#event-16197998455
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Mark valid usecases for alert
I think with marking this valid use cases it is ok to change eslint rule to
error.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5614
-- Commit Summary --
* Mark valid usecases for a
Closed #5523 as completed via #5559.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5523#event-16198066112
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5559 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#event-16198065820
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks for your work on this!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#issuecomment-2637527599
You are receiving this because you are subscribed to this thread.
Message ID:
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5608#issuecomment-2637514491
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
### Description
I also changed the eslint rule to an error in a separate commit.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5613
-- Commit Summary --
* Fix all no-implicit-globals eslint errors
* Change eslin
@AntonKhorev commented on this pull request.
> @@ -3300,6 +3300,10 @@ en:
show_address: Show address
query_features: Query features
centre_map: Centre map here
+heatmap:
+ tooltip:
+contributions: "%{count} contributions on %{date}"
You need `one` and `othe
> Can we have a decision here?
I think my only concern with the .vscode/settings.json approach is that it
ignores our "ExcludeI18n" configuration from
[config/initializaers/eslint.rb](https://github.com/openstreetmap/openstreetmap-website/blob/d62caf5fe21911a8c07c9831170cbb1f74936d24/config/init
@hlfan commented on this pull request.
> "eslint": "^9.0.0",
+"eslint-plugin-erb": "^2.1.0",
"@stylistic/eslint-plugin-js": "^3.0.0",
"eslint-formatter-compact": "^8.40.0"
Sure, let's add another linter. But can we take it one step at a time? I'm
getting tired of rebasing al
Merged #5606 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5606#event-16197699550
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5606#issuecomment-2637455267
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
@gravitystorm commented on this pull request.
> "eslint": "^9.0.0",
+"eslint-plugin-erb": "^2.1.0",
"@stylistic/eslint-plugin-js": "^3.0.0",
"eslint-formatter-compact": "^8.40.0"
> How should we sort the plugins?
Either a linter picks up on this, or it doesn't really matter.
Replace deprected eslint rules
no-new-object => no-object-constructor
https://eslint.org/docs/latest/rules/no-new-object
no-process-env => will be catched by no-undef
closes #5554
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-we
@AntonKhorev pushed 1 commit.
90bdc1cb1f55843aa81b5ccdabbab801ef5c11cc Convert api element history actions
to versions resources
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5590/files/d003a2ccc3d81ee9e22a3bc89aee21599b2d2a3f..90bdc1cb1f55843aa81b5ccdabbab8
@hlfan commented on this pull request.
> "eslint": "^9.0.0",
+"eslint-plugin-erb": "^2.1.0",
"@stylistic/eslint-plugin-js": "^3.0.0",
"eslint-formatter-compact": "^8.40.0"
How should we sort the plugins? (also @HolgerJeromin)
If we go semantically alphabetic,
* eslint,
* esl
@AntonKhorev pushed 23 commits.
805fe9a57779fa1da095d65a4788e56ab0ce4670 Make api element index paths
resourceful
b551fb288d118c36eb9ca7b9f732227ebd8bef69 Move api element index tests up
1710bfb10d8e3b838a04ad2a9570a619049ccbd0 Make api create node path resourceful
b05a2c6fa164dc2f41e4b9e92173
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5606#pullrequestreview-2596312241
You are receiving this because you are subscribed to this thread.
Message ID:
__
### Description
Add vscode style settings file which defines the location of eslint config file.
### How has this been tested?
Load folder in editor and break eslint rule => direct visual feedback
fixes #5572
You can view, comment on, or merge this pull request online at:
https://github.com/o
@hlfan pushed 1 commit.
bc18e85d5c9ded603937b0a2dc92d08973f81a80 Add eslint-plugin-erb for .js.erb
file linting
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/7b421fa18b94df1d26fb6787d161126f3e34398f..bc18e85d5c9ded603937b0a2dc92d08973f81a80
You ar
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2637323369
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5557 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#event-16196962558
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@HolgerJeromin pushed 1 commit.
e838e9528c35de02c88e7089d4294a912997d5fa Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/2aefd97281ac74c78a8dec469d45a22cb8288c93..e838e9528c35de02c88e7089d4294a912997d
> after clicking "edit", iD editor opens without notes visible
FYI: With v2.31 (#5610), iD will load the notes layer if it was previously
enabled on the osm.org map (also when no individual note is selected).
Disabling the notes layer in the editor will however not disable it for the osm
map.
@AntonKhorev commented on this pull request.
> @@ -52,10 +52,10 @@
<% end %>
- <% if @note_comments.length > 1 %>
+ <% if @note_comments.length > (!@note.author.nil? && @note.author.status ==
"deleted" ? 0 : 1) %>
I think it's better to make `@note_comments` contain true comments
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
## changes to the osm-website code:
This version of iD introduces a new hash parameter to enable to _notes_ layer
on startup. For a seamless integration into the website, I have added a check
if the notes layer is currently active, and pass it forward to the iD iframe.
The implementation is cur
Looks like cgimap only checks visibility when selecting nodes in bbox. It's
easier not to check it after that because you can get ids from connector tables
(`current_way_nodes` etc) that don't store visibility.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
On a [website from me](https://www.gwc-gt.de/Turnierergebnisse.php) I added
this HTML property to all user added images (inline images in a blog like page).
Invisible images (down a few pages) are not loaded till the user scrolls down.
The browser is smart enough to fetch them early enough, so ev
Closed #5485.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5485#event-16192856413
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Closed in favor of PRs #5568, #5579 and PR #5609.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5485#issuecomment-2636414294
You are receiving this because you are subscribed to this thread.
Message ID:
### Description
PR fixes bug where a note of deleted user has no comments, but the code tries
to access the first comment by switching to using `.all_comments` (instead of
`.comments`) and removing dropping first comment (if author is deleted) when
displaying notes comments in sidebar.
Suggest
@AntonKhorev approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557#pullrequestreview-2595317195
You are receiving this because you are subscribed to this thread.
Message ID:
Says who the issue is going to be reassigned to. You can have both admin and
mod roles, in this case it's not obvious what the new role is. Also
it's not obvious if you don't know that issues are assigned to roles
and not to users.
 is in favor of this, too?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5572#
1 - 100 of 102 matches
Mail list logo
