@HolgerJeromin commented on this pull request.
> @@ -10,6 +10,7 @@
},
"devDependencies": {
"eslint": "^9.0.0",
+"@stylistic/eslint-plugin": "^3.0.0",
I have no idea how my old experiments with that did not worked. But now it does
without ts dependency.
--
Reply to this email
@HolgerJeromin pushed 1 commit.
2aefd97281ac74c78a8dec469d45a22cb8288c93 Move deprecated eslint rules to
stylistic plugin
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/0d6ac49a4880903c709091f0242bab0744b49a36..2aefd97281ac74c78a8dec469d45a22cb8288
@kcne commented on this pull request.
> +
+
+
Refactored the code to use flexbox instead. It is indeed much simpler, as I
could get rid of some custom css classes. Thanks once again.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
@kcne pushed 2 commits.
9fc9ed65c63ad95897af6665fe9275ccb8976a4f Add javascript logic, styles and
heatmap in view
341fe1378fe6d3ebf260e1715329affb1aa1fa5f Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402/file
@kcne pushed 2 commits.
3fc5a320930d24208aabeaf0acfb5af4802c8cdd Add javascript logic, styles and
heatmap in view
ec5f4a5edc56db8a1a2bb14244cffdac85661466 Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402/file
@kcne commented on this pull request.
> +# Test user with no changesets
+user_without_changesets = create(:user)
+get user_path(user_without_changesets)
+assert_response :success
+assert_select "div#cal-heatmap", 1
Updated the test to reflect latest changes. Thank you.
--
This PR adds the UI facing parts for
https://github.com/openstreetmap/chef/pull/735 and adds WebP as as additional
output format, as well as a checkbox to toggle copyright/attribution in the map
export.
*
@hlfan requested changes on this pull request.
> @@ -42,7 +42,7 @@
code: "T"
layerId: "transportmap"
nameId: "transport_map"
- apiKeyId: "THUNDERFOREST_KEY"
+ apiKeyId: "thunderforest_key"
Now that this is used in embed.js.erb as well, that file would need to be
accommodated too.
-
@AntonKhorev commented on this pull request.
> +
+
+
+
+
+ <%= t("date.abbr_day_names")[1] %>
+
+ <%= t("date.abbr_day_names")[3] %>
+
+ <%= t("date.abbr_day_names")[5] %>
+
+
+
+
@AntonKhorev commented on this pull request.
> +# Test user with no changesets
+user_without_changesets = create(:user)
+get user_path(user_without_changesets)
+assert_response :success
+assert_select "div#cal-heatmap", 1
This fails because `@heatmap_data.present?` is false
@hlfan pushed 1 commit.
7b421fa18b94df1d26fb6787d161126f3e34398f Add eslint-plugin-erb for .js.erb
file linting
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/266988ed2b118932f0bba6c8b3fd880eaa2b9821..7b421fa18b94df1d26fb6787d161126f3e34398f
You ar
@kcne pushed 2 commits.
fbe7865e0255c06d8e5760faa945c464009007c8 Add heatmap container to user profile
view
ccaeee9113382d874dd015d9f5106f9296f38b39 Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402/files/e1bc
Now that's an edge case too sophisticated for the plugin as it is
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#issuecomment-2634593257
You are receiving this because you are subscribed to this thread.
Message ID:
@hlfan pushed 1 commit.
266988ed2b118932f0bba6c8b3fd880eaa2b9821 Move JS settings passthrough to Ruby
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559/files/a8f1c586bd2e552aa48165779628dfae350aa5c8..266988ed2b118932f0bba6c8b3fd880eaa2b9821
You are receiving
@AntonKhorev commented on this pull request.
> @@ -10,6 +10,7 @@
},
"devDependencies": {
"eslint": "^9.0.0",
+"@stylistic/eslint-plugin": "^3.0.0",
This includes typescript. Javascript-only version is
`@stylistic/eslint-plugin-js`.
--
Reply to this email directly or view it on
Not in use since #5592
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5606
-- Commit Summary --
* Remove Qs from eslint globals
-- File Changes --
M config/eslint.js (1)
-- Patch Links --
https://github.com/
@hlfan commented on this pull request.
> + MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>,
+ SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>,
+ SERVER_URL: <%= Settings.server_url.to_json %>,
+ API_VERSION: <%= Settings.api_version.to_json %>,
+ STATUS: <%= Settings.sta
@hlfan commented on this pull request.
> +layers
+ .filter(other => other !== layer)
+ .forEach(map.removeLayer);
Always in the places where you least expect it...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
@AntonKhorev commented on this pull request.
> + MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>,
+ SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>,
+ SERVER_URL: <%= Settings.server_url.to_json %>,
+ API_VERSION: <%= Settings.api_version.to_json %>,
+ STATUS: <%= Settin
@hlfan pushed 1 commit.
550e5d336f87d5b3c2eb3c4d9458b5162c1b7ed0 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/88257c2fc5d3b973a4563f4c849454c0feaadcf0..550e5d336f87d5b3c2eb3c4d9458b5162c1b7ed0
You are receiving this be
Closed #4402.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4402#event-16181383875
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@AntonKhorev commented on this pull request.
> +layers
+ .filter(other => other !== layer)
+ .forEach(map.removeLayer);
Have you tried running it?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604#p
The description is already html-safe after to_html.
This is a leftover from
https://github.com/openstreetmap/openstreetmap-website/commit/01aa27031526280d8b1d219902a7b4c97617d19f,
we don't explicitly escape other text->richtext->html like note
comments.
You can view, comment on, or merge this p
@hlfan pushed 1 commit.
242951579e20b8626cef12f644c1967f0f955048 Simplify initialisation of iD
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5597/files/d125835e82be1db5be1183f36da35cc4e3f4b781..242951579e20b8626cef12f644c1967f0f955048
You are receiving this b
Merged, thanks.
Next we probably want to fix the bug where a note of deleted user has no
comments because they are filtered out, but the code tries to access the first
comment:
- changing `comments` to `all_comments` in
https://github.com/openstreetmap/openstreetmap-website/pull/5511/commits/6
Still has "fix lint issues".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-2634199830
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5579 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5579#event-16179950845
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@hlfan pushed 1 commit.
88257c2fc5d3b973a4563f4c849454c0feaadcf0 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/dd9c62401c920a49f670337302e4fc03afbb8320..88257c2fc5d3b973a4563f4c849454c0feaadcf0
You are receiving this be
@hlfan pushed 1 commit.
dd9c62401c920a49f670337302e4fc03afbb8320 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/be17c48b089849f2efbbd68f6f7578bba3728873..dd9c62401c920a49f670337302e4fc03afbb8320
You are receiving this be
@hlfan pushed 6 commits.
ae5df1f71982e573cb4fda68f7e4c43ea6bb5ede Add early return
4830a42684d2f33aa76a244d42e2fdf9445f35c3 Condense key passthrough
8485d2aae7e0e940888ad71de7ddc0b751c45cef Remove mapParams redefinition
1cb0ebb96781da634dd37bcb1d49a893c4f600ed Merge gpx parameter passthrough
3
@hlfan pushed 1 commit.
be17c48b089849f2efbbd68f6f7578bba3728873 Reevaluate iteration methods
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5604/files/98f7005f37f1c92873fab1f081f10799e4b61e5a..be17c48b089849f2efbbd68f6f7578bba3728873
You are receiving this be
Converts more loops to for..of loops due to increased readability and change
.forEach() in combination with .push() to .map().
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5604
-- Commit Summary --
* Reevaluate i
PR was updated. Branch was synced with master and conflicts were resolved.
Also, instead of handling canceling layer loading in the `setTimeout` callback,
now it is handled by clearing `setTimeouts`.
Optimizations for layer rendering were done in
https://github.com/openstreetmap/leaflet-osm/pul
@zdila pushed 1 commit.
c51167d0cffdb90052cc1022b26aa73431f237a3 rename OpenMapTiles to MapTiler OMT
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042/files/e683509902b76c58766075a95b6011b922a75169..c51167d0cffdb90052cc1022b26aa73431f237a3
You are receiving
@zdila pushed 7 commits.
344957986a01502ef11dc7fbb0221d66ab5f28bb Add OpenMapTiles OSM vector map
878480d1926a01e22932e1ca95d0a6b198235aeb remove 3D map link from OMT
attribution
a56675f51f104d470dd57c490a891145f0c2bc82 add MAPTILER_KEY configuration
1da1c68dbbad7af8665285c3953017e0110c6318 O
@AntonKhorev pushed 1 commit.
53620c62d33eea4d7abb99ed70b4d6365f99d8c2 Test if closing sidebar removes
directions popup
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5603/files/46535d65b8548f2b22c498fe48dcd563647005b0..53620c62d33eea4d7abb99ed70b4d6365f99d8c
@nertc pushed 1 commit.
fca12a2c06dd0ddcf2b9a937e0eeb36d97a20747 Map Data asynchronous checkbox
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/af830a16cb6e09c4d1d25ec96b9c2a6d315975d6..fca12a2c06dd0ddcf2b9a937e0eeb36d97a20747
You are receiving this
@nenad-vujicic approved this pull request.
It works great on my side!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5603#pullrequestreview-2592495071
You are receiving this because you are subscribed to this thread.
Message I
I didn't fix it myself because I was looking for my routing engine test stub
code. Added it here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5603#issuecomment-2633584793
You are receiving this because you are subscribed to th
@AntonKhorev pushed 1 commit.
46535d65b8548f2b22c498fe48dcd563647005b0 Test if closing sidebar removes
directions popup
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5603/files/628f6149d1c76ac09ebf8dea8d71f86eb9a91dc9..46535d65b8548f2b22c498fe48dcd563647005b
@kcne commented on this pull request.
> @@ -237,11 +237,29 @@
<%= @user.description.to_html
%>
-<% if @heatmap_data.present? %>
-
-<%= tag.div(:id => "cal-heatmap", :data => { :heatmap =>
@heatmap_data.to_json }) %>
+
Removed that div entirely, thank you. I thought it would help m
@kcne commented on this pull request.
> +<% if @heatmap_data.present? %>
+
+<%= tag.div(:id => "cal-heatmap", :data => { :heatmap =>
@heatmap_data.to_json }) %>
+
+<% end %>
When we decide the conditions for renedering we can refactor the if statement
as necessary. Thank you.
--
Rep
@kcne commented on this pull request.
> +<% if @heatmap_data.present? %>
+
+<%= tag.div(:id => "cal-heatmap", :data => { :heatmap =>
@heatmap_data.to_json }) %>
+
+<% end %>
Okay, kept the if statement as it is now and also removed styling mentioned and
`console.warn` statment from th
@kcne commented on this pull request.
> + <%= stylesheet_link_tag "heatmap" %>
+ <%= javascript_include_tag "heatmap" %>
Removed from this commit and added later when the files are added. Thank you.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/opens
@kcne pushed 2 commits.
2c62802c3d056edb43f3e20e3e8a5d7d3c8fad05 Add heatmap container to user profile
view
e1bc1b99783548e8382e29fd8d7fb5ea61a83fb6 Add tests for heatmap data in
UsersController
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402/files/7680
@nertc pushed 1 commit.
af830a16cb6e09c4d1d25ec96b9c2a6d315975d6 Map Data asynchronous checkbox
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files/4b91e799bfed30f71dac5d10723dec016a34c26b..af830a16cb6e09c4d1d25ec96b9c2a6d315975d6
You are receiving this
@HolgerJeromin commented on this pull request.
> -
-if (mapParams.object) {
- params.set("id", mapParams.object.type + "/" + mapParams.object.id);
- mapParams = OSM.parseHash(location.hash);
- if (mapParams.center) {
-params.set("map", mapParams.zoom + "/" + mapParams.
47 matches
Mail list logo
