Just a note that if this is merged we'll need to do `en_AU` as currently most
of the `en` ones work okay for Australian English, but that won't be the case
if this is merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5029#i
@tomhughes commented on this pull request.
> @@ -39,7 +37,7 @@ OSM.initializeContextMenu = function (map) {
callback: function describeLocation(e) {
const [lat, lon] = OSM.cropLocation(e.latlng,
map.getZoom()).map(encodeURIComponent);
Maybe, but it's not something new in this pull
@tomhughes commented on this pull request.
> + function stringifyArgs(args) {
+return new URLSearchParams(args).toString();
+ }
+
Thanks for point that out - hopefully I've fixed all those now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openst
@tomhughes pushed 1 commit.
46cd3a1114d975a1791c16e5930c9ed7f8367d36 Replace qs with URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5592/files/05c1f539d355f9339b3d8286e34ab3060a2b4939..46cd3a1114d975a1791c16e5930c9ed7f8367d36
You are receiving
Reporter users isn't really grammatically correct so change it to reporting
users instead.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5594
-- Commit Summary --
* Change "reporter users" to "reporting users"
--
@AntonKhorev commented on this pull request.
> + function stringifyArgs(args) {
+return new URLSearchParams(args).toString();
+ }
+
Is this function required? You can replace
```js
OSM.router.route("/directions?" + stringifyArgs({
...
```
with
```js
OSM.router.route("/directions?" + new
@AntonKhorev commented on this pull request.
> @@ -39,7 +37,7 @@ OSM.initializeContextMenu = function (map) {
callback: function describeLocation(e) {
const [lat, lon] = OSM.cropLocation(e.latlng,
map.getZoom()).map(encodeURIComponent);
`encodeURIComponent` here probably doesn't do
If I'm making purely ui tests here I can't possibly know id of new
notes, therefore I shouldn't check them.
But the actual reason is that it looks like `assert_content "Unresolved
note ##{Note.last.id}"` line is sometimes reached before db writes are
complete. `Note.last.id` is not going to hav
Updated for let/const.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4926#issuecomment-2629440393
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
@AntonKhorev pushed 4 commits.
dbf079fb06f4cc4cd77474e5068e2144db41cdd1 Add empty account home page
0a90ca8bb1b14717fa7a4824a9f22892226631bf Show/hide marker in account home js
controller
4a65746e6fec5a2e06ae8feaf31f67c2d2a1d2dc Add "Go to Home Location" to every
page, link it to account home
Closed #2982 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2982#event-16152930134
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
Fixed in #5064.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2982#issuecomment-2629430186
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
@tomhughes pushed 1 commit.
05c1f539d355f9339b3d8286e34ab3060a2b4939 Replace qs with URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5592/files/f288601f5cdc95a78449fb47a83b98b58a5490ee..05c1f539d355f9339b3d8286e34ab3060a2b4939
You are receiving
@HolgerJeromin commented on this pull request.
> @@ -45,34 +44,34 @@
*/
window.updateLinks = function (loc, zoom, layers, object) {
$(".geolink").each(function (index, link) {
-var href = link.href.split(/[?#]/)[0],
-args = Qs.parse(link.search.substring(1)),
-editlink
Reopened #5559.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#event-16152840970
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
Closed #5559.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5559#event-16152838966
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@tomhughes pushed 1 commit.
4c75a5b501524b9e6c5315a3ebf2fef32c998757 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558/files/7f69d4b0b1af12d9f34941d64964940b32ad5305..4c75a5b501524b9e6c5315a3ebf2fef32c998
@tomhughes pushed 2 commits.
9ecd73ed4bae2159990a647ba755e966adbf6519 Update eslint to prefer let/const
over var
7f69d4b0b1af12d9f34941d64964940b32ad5305 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
@tomhughes commented on this pull request.
> @@ -45,34 +44,34 @@
*/
window.updateLinks = function (loc, zoom, layers, object) {
$(".geolink").each(function (index, link) {
-var href = link.href.split(/[?#]/)[0],
-args = Qs.parse(link.search.substring(1)),
-editlink = $(
@tomhughes pushed 1 commit.
f288601f5cdc95a78449fb47a83b98b58a5490ee Replace qs with URLSearchParams
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5592/files/bb10fa87983704f3277e86eeb208537ece963544..f288601f5cdc95a78449fb47a83b98b58a5490ee
You are receiving
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2588542628
You are receiving this because you are subscribed to this thread.
Message ID:
__
Closed #1754 via #5064.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1754#event-16152660342
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
Closed #1874 as completed via #5064.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1874#event-16152660317
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5064 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5064#event-16152660304
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
I've had another look through this, and played with a bit in my dev environment
and I think it's probably good to merge now. Thanks for all the work on it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetm
Closed #1911 as completed via #5064.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1911#event-16152660323
You are receiving this because you are subscribed to this thread.
Message ID:
_
@HolgerJeromin commented on this pull request.
> @@ -45,34 +44,34 @@
*/
window.updateLinks = function (loc, zoom, layers, object) {
$(".geolink").each(function (index, link) {
-var href = link.href.split(/[?#]/)[0],
-args = Qs.parse(link.search.substring(1)),
-editlink
Part of #5590.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5591
-- Commit Summary --
* Make api element index paths resourceful
* Move api element index tests up
* Make api create node path resourceful
* Ma
As javascript now has a builtin way to parse URL search parameters we don't
really need the qs module any more, so replace it with the builtin support.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5592
-- Commit Sum
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5590
-- Commit Summary --
* Make api element index paths resourceful
* Move api element index tests up
* Make api create node path resourceful
* Make api create
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
Merged #5522 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5522#event-16152478484
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
This looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5522#pullrequestreview-2588526971
You are receiving this because you are subscribed to this thread.
Messa
@tomhughes pushed 2 commits.
d9b81a8e4db1d3006627878985df4a047d9b17df Update eslint to prefer let/const
over var
f3e092f7827574d4678d85a761ff87c9c6ec6c7c Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
@tomhughes pushed 5 commits.
05fa660570f41bf79a0e63a45ba77141d62b8647 Drop support for ruby 3.1
59c54b648232b43d52b865cb2079dad106194d94 Update to rails 8.0.1
c2df4e06ba5d4a6ba63a77aed1171776120e5b81 Avoid parsing of XML requests with ;
in the body
f29421149aa7550ff5646ba87a77804dfe5240a9 Use
@tomhughes pushed 1 commit.
b4c0c62b403e6ed400f79f4d9d5f666ab620a28f Filter out invisible nodes and ways
during initial selection
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5589/files/7f13a24164c0177f0772090775680cb4bc703200..b4c0c62b403e6ed400f79f4d9d5f6
Merged #5588 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5588#event-16152401666
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5587 as completed via #5588.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587#event-16152401714
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5586 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5586#event-16152401661
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks,
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5588#issuecomment-2629336710
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5586#issuecomment-2629335951
You are receiving this because you are subscribed to this thread.
Message ID:
___
This takes #5585 a bit further and drops the separate visibility filtering in
favour of ensuring that we always filter for that as part of the initial
database query.
Technically this creates a slight change in behaviour in that previous nodes
which were visible but outside the bounding box wou
Merged #5581 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581#event-16152376894
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5585 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5585#event-16152376896
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5585#issuecomment-2629331355
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes approved this pull request.
Thanks for the changes - this looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581#pullrequestreview-2588515381
You are receiving this because you are subscribed to this thr
@tomhughes commented on this pull request.
> @@ -211,11 +207,16 @@ OSM = {
return Math.ceil(Math.log10(pixels / degrees));
},
+ cropLocation: function (latLng, zoom = map.getZoom()) {
It might help to read
https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History but in this case a
47 matches
Mail list logo
