@hlfan pushed 1 commit.
8cf4646b061b74de92185fdb26329421f73cb01c Add layer-type switching to use dark
tiles
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5522/files/f15e6bb568d6028062a0d813e29c8de5d6f3fd0b..8cf4646b061b74de92185fdb26329421f73cb01c
You are re
@hlfan commented on this pull request.
> @@ -211,11 +207,16 @@ OSM = {
return Math.ceil(Math.log10(pixels / degrees));
},
+ cropLocation: function (latLng, zoom = map.getZoom()) {
I'm still trying to work out the problem in #5571, but force-pushing from
another branch helped.
--
R
@hlfan pushed 1 commit.
f15e6bb568d6028062a0d813e29c8de5d6f3fd0b Add layer-type switching to use dark
tiles
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5522/files/625bdaf2520da8cfa6906adc706feab63a19e2fc..f15e6bb568d6028062a0d813e29c8de5d6f3fd0b
You are re
Reopened #5522.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5522#event-16151563376
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
@hlfan pushed 1 commit.
4b6b49801c63424b08c582d349511a6b1e05354f Add coordinate precision function
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581/files/0e8d8a62da7760acca632e5d9870df3db79ec4b5..4b6b49801c63424b08c582d349511a6b1e05354f
You are receiving th
Fixes #5587.
I think it's safer to always use `URI.encode_uri_component` instead of
`URI.encode_www_form_component`. Space is going to be encoded as `%20`. Space
as `+` sometimes doesn't work.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/ope
Yes, I was about to post the same link.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587#issuecomment-2629048488
You are receiving this because you are subscribed to this thread.
Message ID:
__
I forgot to mention, I was seeing this behavior in Thunderbird...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587#issuecomment-2629045582
You are receiving this because you are subscribed to this thread.
Message ID:
__
But looks like spaces should be %-encoded:
https://datatracker.ietf.org/doc/html/rfc6068#section-5
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587#issuecomment-2629048115
You are receiving this because you are subscribed to
GMail doesn't show `+`s.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587#issuecomment-2629045114
You are receiving this because you are subscribed to this thread.
Message ID:
___
### URL
_No response_
### How to reproduce the issue?
1. Pick random diary entry with spaces in title, e.g.
https://www.openstreetmap.org/user/watmildon/diary/406063
2. Click on "Share via Email" button
3. Note that the title in your email client reads as
"`OSM+US+Board+Candidate+Statement+202
...instead of calling `flatten!` on the result
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5586
-- Commit Summary --
* Use flat_map to collect way node ids in maps controller
-- File Changes --
M app/contro
Merged #5584 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5584#event-16150636292
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Another instance of `visible_nodes` like in #5584, but this time it's being
read. However it's largely useless because nodes are already collected into
`@nodes`. Same for `way_ids`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-w
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5584#issuecomment-2629036870
You are receiving this because you are subscribed to this thread.
Message ID:
___
There was a method called `to_xml_node` defined on way models. It had a cache
parameter, and `visible_nodes` was passed as this parameter in
https://github.com/openstreetmap/openstreetmap-website/commit/6300fa2a4fa717ef60f715a5303916b85d951c47.
Later in
https://github.com/openstreetmap/openstre
I gave it a try and added attribution for *backend* rendering for PS, PDF, SVG,
PNG, JPEG and WEBP formats.
Code and some sample images:
https://gist.github.com/mmd-osm/fb7b0b53794240315a05369911fc66a2
--
Closed #5550 via #5580.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5550#event-16150390683
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
Merged #5580 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5580#event-16150390645
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes requested changes on this pull request.
Other than the one change I've requested can you squash the two fixup commits
down into the first commit please.
> @@ -211,11 +207,16 @@ OSM = {
return Math.ceil(Math.log10(pixels / degrees));
},
+ cropLocation: function (latLng, zoom
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5580#issuecomment-2628991636
You are receiving this because you are subscribed to this thread.
Message ID:
___
@hlfan pushed 1 commit.
0e8d8a62da7760acca632e5d9870df3db79ec4b5 make map.getZoom() calls explicit
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581/files/cb535c2e2582aadc20ad19037042859127704de9..0e8d8a62da7760acca632e5d9870df3db79ec4b5
You are receiving th
In this case `git rebase -i master` is probably better so you can then choose
to fold some of the fixup commits into the thing they're fixing, and then `git
push -f` to force push the result.
But it you've done a separate PR now then I can review that instead so probably
no point in redoing thi
git rebase master your-branch-name
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#issuecomment-2628872908
You are receiving this because you are subscribed to this thread.
Message ID:
___
But I don't want to pull from the master anyway but from my dev branch, the
master should stay the target branch (why would I want to change that now).
> What you need to do is to rebase, and then force push.
What do you think have I been trying to do? Unnecessarily messing up the commit
history
Closed #5571.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#event-16149592191
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Reopened #5571.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#event-16149590666
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
27 matches
Mail list logo
