You don't need to "change the source branch" because the source branch will
still be master.
What you need to do is to rebase, and then force push.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#issuecomment-2628831887
You
Duplicate of #5281. As far as I know there is nothing more known beyond the
comments I already made there.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5583#issuecomment-2628831546
You are receiving this because you are subsc
Closed #5583 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5583#event-16149354845
You are receiving this because you are subscribed to this thread.
Message ID:
___
rai
> The code changes here look great now but the commit history is rather messy -
> can we get rid of the merges please and rebase it instead? and merge any
> fixup commits into the thing they're fixing - having two `Refactor
> embed.js.erb with layers.yml` commits in one PR can't be right.
Well,
Closed #5571.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#event-16148738092
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
### Problem
I wanted to try running the app outside of the provided Docker setup. I've
followed the instructions in `INSTALL.md` and `gd` (2.3.3_6) has definitely
been installed via `brew`. Any `rails` or `rake` command results in a `Couldn't
load the gd2 library. (LoadError)`, e.g.
```
/Users
Closed #5582.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5582#event-16146498206
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Should be discussed, agreed. Closing.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5582#issuecomment-2628509783
You are receiving this because you are subscribed to this thread.
Message ID:
If the DWG wants indefinite then we should just add indefinite rather than
adding another five years every so often, especially since that won't actually
change any existing blocks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull
Extend user block periods to include 15 and 20 years
### Description
There are currently around 10 user blocks that were created with a duration of
9 years and will end on 2026-01-01. Earlier blocks from 2015 and before that
were decided as "indefinite" have ended on 2025-01-01.
To prevent 10 y
@tomhughes requested changes on this pull request.
This appears to introduce test failures that will need to be resolved.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581#pullrequestreview-2587360907
You are receiving this b
@tomhughes requested changes on this pull request.
The code changes here look great now but the commit history is rather messy -
can we get rid of the merges please and rebase it instead? and merge any fixup
commits into the thing they're fixing - having two `Refactor embed.js.erb with
layers.y
@nenad-vujicic commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", super)
+end
end
> How is this PR going to go in a different direction?
Well, honestly, I don
@AntonKhorev commented on this pull request.
> + height: 100%;
+ z-index: 0;
Do these two properties do anything?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2586823620
You are receiving this becaus
@AntonKhorev commented on this pull request.
> + top: 2px;
+ left: 17px;
+ padding-top: 21px;
Why do you need both `top` and `padding-top`?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5402#pullrequestreview-2586818329
Yo
@AntonKhorev commented on this pull request.
> +.heatmap-wrapper {
+ position: relative;
+ height: 130px;
+}
+
+.heatmap-labels {
+position: absolute;
+ top: 2px;
+ left: 17px;
+ padding-top: 21px;
+ z-index: 1;
+ overflow-y: hidden;
+}
+
+.heatmap {
+ margin-left: 50px;
+ height: 100%;
@AntonKhorev commented on this pull request.
> + const translations = I18n.translations[locale] || I18n.translations.en;
+ const date = translations && translations.date;
+ const abbrMonthNames = date && date.abbr_month_names;
+
+ const months = abbrMonthNames || [];
+ return months[monthIn
@AntonKhorev commented on this pull request.
> + data: {
+source: heatmapData,
+type: "json",
+x: "date",
+y: "total_changes"
+ },
+ scale: {
+color: {
+ type: "threshold",
+ range: currentTheme === "dark" ? rangeColors :
@AntonKhorev commented on this pull request.
> + type: "threshold",
+ range: currentTheme === "dark" ? rangeColors :
Array.from(rangeColors).reverse(),
+ domain: [10, 20, 30, 40]
+}
+ }
+}, [
+ [Tooltip, {
+text: (date, value) => getToolt
@nertc commented on this pull request.
> @@ -65,6 +65,32 @@ def description
protected
+def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_
@AntonKhorev commented on this pull request.
> //= link_tree ../../../vendor/assets/iD/iD/img
//= link_directory ../../../vendor/assets/iD/iD/data .json
//= link_directory ../../../vendor/assets/iD/iD/locales .json
//= link_directory ../../../vendor/assets/iD/iD/mapillary-js .css
//= link_d
@nertc commented on this pull request.
> +def truncate_html(html_doc, max_length = nil, empty_tag_length = 1000)
+ return html_doc if max_length.nil?
+
+ doc = Nokogiri::HTML::DocumentFragment.parse(html_doc)
+ accumulated_length = 0
+ last_child = nil
+
+ doc.traver
Currently skipping is done using `isSkipped` object reference, but you are
right, probably saving ids and then clearing them using `clearTimeout` will be
a better way to approach a problem. I'll update a PR accordingly.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
@AntonKhorev commented on this pull request.
> +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)},
+:telegram => %r{t\.me/([a-zA-Z0-9_]+)},
+:threads => %r{threads\.net/@([a-zA-Z0-9_]+)},
+:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)},
+:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},
@AntonKhorev I'd still say merge sooner rather than later just because all the
arising issues can be autofixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#issuecomment-2627076620
You are receiving this because you are s
The amount of `latlng.lat/lng.toFixed(precision)` calls has been bugging me.
I've put a function next to OSM.zoomPrecision that outputs a latlng array
that can be destructured, spread and `join`ed.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/
@AntonKhorev commented on this pull request.
> @@ -40,6 +40,21 @@
+
+<%= t ".social_links.legend" %>
+
+ <%= f.fields_for :social_links do |social_link_form| %>
+
+ <%= social_link_form.text_field :url, :hide_label => true,
:wrapper_class => "col-sm-8
@AntonKhorev commented on this pull request.
> +
+<%= image_tag
"/assets/social_link_icons/#{social_link.parsed[:platform].nil? ? 'other' :
social_link.parsed[:platform]}.svg",
+ :alt => social_link.parsed[:platform].nil? ? "other" :
social_link.parsed[:platform],
+
If this is merged, I'll have to rewrite #5064 again. That's a bugfix PR. People
are still [complaining about bugs it
fixes](https://community.openstreetmap.org/t/osm-website-routing-start-endpoints-jump-from-original-location/124529).
--
Reply to this email directly or view it on GitHub:
https:
@hlfan commented on this pull request.
>
-if (!o || !d) return;
+if (!points[0] || !points[1]) return;
Which option would you prefer?
```js
if (!points[0] || !points[1]) return;
if (!(points[0] && points[1])) return;
if (!points.every(p => p)) return;
if (points.some(p => !p)) return;
@AntonKhorev commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", super)
+end
end
How is this PR going to go in a different direction?
You're again first reveal
I still see no attempt to record timeout ids:
https://github.com/openstreetmap/openstreetmap-website/pull/5009/files#diff-4fe14e869cf17b068e1bea009a55b094fed13f0cad85337cf4769f32b40a01b5R218
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-webs
@AntonKhorev commented on this pull request.
> @@ -40,6 +40,21 @@
+
Why is the link editor placed between *avatar* and *home location*? If you
don't change the order of other things on this page, this place makes the least
sense to me.
--
Reply to this email directly or view i
@AntonKhorev commented on this pull request.
> +# created_at :datetime not null
+# updated_at :datetime not null
+#
+# Indexes
+#
+# index_social_links_on_user_id (user_id)
+#
+# Foreign Keys
+#
+# fk_rails_... (user_id => users.id)
+#
+
+class SocialLink < ApplicationRecor
@hlfan pushed 1 commit.
cb535c2e2582aadc20ad19037042859127704de9 Remove last o & d references in
getRoute call
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581/files/0155b99ebf1596264989376bb0c8d755f869d7a3..cb535c2e2582aadc20ad19037042859127704de9
You are
Like #5571 but without fixup commits.
Closes #5550 and closes #5571
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5580
-- Commit Summary --
* Refactor embed.js.erb with layers.yml
-- File Changes --
M app/ass
@HolgerJeromin commented on this pull request.
>
-if (!o || !d) return;
+if (!points[0] || !points[1]) return;
I find the current PR version the easiest to read.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5581#di
@AntonKhorev commented on this pull request.
> +:mastodon => %r{mastodon\.social/@([a-zA-Z0-9_]+)},
+:medium => %r{medium\.com/@([a-zA-Z0-9_]+)},
+:quora => %r{quora\.com/profile/([a-zA-Z0-9_-]+)},
+:reddit => %r{reddit\.com/user/([a-zA-Z0-9_-]+)},
+:skype => %r{join\.skype\.
@AntonKhorev commented on this pull request.
> @@ -231,10 +231,15 @@
<% end %>
-<%= @user.description.to_html
%>
-
-<% if current_user and @user.id == current_user.id %>
-
-<%= link_to t(".edit_profile"), edit_profile_path, :class => "btn
btn-outline-primary" %>
+
+
+<%= ren
@AntonKhorev commented on this pull request.
> +:substack => %r{substack\.com/@([a-zA-Z0-9_-]+)},
+:telegram => %r{t\.me/([a-zA-Z0-9_]+)},
+:threads => %r{threads\.net/@([a-zA-Z0-9_]+)},
+:tiktok => %r{tiktok\.com/@([a-zA-Z0-9_]+)},
+:twitch => %r{twitch\.tv/([a-zA-Z0-9_]+)},
40 matches
Mail list logo
