Re: [openstreetmap/openstreetmap-website] Don't add title to note marker if note has no visible comments (PR #3617)

2025-01-30 Thread Anton Khorev via rails-dev
Shouldn't be necessary after #5576. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3617#issuecomment-262009 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Don't add title to note marker if note has no visible comments (PR #3617)

2025-01-30 Thread Anton Khorev via rails-dev
Closed #3617. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3617#event-16129937534 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

[openstreetmap/openstreetmap-website] Adds optional use of note's author and description v2 (PR #5579)

2025-01-30 Thread Nenad Vujicic via rails-dev
### Description It seems to me that #5511 didn't go in satisfying direction, so, created new PR based on [original suggestion](https://github.com/openstreetmap/openstreetmap-website/pull/5485#pullrequestreview-2545467592). PR adds optional use of author and description from notes (in case data

Re: [openstreetmap/openstreetmap-website] Copyedit English localization as American English (PR #5029)

2025-01-30 Thread Andrew Harvey via rails-dev
@andrewharvey commented on this pull request. >"yes": "Amenity" boundary: - aboriginal_lands: "Aboriginal Lands" + aboriginal_lands: "Indigenous Boundary" Which is a bit ironic considering we don't use the tag here https://wiki.openstreetmap.org/wiki/Aust

Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)

2025-01-30 Thread Holger Jeromin via rails-dev
I removed the eslint config part of the PR. So we can merge this PR and discuss the needed place to reference eslint config in the referenced item. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5557#issuecomment-2624265562 You

Re: [openstreetmap/openstreetmap-website] Missing American English localization (Issue #4975)

2025-01-30 Thread Andrew Harvey via rails-dev
> Filling Station Having seen this popup on openstreetmap.org under a search result, it lead me down this rabbit hole to find where that was defined. I would like to see support for localisation to en-AU, unfortunately TranslateWiki doesn't seem to support it. Is it possible to enable or can we

Re: [openstreetmap/openstreetmap-website] Adds optional use of notes records (PR #5511)

2025-01-30 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 6 commits. bc47525980dcbeb7604a76a141e9c59e65a67f8b Adds optional using of notes records 762a6dd2562cca5fc2e3f6ac81fb3db747c0fa30 Adds helper routine note_description bd1af6bfbd70026bae3e798da811eecc5b68258a Replaces using description with note_description 3a09e3eb07f1c23

Re: [openstreetmap/openstreetmap-website] Move deprecated eslint rules to stylistic plugin (PR #5557)

2025-01-30 Thread Holger Jeromin via rails-dev
@HolgerJeromin pushed 1 commit. 267183501e1bc9df671b3452d363389d19ccf5a1 Move deprecated eslint rules to stylistic plugin -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5557/files/4126ef0716ad50e416f174685fe1483180fd3304..267183501e1bc9df671b3452d363389d19ccf