Last update of the PR #5009 adds functionality for canceling layer
loading/unloading. Currently code in that PR works like this:
```
When checkmark is checked:
If unloading is in progress, cancel unloading
Run asynchronous layer loading
When checkmark is removed:
If loading is in progr
Ok I don't think I could've failed harder in squashing the previous commits 🫠
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#issuecomment-2623661506
You are receiving this because you are subscribed to this thread.
Message I
@hlfan pushed 2 commits.
4d1e5e82d8a8cdb76f6b64d69709bed77191b271 Remove other whitespace in layerId too
68ec17022fb50aa0d81ae93b0785abd4d58a4674 Merge branch 'embed-unified-layers'
of https://github.com/hlfan/openstreetmap-website into embed-yaml-layers
--
View it on GitHub:
https://github.c
Reopened #5571.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#event-16118592887
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
Closed #5571.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#event-16118538824
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@hlfan pushed 16 commits.
1a23bfa1ecae74ea47dfb76eadd4e6bc856fed70 Show reporting user on issues screen
4f4808a9fd893fb9a5c109d16b6eb8877749f605 Don't remove-readd standard layer
when layerParam is not empty in map.updateLayers
807d3aa1db35b270d0cdc79fc94f4dc356601496 Remove unnecessary wrappe
1 Warning
:warning:
Merge commits are found in PR. Please rebase to
get rid of the merge commits in this PR, see CONTRIBUTING.md.
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this em
@hlfan approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5558#pullrequestreview-2582868171
You are receiving this because you are subscribed to this thread.
Message ID:
__
@hlfan pushed 1 commit.
36ce71f553947059b44ad0cf6d0f1b37b68650c4 Improve formatting
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571/files/8b2e6b8541964865b9c768d5c9a13713bf15b656..36ce71f553947059b44ad0cf6d0f1b37b68650c4
You are receiving this because you
@hlfan commented on this pull request.
> <% end %>
};
var map = L.map("map");
map.attributionControl.setPrefix("");
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
-new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclemap" || args.
@mmd-osm commented on this pull request.
> <% end %>
};
var map = L.map("map");
map.attributionControl.setPrefix("");
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
-new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclemap" || arg
@tomhughes commented on this pull request.
> <% end %>
};
var map = L.map("map");
map.attributionControl.setPrefix("");
map.removeControl(map.attributionControl);
- if (args.layer === "cyclosm") {
-new L.OSM.CyclOSM().addTo(map);
- } else if (args.layer === "cyclemap" || a
Merged #5573 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5573#event-16112442645
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 2 commits.
358417ee2aa7313178ec906c9985dfb7a6b92756 Update eslint to prefer let/const
over var
4e28e7f5fd4b5f1037f25528b1f0f7909ba836d9 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Merged #5575 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5575#event-16112528023
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes pushed 2 commits.
f52db008232c71a23d3f7990b8168d36af952576 Update eslint to prefer let/const
over var
728d9910a1bdb88b46514536985262de716931d5 Replace uses of var with let or const
as appropriate
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/555
Merged #5574 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5574#event-16112442642
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5577 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5577#event-16112442640
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5576 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5576#event-16112442654
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5578 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5578#event-16112442646
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
It should also mean that the `uniq` becomes part of the database query I think.
Looks good to me in any case!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5578#issuecomment-2622523134
You are receiving this because you are subs
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5577#issuecomment-2622520423
You are receiving this because you are subscribed to this thread.
Message ID:
___
Hopefully this will stop being a problem once the notes schema migration is
complete but this looks fine as a temporary fix.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5576#issuecomment-2622517773
You are receiving this becau
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5574#issuecomment-2622514227
You are receiving this because you are subscribed to this thread.
Message ID:
___
I can't reproduce the blink in Firefox, but the code looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5573#issuecomment-2622512125
You are receiving this because you are subscribed to this thread.
Message
The phrase "reporting user" as in the title of this PR makes more sense than
"reporter user" that is actually used...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2622097897
You are receiving this because you
#4990 added the *Reporter Users* column. It uses reports to sort the users, but
actually all it needs to get from the db are user ids. The existing version
with `map` fetches the entire report by doing `SELECT "reports".*`.
Here I'm replacing it with `pluck` that does `SELECT
"reports"."user_id
Although it can still be optimized, let's start with this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#issuecomment-2622072898
You are receiving this because you are subscribed to this thread.
Message ID:
___
Closed #2273 as completed via #4990.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2273#event-16110494875
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #4990 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990#event-16110494166
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev pushed 1 commit.
db0858732511ee56d8d94f3b56cdaf3cd18d6ad8 Show only description as a marker
tooltip in note layer
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5576/files/c495c3b22614ae4d5a995f47c6a4888d84a23b81..db0858732511ee56d8d94f3b56cdaf3c
Same as #5575 but for notes.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5577
-- Commit Summary --
* Abort loading when note layer is removed
-- File Changes --
M app/assets/javascripts/index/layers/notes.j
@AntonKhorev pushed 1 commit.
c495c3b22614ae4d5a995f47c6a4888d84a23b81 Show only description as a marker
tooltip in note layer
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5576/files/7a8e32851750b512b74ff17684b93d0dd0f3f09d..c495c3b22614ae4d5a995f47c6a4888d
Currently note markers in note layers don't necessarily display note
descriptions. There's no check if the first "comment" returned by
the api is a description or is it a regular comment because the description is
hidden:
https://github.com/user-attachments/assets/50af9642-0067-4b9a-941e-64826c
There is a pull request that addresses specifically adding layers: #5009.
However it schedules layers with `setTimeout` without any possibility to cancel
the process.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2800#issueco
Currently it takes a noticeable time (like a second) for the checkbox to update
if there's a lot of elements to display (over 1). It doesn't wait for
loading over the network, the wait is for Leaflet to add the layer.
--
Reply to this email directly or view it on GitHub:
https://github.com/
@AntonKhorev pushed 1 commit.
b00dc40ff064f35b878c5416ae0cd96f7384097d Abort loading when data layer is
removed
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5575/files/8a1a1e120c75b588ecf57c9a0d2c99eaa5628350..b00dc40ff064f35b878c5416ae0cd96f7384097d
You ar
Currently data layer loading is only aborted when a new request starts.
It's possible to enable data layer, start a long load, disable data layer,
and then after a while receive a warning about too much data despite the layer
is already disabled.
You can view, comment on, or merge this pull requ
Closed #5570.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5570#event-16107086855
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Yes, it also corrects blinking and works expected:
https://github.com/user-attachments/assets/7f394758-06a4-4f6c-b782-68f31d069e9e
The change in the layer through the URL also works.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/p
The message was added in #5551.
There is a slight difference, the flex wrapper shrinks the alert paragraph. We
don't do that in `displayFeatureWarning`.
Before:
After:
 && this.getMapBaseLayer().options.code ===
> "M" && !layers.includes("M")) {
+ layers += "M";
+}
Can you check if
https://github.com/openstreetmap/openstreetmap-website/pull/5573 actually fixes
the same p
> Other than that, what I find useful many times is the amazing [just command
> runner](https://github.com/casey/just) that is multi-platform. If you often
> find yourself executing the same command in the terminal, this might be
> useful such that everybody can do something like `just lint js`.
@deevroman commented on this pull request.
> +if (this.getMapBaseLayer() && this.getMapBaseLayer().options.code ===
> "M" && !layers.includes("M")) {
+ layers += "M";
+}
No problems. If PR is no longer relevant, you can close it.
--
Reply to this email directly or view it on Git
@AntonKhorev commented on this pull request.
> +if (this.getMapBaseLayer() && this.getMapBaseLayer().options.code ===
> "M" && !layers.includes("M")) {
+ layers += "M";
+}
I prefer a different approach to adding more `M`'s #5573
--
Reply to this email directly or view it on GitH
Hello, this looks like an easy fix, I would like to work on it
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5367#issuecomment-2621382001
You are receiving this because you are subscribed to this thread.
Message ID:
_
This is a first commit of another fix which I didn't finish yet because of
https://github.com/openstreetmap/openstreetmap-website/pull/5570#issuecomment-2621121469
and some other things but it should fix the same problem #5570 fixes.
You can view, comment on, or merge this pull request online at:
> move config/eslint.js to root folder eslint.config.cjs
>
> pro: works with every editor (?) without config
> con: pollutes root folder
This one gets my vote. Having it work by default, for most developers, without
making IDE-specific assumptions.
I think that if we need to specify anything in
Just to add my two cents: it's very common to have a `.vscode` in your repo if
many devs use VSCode. If you don't want to see the folder locally, you can even
add this to the `.vscode/settings.json`:
```ts
"files.exclude": {
".vscode": true,
}
```
There are so many great settings you can spec
@nenad-vujicic approved this pull request.
This works great on my side. Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3617#pullrequestreview-2580604257
You are receiving this because you are subscribed to this thread.
But `M` is not removed from everywhere. The so-called `_osm_location` cookie
which also stores currently selected layers keeps `M`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5570#issuecomment-2621174510
You are receiving thi
When the layers parameter `layers=` is empty (or doesn't exist), it could mean
one of two things:
- keep currently enabled layers
- reset to default layers (standard base + no overlays)
osm-website's code is undecided about this:
- `map.setState` behaves as if it wants to keep the currents layers
@nertc commented on this pull request.
> +1.upto(5).each do |n|
+ issue.reports << create(:report, :user => create(:user, :display_name =>
"Test Name #{n}"))
+end
Thanks for the suggestion. Both tests were changed to match smaller list
creation you suggested.
--
Reply to this e
@nertc commented on this pull request.
> @@ -44,6 +44,15 @@ def index
end
@issues, @newer_issues_id, @older_issues_id = get_page_items(@issues,
:limit => @params[:limit])
+
+@unique_reporters = @issues.each_with_object({}) do |issue, reporters|
+ user_ids = issue.reports.or
@nertc pushed 1 commit.
1a23bfa1ecae74ea47dfb76eadd4e6bc856fed70 Show reporting user on issues screen
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990/files/f223d673ae1fe831f6615bdb6ac5bbf7a6c81f14..1a23bfa1ecae74ea47dfb76eadd4e6bc856fed70
You are receiving
I would like to do a poll which editors are used by the main developers.
😄: Visual Studio Code
🚀: Visual Studio
🎉: emacs
❤️: vim
🚀: jetbrains
😕: other
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5572#issuecomment-2620976393
Y
My vote would be for `.vscode/settings.json` because a hidden file doesn't
really pollute the root folder in a meaningful way.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5572#issuecomment-2620976179
You are receiving this b
In #5557 I added a visual studio code workspace file in the `config` folder.
This file can contain settings but also other stuff.
We have different possibilities:
## move `config/eslint.js` to root folder `eslint.config.cjs`
pro: works with every editor (?) without config
con: pollutes root folde
58 matches
Mail list logo
