@nertc pushed 1 commit.
d7eb8b668e0363b45b7f4eb15a17b2ed840e39af Show reporting user on issues screen
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4990/files/0e69bdfa26f3fc0720d1e7a371ca36f06d53e0ac..d7eb8b668e0363b45b7f4eb15a17b2ed840e39af
You are receiving
@AntonKhorev pushed 2 commits.
a214bcb2282a6c613118a3c77b061a7704184f2b Make left sidebar close button sticky
764f2383f2cc1cfa43bc075dceaa7d25ec02768c Make right sidebar close button sticky
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4825/files/fce22582a94
@AntonKhorev pushed 1 commit.
a90362123a06c61150526ff9f6b4e1dc81a1d50b Add older/newer links in front of
diary, comment, issue, block pages
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5262/files/fe1f63c0fadff216eae591c9a694239e6c716cc1..a90362123a06c611505
@AntonKhorev pushed 4 commits.
9851427b32b7123589465f038cabaece2dd469da Add oldest/newest links to shared
pagination
cb95536c09c55fc3b1eb60cc8a8e784fd7ef1a4f Show only pagination icons below
medium/small screen sizes
d3e697a913351325c5695c33bef75449fa709e16 Split pagination buttons into 3 gro
@AntonKhorev pushed 7 commits.
40c0797640307e6cbf9541cd6566f9c77d1c0408 Relax min id value for paging to
include 0
9ca721a050ef3850e54f65423f61f7effa764461 Introduce pagination item helper
1950b17501e7d2fa808c251fa47e01272006411d Replace previous/next page selectors
with helper methods in tes
@AntonKhorev pushed 1 commit.
fe1f63c0fadff216eae591c9a694239e6c716cc1 Add older/newer links in front of
diary, comment, issue, block pages
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5262/files/0b053314fd7f427f2b5c8a0c35b583bda43ce0f3..fe1f63c0fadff216eae
If a block is created without `needs_view`, it's less likely to get noticed
by the receiving user. Nobody could come up with any reason why blocks
shouldn't be `needs_view` by default.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetma
> an index on author+date+id
`+id` is probably not necessary. If a user managed to create multiple objects
during the same microsecond we can afford picking a wrong one. Or select
min/max(id) where created_at is between target_date and target_date+/-epsilon.
--
Reply to this email directly or
Merged #5531 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5531#event-16021137744
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
> filtering by date
Not filtering really, just get the starting id by date and then use it as
`before` or `after`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5531#issuecomment-2605893472
You are receiving this because you ar
Those indexes are all pretty tiny currently so I guess keeping them doesn't
hurt.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5531#issuecomment-2605864060
You are receiving this because you are subscribed to this thread.
Mess
Well then you'd ideally want an index on author+date+id though we have to think
about how much space we want o use on indexes at some point - is here really a
need for filtering by date? How often do you know that you need to look at
comments from a particular date?
--
Reply to this email dire
Creation date indexes might still be useful for combining pagination with date
pickers
https://github.com/openstreetmap/openstreetmap-website/pull/5255#issuecomment-2413857393
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5531#
Merged, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5530#issuecomment-2605816797
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5530 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5530#event-16020619882
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
>end
- # Return the note's author IP address, derived from the first comment
+ # Return the note's author IP address, unless record is unavailable and
+ # it will be derived from the first comment
def author_ip
Do we need this method at a
@tomhughes pushed 1 commit.
0100c2c8b148f2a8d3c2d9181c4454c6d3691ae3 Add indes on user+id to changeset and
diary comments
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5531/files/3ebe31d65cea0442111afd70e29aca4bce153bb7..0100c2c8b148f2a8d3c2d9181c4454c6d3691
This adds indexes on `user+id` to diary and changeset comments to make comment
views more efficient.
Once this is merged we can switch the `diary_comments` association on users to
sort by id instead of creation date and then drop the creation date indexes.
You can view, comment on, or merge this
Merged #5518 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5518#event-16019015784
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Superseded by #5518.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4248#issuecomment-2605528199
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails
I noticed that the comment views were loading objects one by one and this
should make it more efficient.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5530
-- Commit Summary --
* Preload parent objects for user co
Closed #4248.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4248#event-16019021545
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Merged #5528 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5528#event-16019015774
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
This all looks great to me, thanks.
We probably want to think about indexes because changeset comments don't have
an index on author+id (neither do diary comments but some people have 80k
changeset comments vs a few hundred diary comments) but I don't think that's a
blocker based on some quick
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5528#issuecomment-2605459918
You are receiving this because you are subscribed to this thread.
Message ID:
___
As reported in #3971, some URLs like
https://www.openstreetmap.org/?mlat=53.32607&mlon=-1.49033 reset the
currently selected layers. In order to restore the previous setting, a user
needs to select both map and overlay layers after click on the link.
It seems a bit premature to simply override
@AntonKhorev commented on this pull request.
>def author_id
-comments.first.author_id
+if user_ip.nil? && user_id.nil?
+ comments.first.author_id
+else
+ user_id
+end
end
Now you are revealing the true author as soon as migration happens, but not
before.
--
R
@AntonKhorev commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
Copying is not the problem, the problem is you won't be able to th
Depends on how much @gravitystorm is against settings in cookies
https://github.com/openstreetmap/openstreetmap-website/pull/4985#issuecomment-2551576536.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#issuecomment-260485246
@AntonKhorev commented on this pull request.
> +//= require popper
+//= require tooltip
+
+
+/* global CalHeatmap, CalendarLabel, Tooltip */
+document.addEventListener("DOMContentLoaded", () => {
+ const heatmapElement = document.querySelector("#cal-heatmap");
+
+ if (!heatmapElement) {
+c
@nenad-vujicic commented on this pull request.
>def description
-comments.first.body
+if user_ip.nil? && user_id.nil?
+ comments.first.body
+else
+ RichText.new("text", self[:description])
+end
end
Have we reached a decision on this? We planned to copy the body
Hi @nenad-vujicic thanks for putting in the effort to address
https://github.com/openstreetmap/openstreetmap-website/issues/3831
You might have noticed that I've started some time ago working on
https://github.com/openstreetmap/openstreetmap-website/pull/4481 to address the
same issue. Since y
> @simonpoole This is not something you should worry about because it will take
> one `if` statement to remove the entire thing unlike let's say feeds.
Oh, I'm not concerned at all. I was just pointing this out for good form, aka I
saw something that I know is wrong, and I'm giving the people he
33 matches
Mail list logo
