@nertc commented on this pull request.
> + belongs_to :befriender, :class_name => "User", :foreign_key => :user_id,
> :inverse_of => :follows
+ belongs_to :befriendee, :class_name => "User", :foreign_key =>
:friend_user_id, :inverse_of => :follows
I tried to change as few things in DB as po
I don't believe copy & pasting my whole suggestion would be a good idea but i
wrote: [here on GitHub as a issue]
(https://github.com/openstreetmap/openstreetmap-website/issues/1441#issuecomment-2578843087)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/op
I would like to suggest is to do with relation to #dear-diary currently when
viewing via a web browser (I will use Google Chrome for Android) when looking
at New Dear Diary of other Users one thing I would like to suggest is making
server-side translations available. To give an example when i l
@gravitystorm pushed 1 commit.
14b33b9433244c34b8809fcbe6528a077b1709ad Restrict version of dry-schema for
ruby 3.1.2 compatibility
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483/files/818d942ac60c9be99bf5693af8a17d49e39932c8..14b33b9433244c34b8809fcbe65
Yes, this does align with the goals of #3831. This is also an alternative to
#4481 in a way. In fact, the initial motivation for this change came from a
[comment](https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2541604426)
in #5294, which suggested that note versi
How does this relate to the notes restructuring plan from #3831? Is this a step
on the way to that or is it going in a different direction?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5485#issuecomment-2578590234
You are recei
Merged #5486 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5486#event-15859578170
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev pushed 1 commit.
250b032b947f80385de2e96ce7eb3e682e6a16db Use resourceful route for user status
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5437/files/6c89d41e181e2c85104ef40b855345135275df7e..250b032b947f80385de2e96ce7eb3e682e6a16db
You are re
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5462#issuecomment-2578473041
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5462 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5462#event-15858772960
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev commented on this pull request.
> @@ -25,12 +25,12 @@ def test_terms_presented_at_login
assert_template "sessions/new"
post "/login", :params => { :username => user.email, :password => "test",
:referer => "/diary/new" }
# but now we need to look at the terms
-ass
@AntonKhorev pushed 2 commits.
44843c1dd7921b310be264bc0261b3c070d37641 Remove slashes from body css classes
606b5c1b6a3b9314f6abd004e8bd9ed3b4352da5 Use resourceful routes for terms
view/accept/decline
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5462/fil
I didn't spot this in #5357
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5486
-- Commit Summary --
* Update documentation to avoid erb_lint deprecations
-- File Changes --
M CONTRIBUTING.md (2)
-- Patch Li
@AntonKhorev commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
> separately
Won't that be a fixup commit which we don't like here?
> do you have any preferences for referring to the entry
Maybe if we use `
> Does anyone need the `#show` page?
No, I guess not.
I've done a small amount of research into this, to see what other similar
applications do - just to see if there's any conventions. Github, Mastodon and
Discourse all show forms and don't appear to have a show/edit split. Mastodon
has its s
> > Unfortunately the ruby lifecycle and the Debian lifecycle are poorly
> > matched...
>
> I don't think it's a lifecycle mismatch thing, I think it's more that the
> debian packagers are asleep at the wheel. They are shipping software and not
> shipping the bug fixes for that version. Ruby 3.
Closed #5482 as completed via 14b33b9433244c34b8809fcbe6528a077b1709ad.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5482#event-15858426089
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5483 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483#event-15858426181
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
> Because the main tests are using Ubuntu,
"github-flavoured-ubuntu", i.e. they don't use the ubuntu ruby distribution
packages anyway. That's why we can use a matrix of ruby versions in CI. So they
are using 3.1.latest on both Ubuntu 22.04 and 24.04.
> Unfortunately the ruby lifecycle and the
> Why has this downgraded us all the way to `1.13.0` when we were on `1.13.4`
> before I updated yesterday?
Sorry, that's my mistake, related to the order I was testing things locally.
I've pushed an updated version.
--
Reply to this email directly or view it on GitHub:
https://github.com/open
Merged #5480 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5480#event-15858260557
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Why has this downgraded us all the way to `1.13.0` when we were on `1.13.4`
before I updated yesterday?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483#issuecomment-2578363824
You are receiving this because you are subscribed
Much as it pains me I guess we have to take this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5483#issuecomment-2578360741
You are receiving this because you are subscribed to this thread.
Message ID:
This is only affecting docker right? Because the main tests are using Ubuntu,
but it would bite us in production which would be very bad.
I really hate the number of version locks we've got going on now though - we'll
never remember them all when we upgrade and can remove them :cry:
Unfortunat
@gravitystorm requested changes on this pull request.
Looks good to me, one small change in the tests.
I also appreciate the tests are slightly refactored, and this is an improvement.
> @@ -25,12 +25,12 @@ def test_terms_presented_at_login
assert_template "sessions/new"
post "/login",
Does anyone need the `#show` page?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2578313279
You are receiving this because you are subscribed to this thread.
Message ID:
___
@gravitystorm commented on this pull request.
> +assert_redirected_to diary_entry_path(user, user.diary_entries.last)
entry = DiaryEntry.last
Yes, I thought that too. I could refactor that as part of this PR, or
separately. Which would you prefer? (and do you have any preferences for
One option would be to keep the `#show` and `#edit` pages as they are now, but
to link directly to the `#edit` page from the menu. That way, if the user
presses refresh after a failed update, they will see the `#show` page.
--
Reply to this email directly or view it on GitHub:
https://github.c