This changes the path from
`/message/new/:display_name`
to
`/messages/new/:display_name`
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5457
-- Commit Summary --
* Use resourceful route for new message
-- File Chan
This test was about tokens that don't exist since #4535. That PR modified
the test by removing the assert that checked the number of tokens in
https://github.com/openstreetmap/openstreetmap-website/commit/4dff06a6293971c3e17f8508859a1d80717a23f6.
Yet the test was kept although it doesn't do what
`commit` is the name of the submit button, but it's never checked by the
controller and its value is not "save" in the actual forms.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5455
-- Commit Summary --
* Remove
### Description
Changes *Status* column of `/user_blocks` to no longer say "expired
unread".
It was supposed to mean that the block is past its end date but still
wasn't read by the user. That turned out to be confusing because although
it said "expired", such blocks were active.
### How has th
If I remember correctly, at some point DWG discussed making user/details
accessible for blocked users and concluded that sometimes we want it blocked.
It's similar to changeset comments: in most of the cases we want blocked users
being able to post comments but sometimes we don't.
We'd need dif
@HolgerJeromin approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5421#pullrequestreview-2526939816
You are receiving this because you are subscribed to this thread.
Message ID:
__
I'd like to volunteer to help review open pull requests! Could you share any
guidelines or tips for reviewing effectively? I'm happy to start with smaller
or simpler PRs to get familiar with the process. If there are any specific PRs
that need attention or areas where I can be most helpful, plea
Merged #5451 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5451#event-15793811263
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I don't understand why we don't just make the user details call work even when
you're blocked - in fact all read calls I would have thought should work.
That's not to say we might not want this as well as the details call only gives
a count of blocks and not the details though I guess we could a
This changes the user settings page to use turbo to fix the problem identified
in
https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2565252266
where the URL changes when submitting a settings page with errors.
It also fixes an issue where errors weren't moved from th
Closed #1291 as completed via #5443.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/1291#event-15793555827
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5443 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5443#event-15793555770
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes approved this pull request.
Looks good to me now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5443#pullrequestreview-2526839590
You are receiving this because you are subscribed to this thread.
Message ID
13 matches
Mail list logo
