I have to say I'm not clear exactly what dependencies are being referred to
here, or how a web site could "run on CLI" exactly.
Perhaps @x64x2 could provide a bit more information about what they have in
mind?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetm
> Are we every likely to have anything else in Features though?
Moved map key there too.
I thought about combining them into one toolbar button. When you click it, it
shows map key. If you click on the map after that, it does a query. I haven't
done this because it's possible to make queries wo
@AntonKhorev pushed 2 commits.
1dace709cdc73c7d65a87fb19efb8c917bdc89e5 Rename browse controller to
features/queries controller
3002807b728580ae7ecb4a7600e9e33dc3c8e761 Move map key to features/keys
controller
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/
@AntonKhorev pushed 1 commit.
b2711a858700c284c8e3b2b486723f899aced85b Rename browse controller to queries
controller
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5024/files/82efa48976437030d2c1b5ed2ead9ad6161dee10..b2711a858700c284c8e3b2b486723f899aced85b
@x64x2 Almost nothing that anyone would want to do with OpenStreetMap data
requires them to deploy their own copy of the OpenStreetMap website. Rather
than creating an issue in the website repository here, perhaps it might be
better to ask a question over at
https://community.openstreetmap.org
Creates `:user_status` resource with its own controller. You can `:update` this
resource instead of doing `:set_status` on `User`.
"Soft destroy" `:destroy` action is also moved to this resource
because it comes together with status update. It does a similar thing (changes
status), has the same
OpenStreetMap's dependency list is excessive, violating the KISS principle.
this hinders adoption.
*problem*
- numerous and unreasonable dependencies
- unnecessary features for basic use cases
*proposal*
- simplify dependencies and focus on core functionality
- should run on CLI.
--
Reply t
This check was moved to `ApiController` superclass in #4859, but
`MessagesController` was written before that and merged after that in #4605.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5435
-- Commit Summary --
Superseded by #5391
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4969#issuecomment-2558686995
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #4969.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4969#event-15742740436
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Since the line with the not (yet) supported optional chaining is only to make
the updates work without the UI panes (like in the tests) anyway, the
complexity of that predicate can be reduced.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-w
@hlfan pushed 1 commit.
dd7de493a19726b55f2548583b482e0af66942aa Simplify DOM node check
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5426/files/88029efca5865721ea7d011e4fe2064019acf231..dd7de493a19726b55f2548583b482e0af66942aa
You are receiving this because
Merged #5434 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5434#event-15741354338
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, and the difference between inbox and outbox is clearly a bug
that needs fixing anyway. Thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5434#issuecomment-2558419793
You are receiving this because you are s
@tomhughes commented on this pull request.
This mostly looks fine. I think the only thing I'm not sure about is moving
`user#details` into a separate controller - it's basically an alias for
`user#show` so does it make any sense to separate it?
That said @gravitystorm has a better grasp than me
@tomhughes requested changes on this pull request.
Can you fix the lint warning? Then we can get this merged!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5426#pullrequestreview-2519598959
You are receiving this because you a
16 matches
Mail list logo
