I saw the website got an update but it unfortunately still uses the dimmed
tiles as default with OS dark mode despite all of this discussion. Is
@AntonKhorev still pushing for the dimmed tiles alone?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstre
> leaflet-osm should be getting involved in automatic transforms - it should
> have the ability to select a dark tile version where there is one
Do you mean only the extension of `L.OSM.TransportMap` should be added to
leaflet-osm?
--
Reply to this email directly or view it on GitHub:
https://
@hlfan commented on this pull request.
> options = L.Util.setOptions(this, options);
-L.TileLayer.prototype.initialize.call(this, options.url);
+url = isDarkMap ? options.darkUrl : options.lightUrl;
Well, if the provided layers can be expected always to be a light-mode-first
choic
> > inline styles are not allowed by our security policy in production
>
> The `style-src 'self' 'unsafe-inline'` in the CSP header tells me a different
> story.
OK so it is allowed for views with a map. I'm note sure why that is offhand but
our goal is to not have it so we don't add new inline
@tomhughes requested changes on this pull request.
I don't think leaflet-osm should be getting involved in automatic transforms -
it should have the ability to select a dark tile version where there is one and
any automatic transformations should only be in the osm.org code.
> options = L.
@hlfan pushed 1 commit.
a596f959d00a0bbde1c51fdf8fb0e9ffdc4c6787 Get the layer container the right way
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5396/files/47e252da26fca0292a91160c3e0f54accab8b272..a596f959d00a0bbde1c51fdf8fb0e9ffdc4c6787
You are receivin
I wrote it's a leaner variant of #4777, not that I fixed its flaws.
> Changes to anything under `vendor` need to be done in the appropriate
> upstream repository, not here.
That's why I left https://github.com/openstreetmap/leaflet-osm/issues/42 open.
> inline styles are not allowed by our secu
Also inline styles are not allowed by our security policy in production so any
dynamic changes need to be done by adding or removing classes to trigger static
style rules in the main stylesheet.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap
Changes to anything under `vendor` need to be done in the appropriate upstream
repository, not here.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5396#issuecomment-2539848666
You are receiving this because you are subscribed to
This lean and updated variant of #4777 follows the rules laid out in #5328 that
were implemented in #5362.
Since the editing of the user preference happens on a different view/site,
there is no need to listen to color scheme changes on the fly and the whole
logic can happen in the initialization
> using openstreetmap.org/id directly is not really supported
:+1: agree
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5394#issuecomment-2539710967
You are receiving this because you are subscribed to this thread.
Message ID:
Looks good to me, though I would not that using openstreetmap.org/id directly
is not really supported - it's an internal implementation detail that we
certainly don't guarantee.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/539
Merged #5394 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5394#event-15638863621
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Why not expand the options in the preferences to:
* Auto _(same behaviour as suggested by @gravitystorm )_
* Light
* Dark (if available) _(this option would revert back to Light mode tiles if
unavailable)_
* Dark (filter) _(this option will enable the current CSS tile filter against
Light mode ti
Apparently this was decided
[here](https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2504202626)
but I don't understand this choice @gravitystorm.
Even for registered users it's bad because they can't set dark on desktop and
light on mobile for example.
--
Reply to
> > The next question is why?
>
> I think I've answered this multiple times already. The cartographers should
> be in charge of what should be shown for their maps in each desired mode. We
> should not apply any filters unless the cartographers have asked for them.
> That's "why".
But you also
I have to agree with @Nekzuris - accessibility should be available for all
users, not just registered users. Should the preference be stored as a browser
cookie?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment
> The next question is why?
I think I've answered this multiple times already. The cartographers should be
in charge of what should be shown for their maps in each desired mode. We
should not apply any filters unless the cartographers have asked for them.
That's "why".
> But of course the nega
@gravitystorm That's the "yes" answer.
The next question is why? You can see (2nd table) that the only difference
right now is that with your preferred defaults your dark transport map is shown
while with light map defaults it's not shown. That's one thing in favor of your
defaults. But of cour
> @gravitystorm Are you against setting map mode to light by default for now?
I'm not quite sure what you mean here. I'm against changing any default
preferences (they should remain `auto` by default), if that's what you are
asking.
Here's two tables that might help. The first shows how the "de
Comment asking for editable tags:
https://github.com/openstreetmap/openstreetmap-website/issues/3932#issuecomment-1746911041
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5294#issuecomment-2539043342
You are receiving this bec
I thought about this again and versioned notes may be what we actually want. We
already kind of have note versions, they only contain state changes (open ->
closed -> open again). But with tags we might want to record tag changes too.
Being able to change tags allows to use them for more than ju
@gravitystorm Are you against setting map mode to light by default for now?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2538555650
You are receiving this because you are subscribed to this thread.
Message I
> Should the OpenCycleMap layer stay dimmed with reduced contrast as it
> currently is or should another filter (if any) be chosen to optimize the map
> for dark mode?
I'd prefer to see the OpenCycleMap layer displayed normally in dark mode (i.e.
with no filter) for now. I think either we will
> So we're moving from _let's have the map dark in some unspecified manner_ to
> _let's have the map not dark but still call it dark_ (by default when the
> browser reports dark color scheme preference). That's probably not what you
> want.
I want to see all filters removed from all map layers,
25 matches
Mail list logo
