Re: [openstreetmap/openstreetmap-website] Remove brightness filter for map tiles in dark mode styles (PR #5327)

2024-12-10 Thread Nekzuris via rails-dev
I found another technical reason to merge this ASAP: the filter is causing a black and white grid to flicker around tiles borders while zooming on Chrome. It’s slightly noticeable on desktop but very annoying on mobile. -- Reply to this email directly or view it on GitHub: https://github.com/op

Re: [openstreetmap/openstreetmap-website] Adds note tags support (PR #5344)

2024-12-10 Thread Nenad Vujicic via rails-dev
@nenad-vujicic commented on this pull request. > + note.tags.each do |k, v| +xml.tag(:k => k, :v => v) + end Thanks, removed! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5344#discussion_r1879055306 You are receiving t

Re: [openstreetmap/openstreetmap-website] Bump actionpack from 7.2.2 to 7.2.2.1 (PR #5392)

2024-12-10 Thread dependabot[bot] via rails-dev
Closed #5392. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5392#event-15608852183 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Bump actionpack from 7.2.2 to 7.2.2.1 (PR #5392)

2024-12-10 Thread dependabot[bot] via rails-dev
Looks like actionpack is up-to-date now, so this is no longer needed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5392#issuecomment-253316 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Adds note tags support (PR #5344)

2024-12-10 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 8 commits. 12591bcfb671e980ed74c34f3004355e92b47bae Added NoteTag model and note_tags table b8d585a99cebb332960fde3d224d31d4ede3112b Added displaying tags on Notes sidebar 31c9a18f4dcd73afdb1ed8f3d2f70bf0ead99f1c Updated (j)builder files with note tags 8fc5d396891f0a41ba

[openstreetmap/openstreetmap-website] Bump actionpack from 7.2.2 to 7.2.2.1 (PR #5392)

2024-12-10 Thread dependabot[bot] via rails-dev
Bumps [actionpack](https://github.com/rails/rails) from 7.2.2 to 7.2.2.1.
Release notes

Sourced from actionpack's releases.

7.2.2.1

Active Support

  • No changes.

Re: [openstreetmap/openstreetmap-website] Improve scaling and vertical alignment of browse icons (PR #5354)

Closed #5354. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5354#event-15606094728 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] Improve scaling and vertical alignment of browse icons (PR #5354)

This is redundant now #5385 is merged. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5354#issuecomment-2532651518 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Change relative summary dates on user_blocks pages to absolute ones (#907)

Closed #907 as completed via #4200. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/907#event-15606088422 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Reorganize blocks table from status/revoked to begin/end/status columns (PR #4200)

Merged #4200 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4200#event-15606088164 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Rename 'keyid' layer option to 'layerId' (PR #5389)

Merged #5389 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5389#event-15606088143 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Write browse element icons as (PR #5385)

Merged #5385 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5385#event-15606088173 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Reorganize blocks table from status/revoked to begin/end/status columns (PR #4200)

I think this looks good so I'll go ahead and merge it, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4200#issuecomment-2532647015 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Rename 'keyid' layer option to 'layerId' (PR #5389)

Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5389#issuecomment-2532625032 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Write browse element icons as (PR #5385)

@tomhughes approved this pull request. Hmm that style warning is a bit annoying, because string interpolation would be really nasty there, so I guess we live with the dummy variable for now. Other than that is looks good now. -- Reply to this email directly or view it on GitHub: https://gith

Re: [openstreetmap/openstreetmap-website] Move admin users list to its own controller (PR #5391)

@AntonKhorev pushed 1 commit. 507c395f51c20c3c0d5375313ea1ca0ed4156c75 Move admin users list to its own controller -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5391/files/bbe07185a68ae7fca210c7ea55f04fe58d7cdd73..507c395f51c20c3c0d5375313ea1ca0ed4156c75 You

Re: [openstreetmap/openstreetmap-website] Move admin users list to its own controller (PR #5391)

1 Warning :warning: Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more? Generated by :no_entry_sign: https://danger.systems/";>Danger -- Reply to this e

[openstreetmap/openstreetmap-website] Move admin users list to its own controller (PR #5391)

Previous attempt: #4969 What I'm trying to achieve: - free `users_path` helper for POST requests that create users, as explained in #4969 - make `app/controllers/users_controller.rb` smaller You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openst

[openstreetmap/openstreetmap-website] Resourceful routes for traces API (PR #5390)

This is only for `/api/0.6/gpx/`. There are other trace-related routes such as `/api/0.6/user/gpx_files` that are not changed here. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5390 -- Commit Summary -- * Use res

Re: [openstreetmap/openstreetmap-website] Adds note tags support (PR #5344)

@AntonKhorev commented on this pull request. > + note.tags.each do |k, v| +xml.tag(:k => k, :v => v) + end Or not writing the tags in rss for now. Currently nobody is looking for them there. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstre