Re: [openstreetmap/openstreetmap-website] Use relation icon instead of word in containing relations (PR #5374)

2024-12-04 Thread Tom Hughes via rails-dev
Merged #5374 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5374#event-15531203544 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Truncate usernames in trace navigation tabs (PR #5376)

2024-12-04 Thread Tom Hughes via rails-dev
Merged #5376 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5376#event-15531203557 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Replace the text with the icon in the parent relation list (Issue #5368)

2024-12-04 Thread Tom Hughes via rails-dev
Closed #5368 as completed via #5374. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5368#event-15531204124 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Include data: when using allow_thirdparty_images CSP (PR #5378)

2024-12-04 Thread Tom Hughes via rails-dev
Merged #5378 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5378#event-15531203608 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Use relation icon instead of word in containing relations (PR #5374)

2024-12-04 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5374#issuecomment-2518320470 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Include data: when using allow_thirdparty_images CSP (PR #5378)

2024-12-04 Thread Tom Hughes via rails-dev
I suspect this got broken when we moved to the builtin CSP support. It looks good to me anyway, -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5378#issuecomment-2518286647 You are receiving this because you are subscribed to this

Re: [openstreetmap/openstreetmap-website] Truncate usernames in trace navigation tabs (PR #5376)

2024-12-04 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5376#issuecomment-2518265187 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] notes.json endpoint returns empty (redacted?) notes (Issue #5379)

2024-12-04 Thread Tom Hughes via rails-dev
Closed #5379 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5379#event-15529720935 You are receiving this because you are subscribed to this thread. Message ID: ___ rai

Re: [openstreetmap/openstreetmap-website] notes.json endpoint returns empty (redacted?) notes (Issue #5379)

2024-12-04 Thread Tom Hughes via rails-dev
This is just the API version of #2146. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5379#issuecomment-2518030591 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] notes.json endpoint returns empty (redacted?) notes (Issue #5379)

2024-12-04 Thread Anton Khorev via rails-dev
#2146 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5379#issuecomment-2518029940 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mailing

Re: [openstreetmap/openstreetmap-website] notes.json endpoint returns empty (redacted?) notes (Issue #5379)

2024-12-04 Thread Tom Hughes via rails-dev
More likely the user has been deleted and there's already a ticket for that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5379#issuecomment-2518028999 You are receiving this because you are subscribed to this thread. Message

[openstreetmap/openstreetmap-website] notes.json endpoint returns empty (redacted?) notes (Issue #5379)

2024-12-04 Thread Pieter Vander Vennet via rails-dev
### URL GET https://api.openstreetmap.org/api/0.6/notes.json?limit=1&closed=7&bbox=4.21875,50.73645513701065,4.5703125,50.95842672335991 ### How to reproduce the issue? https://www.openstreetmap.org/note/4541086 ### Screenshot(s) or anything else? Originally reported here: https://git

[openstreetmap/openstreetmap-website] Include data: when using allow_thirdparty_images CSP (PR #5378)

2024-12-04 Thread Anton Khorev via rails-dev
We have `allow_thirdparty_images` policy on some pages that sets `img-src` policy to `*`. But `*` does not include data uris. That causes some of the ui elements to disappear. For example, on `/account/edit` there's no dropdown icon: ![image](https://github.com/user-attachments/assets/faa20e87-2

Re: [openstreetmap/openstreetmap-website] broken order on note creation dates with some RTL usernames (Issue #3964)

2024-12-04 Thread Anton Khorev via rails-dev
Have to pick new examples because relative dates change. Current example: https://www.openstreetmap.org/note/4235525 ![image](https://github.com/user-attachments/assets/412943ef-a23a-4977-958f-9f0c106b5ee8) -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/o

Re: [openstreetmap/openstreetmap-website] Truncate if necessary and set dir=auto for note usernames (PR #5377)

2024-12-04 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 16e97c57caf4770e1c6c0e6d52f9f5b2310a0e19 Truncate if necessary and set dir=auto for note usernames -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5377/files/268ae1807503aec3f032670c79e5ff4ce4169667..16e97c57caf4770e1c6c0e6d52f9f5

[openstreetmap/openstreetmap-website] Truncate if necessary and set dir=auto for note usernames (PR #5377)

2024-12-04 Thread Anton Khorev via rails-dev
Similar to #5371 but for notes. Fixes #3964. Before: ![image](https://github.com/user-attachments/assets/44d859dc-20de-43b3-a46f-0095dcf48196) note "43 (part of username) minutes ago", this is issue #3964 After: ![image](https://github.com/user-attachments/assets/084ec00e-cf3c-4552-898f-d14daf7a

Re: [openstreetmap/openstreetmap-website] Truncate usernames in trace navigation tabs (PR #5376)

2024-12-04 Thread Holger Jeromin via rails-dev
@HolgerJeromin approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5376#pullrequestreview-2478052628 You are receiving this because you are subscribed to this thread. Message ID: __

[openstreetmap/openstreetmap-website] Truncate usernames in trace navigation tabs (PR #5376)

2024-12-04 Thread Anton Khorev via rails-dev
Similar to #5366. Before: ![image](https://github.com/user-attachments/assets/ceaa71c7-cf85-4170-ae79-f113a998400e) After: ![image](https://github.com/user-attachments/assets/23222bf5-454d-4f33-805b-4685dccecba4) You can view, comment on, or merge this pull request online at: https://github.c

[openstreetmap/openstreetmap-website] Use fetch() instead of iframe to make remote control requests (PR #5375)

2024-12-04 Thread Anton Khorev via rails-dev
An alternative to #3760. Uses no-cors mode https://github.com/openstreetmap/openstreetmap-website/pull/3760#issuecomment-1290363544 which should work with Potlatch. Requires a browser that is not too old (probably 5 years old max). You can view, comment on, or merge this pull request online at:

Re: [openstreetmap/openstreetmap-website] Use $.ajax instead of iframe to make remote control requests (PR #3760)

2024-12-04 Thread Anton Khorev via rails-dev
Moved "http://127.0.0.1:8111"; to `connect_src` which should fix CSP errors. Did nothing about CORS because looks like jQuery doesn't support no-cors mode. But that shouldn't stop the request from working. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/op

Re: [openstreetmap/openstreetmap-website] Use $.ajax instead of iframe to make remote control requests (PR #3760)

2024-12-04 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 0a5136fc55d219428deb37022574454c3c7e69e9 Use $.ajax instead of iframe to make remote control requests -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/3760/files/776d6b54bc5a03f2800010a0bb9dc85b35db52cf..0a5136fc55d219428deb3702257