Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Mateusz Konieczny via rails-dev
As I understand there was a long-lived code branch. Maybe in future if someone is aware about such branch, having significant user-visible changes, then whoever knows about it (not only repo maintainers) can let Communication Working Group know about this? Or post about it on forums? Would tha

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Nekzuris via rails-dev
> so it seems osm needs a 'beta.osm org' I thought we already had that, but it’s only for iD (https://ideditor.netlify.app/). But I don’t think it’s necessary, a simple post on the official OSM social media announcing that a new dark mode is available for testing in the settings would have bee

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread tomFlowee via rails-dev
@AntonKhorev > It was in active development, six months ago. It would have been difficult to > miss it for anyone following this repo. ok, so it seems osm needs a 'beta.osm org' style website where normies can test it. It obviously didn't get tested enough before deployment, nobody should den

Re: [openstreetmap/openstreetmap-website] Guidance on Enhancing OSM Profile Pages with Contribution Data (Issue #5356)

2024-11-25 Thread Emin Kocan via rails-dev
Thank you for the clarification! Yes, we're focusing on the openstreetmap-website and aim to integrate this directly. Testing queries and performance locally with large datasets would ensure reliability at scale. For development, we can always mock or use a small subset of data to simplify test

Re: [openstreetmap/openstreetmap-website] Guidance on Enhancing OSM Profile Pages with Contribution Data (Issue #5356)

2024-11-25 Thread Paul Norman via rails-dev
> * Changesets in the planet OSM files contain user data, but tools like > Osmosis and Osmium cannot directly link users to contributions in a database. > * Full history dumps provide the necessary data but are massive (~223 GB > compressed, ~3.7 TB uncompressed) and complex to process. If you'r

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Nekzuris via rails-dev
> Did anyone try them with these layers? Sorry this is probably not the feedback you want, but honestly I think they all look bad, even option 4 (unless maybe for specific use cases but not in general) and they should only be available as optional dark styles, and light tiles should remain the

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Marwin Hochfelsner via rails-dev
> Did anyone try them with these layers? Testing all possible combinations is unreasonable but for all osm-featured hillshading layers a version of the feFunc-based dimming with a slight positive offset, an amplitude of 0.6-0.9 and a gamma value of 1.5-3 * seems to yield the best results. \* t

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Marwin Hochfelsner via rails-dev
> started by adding a dark mode toggle in the settings, staying in light mode > by default until they were confident enough to link it to user preferences. Which was done here, there was a flag that could be set in the html to enable the dark mode. However, this was apparently not communicated a

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Anton Khorev via rails-dev
> > This one: enable my rotation filter ignoring problems with hillshading? > > @AntonKhorev You were the first person to point out that this a problem. So > it took years to get any feedback. I wasn't. Hillshading specifically was first mentioned by @gravitystorm here. There also was a predece

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Nekzuris via rails-dev
@AntonKhorev It’s unreasonable for you to expect OSM users to look at all the pull requests to give feedback before a change as significant as this one gets implemented. Many other websites and apps I use started by adding a dark mode toggle in the settings, staying in light mode by default unti

[openstreetmap/openstreetmap-website] Guidance on Enhancing OSM Profile Pages with Contribution Data (Issue #5356)

2024-11-25 Thread Emin Kocan via rails-dev
### Problem We want to enhance the OSM profile pages to include more engaging and informative features, similar to [HDYC](https://hdyc.neis-one.org/). The goal is to display user contribution summaries, activity patterns, and insights into changesets. However, we're unsure about the best approa

Re: [openstreetmap/openstreetmap-website] Dark Mode for maps (Issue #5328)

2024-11-25 Thread Anton Khorev via rails-dev
> It doesn’t matter that it was applied twice, you and every other dev who saw > it like that thought it was fine. @Nekzuris you should have looked at it and say that it wasn't fine. > You’re just using the fact that it was applied twice to justify reducing the > intensity by half as a bug fix.

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
Thank you for the review. PR was updated according to the comments. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302#issuecomment-2497515015 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -178,6 +220,42 @@ $(document).ready(function () { } } + function updateHomeLocation() { +const lat = $("#home_lat").val().trim(); +const lon = $("#home_lon").val().trim(); +if (!lat || !lon) { + return; +} + +const g

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > + +<%= t ".location_name_warning" %> + + Was changed with the button named "Autofill %{country}". -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302#discuss

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -178,6 +220,42 @@ $(document).ready(function () { } } + function updateHomeLocation() { +const lat = $("#home_lat").val().trim(); +const lon = $("#home_lon").val().trim(); +if (!lat || !lon) { + return; +} + +const g

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
@nertc commented on this pull request. > @@ -0,0 +1,22 @@ +require "application_system_test_case" + +class UserLocationChangeTest < ApplicationSystemTestCase + def setup +stub_request(:get, /.*gravatar.com.*d=404/).to_return(:status => 404) + end + + test "User can change their location"

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 5fd8b6165732618de7d8ef987d170809eacfb59a Add profile location -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6..5fd8b6165732618de7d8ef987d170809eacfb59a You are receiving this because yo

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6 Add profile location -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e..9f8d33b3d3b972ab4e653f2e9aefb18606d8b2f6 You are receiving this because yo

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-25 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e Add profile location -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda..91030dc47f1b2e1d1fcc1475e9c2c8e109a9108e You are receiving this because yo