Add icons for elements that don't have any icon defined by their tags.
Those are the standard node/way/relation ico
Currently map layer API keys have one extra level of indirection:
- keys are defined in the settings
- `osm.js.erb` reads them from the settings and writes them to
`OSM.THUNDERFOREST_KEY` and `OSM.TRACESTRACK_KEY`
- `layers.yml` contain names of `OSM` properties to check for keys
Instead of this
@AntonKhorev pushed 5 commits.
e1589e1bbe9303448992a0c76e5544063bf9814d Manage base layer switching in
L.OSM.Map
64debe60a11e2917d6ce7278ddf208490e78cc2e Define custom dark filters for map
layers
91820985d558fa26e624d17c95a00adf11cc3fc8 Read dark mode filter from custom css
property
eaa8ed82
I made a little utility to try out filter combinations more easily:
https://codepen.io/hlfan/full/GRVVGog
For convenient editing in the dev tools, the outputted filter is stored in a
custom property and the filter is also applied to the SVG that holds the
filters.
My first insight from using it:
On a grayscale, the default OSM light theme is actually 19% dark, whereas a
typical light page with black text is around 3%.
The dark theme you showed is 90% dark.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecommen
>The main issue I see is that your proposal adds a 'theme' to a layer.
It adds a theme to the whole map. The user can turn it on or off, but they have
no control over specific layers.
>A 'dark mode' (as this issue calls it) is from a user perspective a layer.
No, this is what I'm proposing:
