Closed #5283.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5283#event-15390583867
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Implemented in
https://github.com/openstreetmap/openstreetmap-website/pull/5284,
https://github.com/openstreetmap/openstreetmap-website/pull/5304,
https://github.com/openstreetmap/openstreetmap-website/pull/5310,
https://github.com/openstreetmap/openstreetmap-website/pull/5314,
https://github.
@AntonKhorev pushed 1 commit.
126a987aa8b2d95b90b0970fba7d4e6df1cfaac0 Move layer definitions to yml
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5349/files/eda9d17a325ae3c94dd6ca41c6c36fe7d5743336..126a987aa8b2d95b90b0970fba7d4e6df1cfaac0
You are receiving
@tomhughes approved this pull request.
Thanks - that looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5346#pullrequestreview-2452872448
You are receiving this because you are subscribed to this thread.
Message ID
Merged #5346 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5346#event-15389511479
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@AntonKhorev pushed 2 commits.
703990a5bbdcdb782ef85983b960253aecc3e163 Move map layer ids/codes/keys to
layer definition data
eda9d17a325ae3c94dd6ca41c6c36fe7d5743336 Move layer definitions to yml
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5349/files/c9
Enabled showing errors for (un)subscribe buttons.
I didn't want to do this because the most likely error is that you're blocked
and your access to the api is removed. But we shouldn't block people from
unsubscribing. I thought that maybe I'll allow that first.
--
Reply to this email directly o
@AntonKhorev pushed 1 commit.
aca9bd205e78ac5f5d37489b2583817c178a6f8e Add subscribe/unsubscribe buttons to
note pages
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5346/files/b88e3f7dc132bb7d0fad1d10b4d3d8f9f96d5df3..aca9bd205e78ac5f5d37489b2583817c178a6f8e
@AntonKhorev pushed 1 commit.
00270dd86ee4116a931074c1145663ca74fe405a Collect map layer credits into a data
structure
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5348/files/50564e3d0290604278e694e3f250b92e1499ede9..00270dd86ee4116a931074c1145663ca74fe405a
Merged #5348 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5348#event-15386831177
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5348#issuecomment-2492033444
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes commented on this pull request.
This mostly looks good - my only question would be about error handling for
subscribe/unsubscribe as the error text reporting has been moved to only happen
for the comment button.
The equivalent code for changesets reports the error in all cases by the
Next step after #5348. Removes all layer-specific code from `leaflet.map.js`.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5349
-- Commit Summary --
* Collect map layer credits into a data structure
* Move map l
Can we have a proper map layer configuration that can be edited without going
into javascript and altering bits across different files? I started doing this,
here's a subtask of making a configuration for layer credits. It removes a
bunch of interdependent variables like `var cyclosm_link`, `var
With the decision tree like this:
For each layer:
If light mode active use standard
If darkURL (dark tiles) use that
If local (layer-spanning) filter preference use that
If cartographers choice filter use that
Else default to `filter: none`
That would leave the user with at least four choices:
-
Many of the use cases covered by this issue/PR are currently solved with hash
tags (e.g. #surveyme) and tools are currently made to take these into account.
Tools would need to be adapted to support tags as well.
The advantage of having tags implemented like this properly would be that there
co
>We can then revisit whether people want even further micro-control like
>choosing their own filters (to override the decisions of the cartographers).
@gravitystorm So it seems that you're not against having filters. You're just
against applying them by default (even if it can be turned off). In
Here are a few more benefits of adding note tags to OSM, as implemented by this
PR:
1. Improves **notes categorization** (by e.g. adding descriptive tags for
better organization like "Missing place" or similar):
Yes. I got a batch of emails about reopened notes today and I got one yesterday.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
> Is catching "fixup" commits ... could help maintainers?
You can't do that automatically.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5314#issuecomment-2491356594
You are receiving this because you are subscribed to this thre
this will work to restore the light mode map, but it will also stop saving your
eyes ;-)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2490806165
You are receiving this because you are subscribed to this thre
@nenad-vujicic approved this pull request.
This works great on my side, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5347#pullrequestreview-2451241657
You are receiving this because you are subscribed to this thread.
> ... A "fixup commit" is a commit that's added to a pull request that fixes
> problems with code introduced in the same pull request.
>
> From CONTRIBUTING.md (emphasis added)
>
> > Avoid including "fixup" commits ...
Is catching "fixup" commits (a line added (removed) in one commit and then
> I tweaked a bit the parameters to improve some layouts but it still can have
> some overlapping sometimes. I don't really have the time to read a 167 page
> thesis and try to implement their findings, do you know if there is reference
> implementations I can have a look?
There is a C++ / Open
Hi all,
I am very sorry, but I also find that the recent dark mode changes make the map
unusable to me. I just cannot perceive important information on
tracestrack_topo anymore. My system is set to dark mode because I want to save
my eyes. However, it is still important to perceive all relevan
I tweaked a bit the parameters to improve some layouts but it still can have
some overlapping sometimes.
I don't really have the time to read a 167 page thesis and try to implement
their findings, do you know if there is reference implementations I can have a
look?
What is the `Ctrl + select RO
> If you did any mass note manipulation in some area, chances are someone else
> will start altering these notes later. In this case you'll receive waves of
> emails and there's no way to stop them.
relatively few mass note manipulation should be done then abandon discussion,
though I expect th
How about removing this brightness filter first and then continue your
discussion? The map is very hard to use at the moment. Apparently [lots of
people agree
](https://community.openstreetmap.org/t/openstreetmap-in-dark-mode/119216/25)on
that.
--
Reply to this email directly or view it on Gi
29 matches
Mail list logo
