As mentioned by @Nekzuris in on this
[PR](https://github.com/openstreetmap/openstreetmap-website/pull/5330#issuecomment-2479700613),
the dark mode brightness filter
```
@include color-mode(dark) {
.leaflet-tile-container .leaflet-tile,
.mapkey-table-entry td:first-child > * {
filter: brig
This was supposed to be working already #4764 but something broke it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5338#issuecomment-2481361763
You are receiving this because you are subscribed to this thread.
Message ID:
> What are you waiting to merge this?
This PR needs to be updated, because [another
PR](https://github.com/openstreetmap/openstreetmap-website/pull/5330) was
recently merged that alters the brightness filter.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetma
@AntonKhorev commented on this pull request.
> @@ -338,9 +338,9 @@ en:
nodes_count:
one: "%{count} node"
other: "%{count} nodes"
- also_part_of_html:
-one: "part of way %{related_ways}"
-other: "part of ways %{related_ways}"
+ also_part_of_ways:
@AntonKhorev pushed 2 commits.
9e37f398f3d159379ac41aaaebcd786f2c0e7d89 Show "node also part of ways" as
nested lists on way pages
900719cd3b8202337c9afa686bbe39c0a4800105 Put nested "also..." lists into
collapsible details
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap
@AntonKhorev pushed 3 commits.
1410fbaa44a1d67a41f0ce305a4222e36de83bef Add create note subscription api
endpoint
0ce4ae3f80b6b7e1762383ee2efceb26a208800c Add destroy note subscription api
endpoint
6416cdeef8c6b9138d166934e32619d13d0dd416 Add error messages for note
subscribe/unsubscribe
--
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,22 @@
+module Api
+ class NoteSubscriptionsController < ApiController
+before_action :check_api_writable
+before_action :authorize
+
+authorize_resource
+
+def create
+ note_id = params[:note_id].to_i
+ note = N
What are you waiting to merge this?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5327#issuecomment-2481495761
You are receiving this because you are subscribed to this thread.
Message ID:
__
Hi!
Following your feedback I improved the first experience on Azimutt:
- much better auto-layout for showing more tables
- improved the welcome screen to show more tables in one click
- no more table limit on the initial layout
- table suggestions on the search
Let me know what do you think about
Reopened #5329.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#event-15325551923
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
Can someone merge #5327 ?
It's unacceptable that all users with a dark browser preference are forced to
endure the highly controversial dimming while waiting for a better solution to
be implemented.
Their only options currently are switching all websites to light mode or
install an extension to
> which of the options you've tested you think would be best?
Well, for option 2 / dimming, some filter involving gamma tweaking because it
eliminates the most common complaint about the dimmed map, loss of contrast,
without clipping some input ranges to completely black or white. Also, IMO it
Don't write that your pull request "fixes" this issue, Github closes it
automatically on merge.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2481392822
You are receiving this because you are subscribed to th
Merged #5334 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5334#event-15325716215
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
It's probably Sass's `@include color-mode(dark)` generating an extra selector
in `$color-mode-type: data` and not generating it in `$color-mode-type:
media-query`, resulting in lower specificity.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetma
@AntonKhorev I don't think linking that PR / closing this issue was the best
idea.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#issuecomment-2481387557
You are receiving this because you are subscribed to this thread.
M
Closed #5329 as completed via #5338.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5329#event-15325496992
You are receiving this because you are subscribed to this thread.
Message ID:
_
The specificity is the same as in Leaflet css, then it depends on the order but
I don't see where we changed the order. It would have been in
`app/views/layouts/_head.html.erb`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/533
@AntonKhorev pushed 1 commit.
6f06d69342da5d2975d606b3c6fe855cc989a0a7 Don't change color scheme preference
if the value wasn't provided
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5339/files/354f41b8453d3284872acb51153c6085a4119080..6f06d69342da5d2975d606
The same as #5337 but stores the preferred color scheme value in user
preferences db table instead of cookies.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5339
-- Commit Summary --
* Add auto/light color scheme
> I don't think a map is like a photo at all. It's not satellite images, it's
> just a bunch of data
You only consider labels and lines, but with fill colors and shadows, it’s more
like a digital painting.
Style creators spend a lot of time carefully designing it, and you can’t just
override i
@hlfan Great work! I didn't even know there was a feature like that. And
recently I've even thought of using WebGL shaders for a more advanced filter
(there is a Leaflet plugin for that). Anyway, which of the options you've
tested you think would be best? Gamma is already a big improvement over
### Description
This PR increases the specificity of the dark mode attribution selector. The
style was first added in #4764, but didn't overwrite Leaflet's default
link selector. That increased specificity fixes #5329's bug report about
this by @Nekzuris
| before | after |
|-|-|
|
. When the dark
theme originally went live the map dimming filter was significant and
definitely felt hard to read, but since then the dimming has been reduced and I
find it not too bad currently. It still does feel a bit dull and low c
@mxdanger Sorry, I overrwrote your comment and there seems to be no undo in
Github UI.
You said that there's an overwhelming feedback for not modifying the map and
asked what should be the default.
But there is a feedback for doing inverse+hue-rotate transform.
--
Reply to this email directly
Imo the background around the search box is unnecessary:
maybe replace is by a shadow
--
Reply to this email directly
What [Wilhem275](https://github.com/Wilhem275) said, can't add more to that.
Devs, please follow that route.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2481258861
You are receiving this because you are sub
First of all I want to thank all devs for their works. As I stated in the OSM
board I have zero experience in programming, so I can at most nag about...
ahem, offer my personal advice on choices 😁
@gravitystorm please help me understand the difference between Option 1 and 4.
>From what I get, i
I've looked at a few options for dimming and inverting involving SVG filters.
| no filter | current | heavy | gamma |
|-|-|-|-|
| 
|  invert(1)
contrast(3) hue-rotate(200deg) saturate(0.3) brightness(0.7)` on Firefox?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstr
If it's in the user preferences it should be stored in the database not in
cookies.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2480617865
You are receiving this because you are subscribed to this thread.
Me
31 matches
Mail list logo
