> Regarding option 3b (advanced filters) I'd like to suggest [this
> article](https://monochrome.sutic.nu/2024/02/25/hue-preserving-invert-css-filter-for-dark-mode.html)
> as explanation on why this is important, but hard.
If/When we're implementing an svg filter for that anyway, we can use the
Hi, the latest change to OSM regarding this has actually made it much harder
for me to use because of how low-contrast the map now is. I would actually say,
in my opinion it would be more preferable from an accessibility POV to _not_
honour the user's dark mode preferences than it would be to sh
>Tracestrack on low zooms doesn't look good even we ignore shadows. The colors
>are completely off.
>But (as previously mentioned) Option 4 for Tracestrack has the same Issues.
@AntonKhorev @hlfan Would something like this be a step in the right direction?
This just for the Tracestrack layer:
Again, what will the default be? There is overwhelming feedback against
modification of the map.
The default should be 100% brightness (no modification) but I’m wondering if
your stance on this is the same.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/
> The map is like a photo, and any photo-viewing applications display photos
> the same way regardless of whether they are in dark or light mode.
It's an interesting viewpoint, but I think of it differently. I think a user
interface has text, icons and areas of colour, and maps are a bit like th
Contrast is a bit too low in the topbar, even in light mode. Chrome shows green
at 4.5 but I think it should be even higher since this text is important.
 in `about:config`
`toolkit.legacyUserProfileCustomizations.stylesheets`, then restart Firefox,
> @gravitystorm is incorrect to perceive "dark mode for the maps is off-topic"
I want to clarify here that I didn't say that, I said "The exact implementation
of dark mode for the maps is off-topic for this issue." What I mean is that
it's not the right issue for discussing things like whether `
Here's a simple UI proposal:
Dark theme toggle depends on system settings (just like now), but user can
override it by pressing the toggle button in top left corner. The setting will
be remembe
> But (as previously mentioned) [Option 4 for
> Tracestrack](https://console.tracestrack.com/explorer) has the same Issues.
Their "Dark" is not dark at all, "Dark 2" is even worse at preserving colors,
but in "Dark 3" colors are better, that's one issue less.
--
Reply to this email directly or
Adding onto @pkrasicki's proposal:
Modern CSS could even skip the body class:
```css
.leaflet-tile-pane .leaflet-layer:not(.dark), .mapkey-table-entry
td:first-child > * {
body:has(input[type="radio"][name="filter"][value="light"]:checked) & {
filter: none;
}
If that setting is stored in a cookie instead of in `localStorage` the server
can already set the theme to avoid flashbanging users reloading the site (e.g.
to see how their edits show up), as this would probably come rather late in the
packaged js.
--
Reply to this email directly or view it o
> Just deploy it, we’ll see if many people complain 😅
Since most Firefox users browse modern websites just fine, I suspect not many.
But [here's a UI
proposal](https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2480755496)
that would let you quickly disable the filt
The numbers on profile pages are hard to read.
---
The popovers (or whatever these balloons are called) should have dark
background, right?
, or use a different browser just for looking at
> OSM
AFAIK map was still shown? At most it was really ugly/poorl
> Instead, https://github.com/openstreetmap/openstreetmap-website/pull/5330 is
> being fast-tracked, because "making it a little less dim" is assumed to
> clearly fix everyone's problem with the changes.
based on PR description, it was fast tracked as a bug fix ("darker than I
intended them to
@gravitystorm It's also because the Carto render is iconic to OpenStreetMap,
many people only recognize OSM by this map style and changing it makes it feel
unfamiliar.
Even if we already had a proper dark render, I would still want to see the
light Carto render for some tasks without having to
> I'd rank the Options 4 > 1 > 3 > 2 (current), since these performance issues
> came up.
I'm sorry, but I think it's an exaggeration to call it that. There aren't
performance issues, it's a bug in Firefox that affects an unknown amount of
users. It's unfortunate that some people experience it,
> How would not logged-in users change this setting?
At first they they wouldn't be able to, like with languages.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2480731869
You are receiving this because you are
How would not logged-in users change this setting?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2480729037
You are receiving this because you are subscribed to this thread.
Message ID:
___
As for preferences, I'd like to hear from people what kind of preferences they
would like to see. So far, across multiple different threads, I've seen the
following:
* Automatic / Light (always) / Dark (always)
* Should this be stored per-user or per-browser (e.g. someone wants dark-always
on t
> Inversion with hillshading doesn't look better to me.
This issue remains with Dark 2 and 3.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480732052
You are receiving this because you are subscribed to this
No I have an i7 10700K and RTX 3060, Firefox 132.0.1, Windows 10, 2560×1440p
144Hz.
It's also slow on my less powerful laptop but completely fine on Firefox for
Android.
I found these bug reports:
https://bugzilla.mozilla.org/show_bug.cgi?id=1826576 &
https://bugzilla.mozilla.org/show_bug.cgi?
By making the setting available to other apps I meant iD of course. Its color
scheme preferably should match the entire site, that means it has to know
somehow whether to use `prefers-color-scheme` or ignore it. Let's suppose we
made this setting somehow readable through the api. iD will look at
@pkrasicki
> The issue here is that the devs have been ignoring our dark map discussion
> for years
For years nobody could produce viable pull requests implementing dark mode.
#2532 and #3028 were overriding *a ton* of css, justifying it with arguments
like *osm-website doesn't change much the
I'd rank the Options 4 > 1 > 3 > 2 (current), since these performance issues
came up.
> > Option 4 would be the best.
>
> Tracestrack on low zooms doesn't look good even we ignore shadows.
But (as previously mentioned) [Option 4 for
Tracestrack](//console.tracestrack.com/explorer) has _the same
>For years nobody could produce viable pull requests implementing dark mode.
>https://github.com/openstreetmap/openstreetmap-website/pull/2532 and
>https://github.com/openstreetmap/openstreetmap-website/pull/3028 were
>overriding a ton of css, justifying it with arguments like osm-website doesn'
> When you're talking about inverting the colors, I hope you don't mean
> literally just that?
Just to clarify - no, we don't mean literally just inversion and nothing else!
I hoped that would have been clear from the description of option 2 above, to
quote:
> More complex filters to invert th
I also just want to add my thanks here to @pkrasicki and @Nekzuris for working
together on investigating the performance issues with complex filters and to
try and understand how big an impact this might have for a wider audience.
Until this week I had no idea that this could be a problem. It's
I don't think this preference mashup between local and database storage is a
great idea.
But if logged-in users have the preference synchronized and non-logged-in users
have the color and language (editor choice seems pointless for non-logged-in
users) stored in the cookies it could be interest
I don't think so, it's very noticeable, it drop to like 10fps.
And it's actually fine now on my laptop, I hadn't tested since last year, so it
might no affect as many people as I thought, I will investigate further on my
computer.
--
Reply to this email directly or view it on GitHub:
https://gi
Closed #5321.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5321#event-1532198
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
> @pkrasicki And you can drag the map smoothly? I have a huge increase in input
> lag when dragging the dark map.
It's smooth for me on a 10 years old CPU running Firefox 128.4.0esr. Sometimes
it's laggy when I have the dev tools open, but that happens regardless if the
filter is enabled or not
> They certainly don't decrease.
Yes, I said that in case of Github they increase but not by much, in other
cases they don't, so not "certainly"
https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2478710958
> I don't think filters are a good idea, we just need one go
Maybe you can see it and I can't, because of your monitor's higher refresh rate
(I'm not sure about your laptop, though) or because I'm testing on 1080p.
Thanks for finding those bug reports. We could include an option to disable the
filter for the people affected by this bug (so allow them to h
@AntonKhorev pushed 1 commit.
8176bc16dd3dd7352627ffce47b5afa0b0bdd348 Store selected color scheme in cookies
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337/files/4edcaa46ce0456126023f35888d929b09b8d3da6..8176bc16dd3dd7352627ffce47b5afa0b0bdd348
You are r
@pkrasicki And you can drag the map smoothly? I have a huge increase in input
lag when dragging the dark map.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480624689
You are receiving this because you are su
@AntonKhorev pushed 2 commits.
d6e083a712d7136894e67574c3d08f0381269cc5 Add color scheme select to
preferences form
af06e4179536ca032f6c8733d0de06cca6d5aae3 Store selected color scheme in cookies
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337/files/8176
A quick implementation of auto/light scheme switch for those who want to stay
on the light scheme even when their browser says they want the dark one.
 invert(1)
> contrast(3) hue-rotate(200deg) saturate(0.3) brightness(0.7)` on Firefox?
@Nekzuris Yes, you can test that specific filter [on this
site](https://issviewer.com).
Here is how to easily test different filters yourself.
1. Go
But should it be in user preferences?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337#issuecomment-2480618559
You are receiving this because you are subscribed to this thread.
Message ID:
@AntonKhorev pushed 2 commits.
3017ceafc23e4d297dad01abaf3e8fae7af0915c Add color scheme select to
preferences form
4edcaa46ce0456126023f35888d929b09b8d3da6 Store selected color scheme in cookies
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5337/files/9c6d
>Couldn't the dark mode have waited for the release of the vector.osm.org tiles?
@hlfan There is nothing wrong with incremental progress. The issue here is that
the devs have been ignoring our dark map discussion for years and did something
without talking to the community, which turned out to b
> Because it dims the graphic screen! @gravitystorm is incorrect to perceive
> "dark mode for the maps is off-topic" They are determinately intertwined.
>
Exactly. That user has declared multiple interrelated microissues with strict
"off topic" rules for each which is illogical and impractical
Which dark style do you think of for this important default spot? Is it a dark
carto or some other layer?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5328#issuecomment-2480600198
You are receiving this because you are subscr
> For example, we got here believers in inverse+rotate. Why do they think that
> it's the best option? Probably because it generally works for the standard
> layer.
I'm generally in team invert, but here for the default of no filter. And I
don't think layer-wise filters add more than they take
That's the question, certainly not the current one with 20% dimming, maybe a
more complex filter can work while waiting for vector tiles or simply keep the
same as light mode for now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/is
> Do you mean not showing layers that don't have a version with dark tiles?
No, normal tiles with dark UI looks great, just add a dark style in addition to
the others and make it default for dark mode but easy to change.
--
Reply to this email directly or view it on GitHub:
https://github.com/
> They don't change much between light/dark modes.
They certainly don't decrease.
> Do we need different filters for different layers?
I don't think filters are a good idea, we just need one good dark styl
> Having a dark menu bar is nice, but simply dimming the map is just not
> acceptable. Maybe as a first step towards a truly dark mode, but please,
> please, please make it easy for the user to switch back to light mode. The
> toggle is a must!
THIS EXACTLY. The menu dark is fine but the map i
Do we need different filters for different layers? For example, we got here
believers in inverse+rotate. Why do they think that it's the best option?
Probably because it generally works for the standard layer. Even if you
convince them that it doesn't work for all layers, they'll be able to say
@tomFlowee I'm talking about contrasts as reported by:
They don't change much between light/dark modes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
> From what I understand to be the sole criticism (mine included) of the
> initial introduction dark mode was the dimmed map.
No it wasn't. There are at least three different groups that complain:
- those who want the browser-reported preferred color scheme to be ignored
- those who don't want an
> It's a shame that @AntonKhorev saw all the feedback
I saw that there's a bug.
> and completely ignored it with fast tracking this change
> https://github.com/openstreetmap/openstreetmap-website/pull/5330
This is a fix for that bug.
> until https://github.com/openstreetmap/openstreetmap-websi
> giving space to something like this
There was the [suggestion to put the configuration into the
preferences](https://github.com/openstreetmap/openstreetmap-website/pull/5325#issuecomment-2477533827),
and I kind of like it. Maybe a dropdown that allows you to choose how you'd
like it to be. (T
> They literally think we want to just invert the colors and that's it.
Actually OSM just darkens the tiles and that's it.
Anyway; you state that "we've already explained why we need it...".
Can you link to that? I have doubt.
--
Reply to this email directly or view it on GitHub:
https://githu
@AntonKhorev
> > The idea of dark mode has always been about contrast.
> Wikipedia has slightly lower contrast in dark mode.
You didn't quote the full paragraph that tried to add the needed background. It
factually is about contrast, but the simple comparing of two colors doesn't
give you th
Couldn't the dark mode have waited for the release of the vector.osm.org tiles?
Then the light mode could've got the colorful style and the dark mode could've
got the eclipse style and that would be the point of conversation instead of
how dimming the map is seemingly the worst option.
--
Repl
59 matches
Mail list logo
