Closed #5103.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5103#event-15294308158
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
PR was updated. Now friendship controller and model are refactored to be named
as "follow" and also implement standard CRUD architecture using `create` and
`destroy`. Old controllers, models, views and tests were removed, and new ones
were added with the new names and architecture.
--
Reply to
@nertc commented on this pull request.
> + def truncate_html(html, max_length, empty_tag_length = 500)
+doc = Nokogiri::HTML::DocumentFragment.parse(html)
+accumulated_length = 0
+truncated_node = nil
+
+doc.traverse do |node|
+ if accumulated_length >= max_length
+
> And if there's more than say 3, write something like
>
> > UserA
> > UserB...
> > UserC
> > and 2 more users
@AntonKhorev do you mean to make this kind of truncation in the tooltip?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-we
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
@nertc pushed 2 commits.
aaffdaadbf13fff043f9171e815161a079014b11 Modify the way Friends are added
02bede750de8a388d0ef378e2c2c583bfba1ca4a Refactor friendships controller and
model
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261/files/8393857518195d145a
Looks good to me! I think it's worth starting with the automatic mode, since
that should just work for most people (and will automatically support day/night
switching for devices that do that).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-
Merged #4761 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4761#event-15288957101
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #4854 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4854#event-15288212442
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I think this is reasonable, since the History and Export buttons are too
prominent in the current design. I think it might take a bit of getting used
to, since it's the first time we've changed these buttons in a long time.
I wouldn't be surprised if we get feedback on this, but let's try it and
Merged #5151 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5151#event-15288212141
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Great, thank you!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5293#issuecomment-2474457326
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-de
@tomhughes commented on this pull request.
> @@ -0,0 +1,22 @@
+module Api
+ class NoteSubscriptionsController < ApiController
+before_action :check_api_writable
+before_action :authorize
+
+authorize_resource
+
+def create
+ note_id = params[:note_id].to_i
+ note = Not
Merged #5319 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5319#event-15287858004
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5318#issuecomment-247660
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5293 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5293#event-15287901924
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5318 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5318#event-15287858031
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5319#issuecomment-2474448453
You are receiving this because you are subscribed to this thread.
Message ID:
___
This comes up repeatedly, and so let's document it.
New users are encouraged by Github to read the CONTRIBUTING file, so that's
where it's worth putting it. The explanation of why can be put elsewhere.
You can view, comment on, or merge this pull request online at:
https://github.com/openst
@tomhughes commented on this pull request.
I think my main question here is whether we should start these (mostly)
expanded or whether they should all be collapsed? Starting them expanded does
mean that you're using more vertical space and reducing what top level
information can be seen initial
Merged #5158 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5158#event-15286886750
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5158#issuecomment-2474282814
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
This PR combines a few minor changes to the docs that I noticed while working
on #5318
* Add missing top-level headers to two files
* Standardise on fenced code blocks in markdown, for consistency and to allow
language declarations
* Use language declarations for yaml code blocks
I also consid
Merged #5312 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5312#event-15286583665
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5315 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5315#event-15286583623
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5316 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5316#event-15286583627
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Nice catch, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5316#issuecomment-2474228725
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Rebased now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5158#issuecomment-2474226694
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mai
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5315#issuecomment-2474226160
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes approved this pull request.
Looks good now, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5312#pullrequestreview-2433870147
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes pushed 1 commit.
5e26b33235bab027f25f98afb8db8980f3603b0b Switch vagrant to use Debian 12
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5158/files/1cf6f65a5eec461ebe268d7141e5c5cd444eb02f..5e26b33235bab027f25f98afb8db8980f3603b0b
You are receiving
Before:
After:
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/op
Needs rebasing, since it conflicts with the change in image to jammy that was
merged as part of #5070
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5158#issuecomment-2474076601
You are receiving this because you are subscribed
Merged #5295 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5295#event-15285613962
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5295#issuecomment-2474053821
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5303#issuecomment-2474049793
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev
Merged #5303 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5303#event-15285575074
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
https://github.com/openstreetmap/openstreetmap-website/commit/51dcf86f40200bf4728097868f45aa2fe12968f3
added the "removenote" timer. Its use was removed in
https://github.com/openstreetmap/openstreetmap-website/commit/d380ce79aabcd98ade3eabe8f982e516311f6aee
but the `stopTime` cleanup stuck.
You
Hi @gravitystorm,
Thanks for trying it and for your feedback, very interesting.
Loading all the tables at first is a real issue as it's often overwhelming,
even in your case with 52 tables. I also have an issue on my side as the
auto-layout algorithm I use is not very good :sweat_smile:
And you
There's a button or something somewhere you can click to turn on the
automatically detected relationships but I admit it confused me as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5308#issuecomment-2473466329
You are rec
It needed a slight tweak to the view because when the form is rerendered on a
failed login the parameter on the redirect comes from the session so now has a
different value. It should be fixed now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
Similarly to #5307, we can avoid scheduling/unscheduling js events to show
spinners in the richtext preview #5311 and the sidebar loader:
There's a delay to avoid blinking on fast loads, that delay can be
@tomhughes pushed 1 commit.
a42b6546060227fce391c54557d7383f0291f410 Make the "remember me" option work as
intended
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5303/files/035e996ab9609c3828bb5c1b1552c42e27fcd662..a42b6546060227fce391c54557d7383f0291f410
Yo
Thanks @loicknuchel for your suggestion.
I've tried using it, and it looks great. But when I've tried using it used it a
couple of times, I haven't found it very useful, and I give up after a minute
or two. I think the main issue is that it doesn't load all the tables at the
start, so you can e
There's the integration tests that are now failing but it's not clear to me
what's going wrong with them.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5303#issuecomment-2473275552
You are receiving this because you are subscrib
45 matches
Mail list logo
