Part 4 of #5283
Adds API endpoints to subscribe/unsubscribe from a note.
This is like the changeset subscribe/unsubscribe
https://wiki.openstreetmap.org/wiki/API_v0.6#Subscribe:_POST_/api/0.6/changeset/#id/subscribe
but since we like resourceful routes, instead of `POST .../subscribe` and `POST
@AntonKhorev pushed 3 commits.
3ecf7943b36836b9f0337aa9d7c8f48992293ae8 Add create note subscription api
endpoint
bc8c005d6186c56054fc68d8281e67ba8efb76cc Add destroy note subscription api
endpoint
98a287457e6742a9e625f66b7acbdb8898304737 Add subscribe/unsubscribe buttons to
note pages
--
@AntonKhorev commented on this pull request.
> + get user_block_path(block)
+ assert_response :success
+ block.reload
+ assert_not block.needs_view
+ assert_equal Time.now.utc - 1.hour, block.deactivates_at
+end
+ end
+
+ ##
+ # test clearing needs_view by showing
@AntonKhorev pushed 1 commit.
ff0569829f81f868e054e6430eaf11bf779d1213 Don't update deactivates_at if block
was already viewed
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5312/files/f4208862bc1841dc18aa55ce85acad349b6f2b43..ff0569829f81f868e054e6430eaf11bf
Merged #5310 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5310#event-15269649013
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5311 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5311#event-15269649010
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5310#issuecomment-2471333468
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5311#issuecomment-2471323757
You are receiving this because you are subscribed to this thread.
Message ID:
___
@tomhughes requested changes on this pull request.
> + get user_block_path(block)
+ assert_response :success
+ block.reload
+ assert_not block.needs_view
+ assert_equal Time.now.utc - 1.hour, block.deactivates_at
+end
+ end
+
+ ##
+ # test clearing needs_view by s
The version lock is from 41f13ac73a740b16bce708b23db8b2cdb6d24d1f and it seems
our bootstrap is still too old to avoid the warnings.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5313#issuecomment-2471155482
You are receiving
Ah it has already been changed in `dartsass-sprockets` but we have a version
lock on `sass-embedded` which is stopping it from updating.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5313#issuecomment-2471150961
You are receiv
We are currently using `dartsass-ruby` as a dependency of `dartsass-sprockets`
but v1.x of the `uri` gem has an ABI change which breaks it:
```
bin/rails aborted!
ArgumentError: wrong number of arguments (given 1, expected 0) (ArgumentError)
/home/tom/.bundle/ruby/3.3.0/gems/uri-1.0.1/lib/uri/rfc
12 matches
Mail list logo
