When a blocked user visits their block page, its deactivation time is recorded.
Problem is this only needs to happen if there's no deactivation time set.
If it's already set, it should be kept at what it is.
The possible bug is that if the user visits their block page after the block is
lifted,
I wouldn't try to do a comma-separated list
> UserA, UserBB, UserC
I'd write them each on a new line and add truncation
> UserA
> UserB...
> UserC
And if there's more than say 3, write something like
> UserA
> UserB...
> UserC
> and 2 more users
--
Reply to t
I don't think tooltips were a good idea. You can't interact with the
usernames they show. And truncation works fine for individual names, but then
you'd have to do it inside the tooltip too. Do you want to make html
tooltips? And then there's Turbo cleanup.
.
Go ahead, get familiar to the code base and work on this if you like.
If you solve this. Hurray!
--
Reply to this email directly or view
@AntonKhorev commented on this pull request.
> @@ -178,6 +220,42 @@ $(document).ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+c
@AntonKhorev commented on this pull request.
> +
+<%= t ".location_name_warning" %>
+
+
This looks like a sentence and it's not obvious that it ends with a button I'm
supposed to click to update the value:
.ready(function () {
}
}
+ function updateHomeLocation() {
+const lat = $("#home_lat").val().trim();
+const lon = $("#home_lon").val().trim();
+if (!lat || !lon) {
+ return;
+}
+
+c
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,22 @@
+require "application_system_test_case"
+
+class UserLocationChangeTest < ApplicationSystemTestCase
+ def setup
+stub_request(:get, /.*gravatar.com.*d=404/).to_return(:status => 404)
+ end
+
+ test "User can change their loca
@AntonKhorev commented on this pull request.
> + def truncate_html(html, max_length, empty_tag_length = 500)
+doc = Nokogiri::HTML::DocumentFragment.parse(html)
+accumulated_length = 0
+truncated_node = nil
+
+doc.traverse do |node|
+ if accumulated_length >= max_length
+
@AntonKhorev commented on this pull request.
> @@ -2,7 +2,7 @@
<%= render :partial => "diary_entry_heading", :object => diary_entry, :as =>
"diary_entry" %>
-<%= diary_entry.body.to_html %>
+<%= truncated ? diary_entry.truncated_body(1000).to_html :
diary_entry.body.to_html %>
Closed #1383.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1383#event-15248161987
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@tguen / @gravitystorm / @lonvia : I will work on this issue, please assign
this to me
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2467631435
You are receiving this because you are subscribed to this thre
12 matches
Mail list logo
