Re: [openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

Increased to 1500ms. Javascript event listeners run in the same thread with everything else including getting query results over the net. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5307#issuecomment-2463985792 You are receiv

Re: [openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

@AntonKhorev pushed 1 commit. 771b75ed71198811a6661a146e3376f0489771d8 Replace query marker fade animation with css -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5307/files/4613119cb42a2197960a99aa3546a6ca9b9e354f..771b75ed71198811a6661a146e3376f0489771d8 Yo

Re: [openstreetmap/openstreetmap-website] Backfill note subscriptions (PR #5304)

@AntonKhorev commented on this pull request. > @@ -0,0 +1,14 @@ +class BackfillNoteSubscriptions < ActiveRecord::Migration[7.2] + class NoteComment < ApplicationRecord; end + class NoteSubscription < ApplicationRecord; end + + disable_ddl_transaction! + + def up +NoteComment.in_batches(:

Re: [openstreetmap/openstreetmap-website] Backfill note subscriptions (PR #5304)

@AntonKhorev pushed 1 commit. c848a88240a627711635627d03fbd4ef90955c93 Backfill note subscriptions -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5304/files/e1d3074c9a79200123a6247a0f04b0239baf07aa..c848a88240a627711635627d03fbd4ef90955c93 You are receiving th

Re: [openstreetmap/openstreetmap-website] Better database discovery (PR #5308)

Hi @HolgerJeromin Thanks for the quick feedback, indeed there is a redirect once the project is loaded. This is not just this screen but a dynamic app to explore your database. You can click on suggested tables or search on the top left bar to display tables and follow relations. Here is an exa

Re: [openstreetmap/openstreetmap-website] Remove hardcoded rate limit value. Fixes #4427 (PR #4464)

Merged #4464 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4464#event-15189816711 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Remove hardcoded rate limit value. Fixes #4427 (PR #4464)

@tomhughes approved this pull request. Apologies for the long delay in looking at this again. Having now done so it seems I probably misunderstood what was going on before and my suggestion to move the setting was completely wrong and my suggested named wasn't ideal either. Rather than bother

Re: [openstreetmap/openstreetmap-website] Hardcoded rate limit value leads to slow tests (Issue #4427)

Closed #4427 as completed via 2d8feb6d79af2e96d83cf67ca0771116c9c0f11a. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4427#event-15189816723 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] Remove hardcoded rate limit value. Fixes #4427 (PR #4464)

@tomhughes pushed 1 commit. 2d8feb6d79af2e96d83cf67ca0771116c9c0f11a Remove hardcoded rate limit value -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4464/files/ecfeb87cef0710559d4fc6f8b9560e827ea79780..2d8feb6d79af2e96d83cf67ca0771116c9c0f11a You are receivin

Re: [openstreetmap/openstreetmap-website] Some developers will need to upgrade their rubygems (Issue #4364)

@gravitystorm thank you from troubleshooting internet land. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/4364#issuecomment-2462944861 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

@tomhughes commented on this pull request. This is great, but despite the time being set the same it definitely seems to run faster to me? It's hard to actually time it but it seems like it might be close to twice as fast maybe because the javascript introduces extra delays running the function

Re: [openstreetmap/openstreetmap-website] Backfill note subscriptions (PR #5304)

@tomhughes commented on this pull request. > @@ -0,0 +1,14 @@ +class BackfillNoteSubscriptions < ActiveRecord::Migration[7.2] + class NoteComment < ApplicationRecord; end + class NoteSubscription < ApplicationRecord; end + + disable_ddl_transaction! + + def up +NoteComment.in_batches(:of

Re: [openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

> This is one of the excuses why hiding/deleting changeset tags wasn't done before. I'd call it a 'good reason', not an 'excuse'. Having a user interface to remove or edit tags is straightforward, but making sure the updates are properly replicated is required too. -- Reply to this email di

Re: [openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

> The big question for me is how updates are propagated to the changeset replication feed This is one of the excuses why hiding/deleting changeset tags wasn't done before. There are others such as we don't have changeset versions to store previous set of tags. If the feed is generated by [th

Re: [openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

@AntonKhorev pushed 2 commits. e75ba668a10b73c4d1b0db91b6677f964b82c42a Use base64 encoding to support arbitrary tag keys 1e76290d42953a57335a0f138ce26e2be0396014 Handle incorrectly encoded tag keys -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5309/files/9

Re: [openstreetmap/openstreetmap-website] Better database discovery (PR #5308)

I get a redirect from https://azimutt.app/create?sql=https://raw.githubusercontent.com/openstreetmap/openstreetmap-website/refs/heads/master/db/structure.sql&name=OpenStreetMap to https://azimutt.app/----/---- which is not helpful..

Re: [openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

The big question for me is how updates are propagated to the changeset replication feed. Otherwise if you delete tags on the website, they will still be shown in all systems that consume the feed. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreet

Re: [openstreetmap/openstreetmap-website] Better database discovery (PR #5308)

I added a documentation page to demonstrate it and explain how it works: https://azimutt.app/docs/badge Let me know if I should still improve it. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5308#issuecomment-2462587322 You ar

[openstreetmap/openstreetmap-website] Delete changeset tags (PR #5309)

Lets moderators delete changeset tags You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5309 -- Commit Summary -- * Add blank page for managing changeset tags * Add 'not found' page for managing changeset tags * Ad

[openstreetmap/openstreetmap-website] Better database discovery (PR #5308)

Hi, I'm the creator of Azimutt and just made a way to open any database structure file in one click, allowing anyone to understand it more easily. It can be [added with a badge](https://github.com/azimuttapp/azimutt#azimutt-badge), so here is my contribution in making your project even more ap

Re: [openstreetmap/openstreetmap-website] Dark Mode (#2332)

Great work, thank you. I will take a look at PRs mentioned, in the meantime if you need help with any of these I'm happy to jump in. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/2332#issuecomment-2461750909 You are receivin

Re: [openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

@AntonKhorev pushed 1 commit. 4613119cb42a2197960a99aa3546a6ca9b9e354f Replace query marker fade animation with css -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5307/files/ececb8bcdbc42ed9827eac8abe9022d25e5ae01d..4613119cb42a2197960a99aa3546a6ca9b9e354f Yo

Re: [openstreetmap/openstreetmap-website] Dark Mode (#2332)

> I believe we can implement them with minimal code adjustments. #4761 > Tables could benefit from some additional styling adjustments to better align with the overall UI appearance in dark mode. I’d be happy to dive deeper into this and prepare a PR. Here’s how the notes table currently appea

Re: [openstreetmap/openstreetmap-website] Dark Mode (#2332)

I've been exploring these updates, and with Bootstrap 5.3 now in use, I believe we can implement them with minimal code adjustments. > - **Refactor the background color for `content-heading` to use theme colors instead of a standard color variable** This seems to be working fine locally, so I

[openstreetmap/openstreetmap-website] Replace query marker fade animation with css (PR #5307)

Fixes #5305. Currently query markers are animated using javascript which requires managing timed events. We don't do it correctly, we don't cancel them when markers are removed. That's why #5305 happens. This PR replaces the javascript animation with the css which doesn't require any event han