Re: [openstreetmap/openstreetmap-website] Add status filter to user's note page (PR #5297)

2024-11-05 Thread Tom Hughes via rails-dev
@tomhughes requested changes on this pull request. In addition to the inline comment this could do with tests at the controller or system level rather than just testing the model method. > @@ -34,6 +34,16 @@ class Note < ApplicationRecord scope :visible, -> { where.not(:status => "hidden")

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-05 Thread Tom Hughes via rails-dev
This seems like an awful lot of complication... It seems to me that we have the option of either allowing the user to input freetext, or of generating something from the location with Nominatim but this tries to do both at once which just makes things very complicated and probably quite confus

[openstreetmap/openstreetmap-website] Make the "remember me" option work as intended (PR #5303)

2024-11-05 Thread Tom Hughes via rails-dev
The "remember me" checkbox has not been working properly, or rather it has been treated as checked even when it isn't. The reason is the "Gotcha" details in the [check_box documentation](https://api.rubyonrails.org/classes/ActionView/Helpers/FormBuilder.html#method-i-check_box) which means that

Re: [openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-05 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda Add profile location -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5302/files/d20e90d5a8e55b94805cbe21c3c0633ddea36cc6..e5de62853b9ff5e5bb99572d38a2f5d1c0a37eda You are receiving this because yo

[openstreetmap/openstreetmap-website] Add profile location (PR #5302)

2024-11-05 Thread David Tsiklauri via rails-dev
PR adds location name info on the user profile page. Location name can be changed from "Edit Profile" page either by manual typing or auto-filling according to the home location. One column was added to the user table to save user's location. JS logics are responsible for handling: 1) Delete-Und