@kcne pushed 1 commit.
5670d46dfbe671499bfe593b555939bb7e3aaf43 Add status filter to user's note page
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5297/files/0b7d8b8711567f8a952e8c7c805faf911aa981f6..5670d46dfbe671499bfe593b555939bb7e3aaf43
You are receiving
### Description
This PR partly addresses #832 and serves as a smaller alternative to #5255 as
suggested in comments. It aims to enhance user experience on user note pages by
providing filtering functionality for notes by status. The `with_status` scope
is added to the `Note` model, and the `Note
@tomhughes commented on this pull request.
> @@ -401,6 +401,8 @@ def add_comment(note, text, event, notify: true)
note.comments.map(&:author).uniq.each do |user|
UserMailer.note_comment_notification(comment, user).deliver_later if
notify && user && user != current_user && user.v
Merged #5296 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5296#event-15014807245
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@nenad-vujicic : this might be a good topic for another rule in Dangerfile.
Something like:
```
gemfile_modified = git.modified_files.include?("Gemfile")
gemfile_lock_modified = git.modified_files.include?("Gemfile.lock")
if gemfile_modified && !gemfile_lock_modified
warn("Gemfile was updated,
That should be fixed now...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5295#issuecomment-2447468574
You are receiving this because you are subscribed to this thread.
Message ID:
__
@tomhughes pushed 1 commit.
356738e5c502b6907864ac1f0fed235780c0 Create base and head branches before
running danger
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5295/files/c4be01e3fb7a32342ee449816ba3f5e7baaa8009..356738e5c502b6907864ac1f0fed235780
Gemfile.lock update seems to be missing in the PR...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5295#issuecomment-2447300140
You are receiving this because you are subscribed to this thread.
Message ID:
_