@AntonKhorev pushed 1 commit.
b24d52d5ca30e081ec799880bee6bc32616ad8fa Use resourceful routes for
granting/revoking user roles
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5293/files/19da04fa8eb0ce3d665123048f6cb1f62058c369..b24d52d5ca30e081ec799880bee6bc32
Replaces:
- `post grant_role_path` with `put user_role_path`
- `post revoke_role_path` with `delete user_role_path`
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5293
-- Commit Summary --
* Use resourceful routes f
@AntonKhorev commented on this pull request.
> @@ -401,6 +401,8 @@ def add_comment(note, text, event, notify: true)
note.comments.map(&:author).uniq.each do |user|
UserMailer.note_comment_notification(comment, user).deliver_later if
notify && user && user != current_user && user
@tomhughes commented on this pull request.
> @@ -401,6 +401,8 @@ def add_comment(note, text, event, notify: true)
note.comments.map(&:author).uniq.each do |user|
UserMailer.note_comment_notification(comment, user).deliver_later if
notify && user && user != current_user && user.v
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
@AntonKhorev pushed 1 commit.
cc319be3414e2d2b94cb10c871cc66b541d87a08 Remove classic pagination
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5205/files/45bbc3bbc6c615cb2509e08e36de018fabf987fe..cc319be3414e2d2b94cb10c871cc66b541d87a08
You are receiving this
@AntonKhorev pushed 1 commit.
837aeea405129719503141350d8b669c03cbd4a3 Replace submitted note table color
with created/resolved
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5269/files/7aeafbd890108734b866df1eaac8ef9b595d5cab..837aeea405129719503141350d8b669
@AntonKhorev pushed 1 commit.
b3f930095408c7678cbd000f6f125463ed462f02 Use system font on error pages
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5277/files/733e160872dfe92230645eb6e7e8f1cf9d221597..b3f930095408c7678cbd000f6f125463ed462f02
You are receiving
@AntonKhorev pushed 1 commit.
0c237c11d2c4b19d1a14324adbb7ca275c554816 Display old node versions on map view
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5278/files/55794cf4cbe16d0b359da647e1a53bdd390a53dd..0c237c11d2c4b19d1a14324adbb7ca275c554816
You are re
@AntonKhorev pushed 2 commits.
001fed4fd7d321a079568f5de9479adfbff21778 Create note subscription table and
model
2d7e0a397a1b2dbed74f40439c1305b1b48a063e Subscribe users when they interact
with notes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5284/files
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
@AntonKhorev pushed 7 commits.
e60511f711f36dd87cc8d49cedaec97241db6dbe Create note subscription table and
model
9fb8291c9cca0aa97af992c20bd9a908f1a31b3d Subscribe users when they interact
with notes
26c426b968f2e80f9845300458d5c15b85a158d6 Backfill note subscriptions
cba78ed1105c056a38a1232a
@AntonKhorev commented on this pull request.
> @@ -401,6 +401,8 @@ def add_comment(note, text, event, notify: true)
note.comments.map(&:author).uniq.each do |user|
UserMailer.note_comment_notification(comment, user).deliver_later if
notify && user && user != current_user && user
@AntonKhorev commented on this pull request.
> +end
+ end
+ assert_response :success
+ js = ActiveSupport::JSON.decode(@response.body)
+ assert_not_nil js
+ assert_equal "Feature", js["type"]
+ assert_equal "Point", js["geometry"]["type"]
+ assert_equal
@AntonKhorev commented on this pull request.
> @@ -12,5 +15,33 @@ def show
rescue ActiveRecord::RecordNotFound
raise OSM::APINotFoundError
end
+
+def create
+ raise OSM::APIBadUserInput, "No user was given" unless params[:user]
+
+ user = User.visible.find_by(:id =
_I'm moving the discussion from #5290 over to this issue..._
I had some issues with danger not being able to correctly process #5080. I can
also reproduce the issue in the danger test repo:
https://github.com/openstreetmap/danger-test/pull/5
--
Reply to this email directly or view it on Gi
1 Warning
:warning:
Number of updated lines of code is too large to
be in one PR. Perhaps it should be separated into two or more?
Generated by :no_entry_sign: https://danger.systems/";>Danger
--
Reply to this e
Danger starts failing once the PR has >= 20 commits:
https://github.com/openstreetmap/danger-test/pull/6
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2440147247
You are receiving this because you are subscri
Well that's interesting because
https://github.com/danger/danger/blob/53ebd6415175ac7611b8605d5c8d20905268404c/lib/danger/scm_source/git_repo.rb#L85-L91
is the key code and that is supposed to try four passes.
The first pass looks at a depth of 20 but if that fails it should retry to 74,
222 an
Could it be that danger is checking a certain number of commits by default
only? I tried adding one commit at a time in
https://github.com/openstreetmap/danger-test/pull/6, and it worked at least up
to 15 commits. The failing PR had 20 commits.
--
Reply to this email directly or view it on Git
Closing because #3715 supersedes this PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1189#issuecomment-2440125883
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #1189.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1189#event-14929561553
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
@mmd-osm pushed 1 commit.
961a16749ab89769c97d167396dcaa077e530f25 Using osm.org as identity provider
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5071/files/5b61d54da9b213474b301b18653b007429e9cbdc..961a16749ab89769c97d167396dcaa077e530f25
You are receiving
@mmd-osm pushed 1 commit.
7f643077ca62fc39714967d9315be8e83f905c94 Trace import: remove
activerecord-import gem
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/6a22d04098506f62609998599256b423bea0f9e9..7f643077ca62fc39714967d9315be8e83f905c94
You ar
I tried another pull request #5270, and here it seems to be working fine. The
only obvious difference I can spot is that #5080 has a lot more commits.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2440106153
Yo
@mmd-osm pushed 1 commit.
0d4d86e0820910d527f1be0364f62e3a767bc3e7 Unauthenticated session expiry
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/429cb593fccb03360b4c140be0782621708a14bf..0d4d86e0820910d527f1be0364f62e3a767bc3e7
You are receiving thi
I think there's still an issue... I did a rebase on master + force push. Danger
is still failing:
https://github.com/openstreetmap/openstreetmap-website/pull/5080
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-
Merged #5290 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#event-14924210846
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@mmd-osm pushed 20 commits.
88255573de25e59f6ae4d95544478dbdbcce02a7 Browse icons as svg
f484f93b8a82c931e1f4b971f2faa848f239e67b Visibility improvements for dark mode
c2e6dc276384c311fd89c17401560997c443ae99 Fine tune position of 9 svg symbols
81f6f5eeeb1c1283165535d5310bab693be5b335 Replaced
@gravitystorm commented on this pull request.
> +end
+ end
+ assert_response :success
+ js = ActiveSupport::JSON.decode(@response.body)
+ assert_not_nil js
+ assert_equal "Feature", js["type"]
+ assert_equal "Point", js["geometry"]["type"]
+ assert_equa
Thanks for all your work getting to the bottom of this problem!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2439997607
You are receiving this because you are subscribed to this thread.
Message ID:
__
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5292#issuecomment-2439937586
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5291 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5291#event-14922059588
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5292 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5292#event-14922059585
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5291#issuecomment-2439937447
You are receiving this because you are subscribed to this thread.
Message ID:
___
Odd, other times what looks straight on the map is detected as a fork, so the
bug of assuming it is the same road is avoided.
https://www.openstreetmap.org/directions?engine=fossgis_valhalla_car&route=24.153800%2C120.733500%3B24.157770%2C120.733740
--
Reply to this email directly or view it on
36 matches
Mail list logo
