I just clicked the wrong button by mistake :)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5292#issuecomment-2439627665
You are receiving this because you are subscribed to this thread.
Message ID:
Most strings used single quotes, and a few used
opening backticks. Now it's single quotes everywhere.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5291
-- Commit Summary --
* Consistent use of quotes
-- File Chan
Reopened #5292.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5292#event-14906361286
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailin
Closed #5292.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5292#event-14906082387
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
Quick comment: you would also need to change a few unit tests with the same
issue:
- test/controllers/user_roles_controller_test.rb:74
- test/controllers/user_roles_controller_test.rb:134
- test/controllers/messages_controller_test.rb:248
- test/controllers/messages_controller_test.rb:305
Can yo
You don't need to close the PR and open a new one to make changes - just update
your branch and force push it and the PR will pick up the changes,
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5292#issuecomment-2439625134
You ar
@amire80 pushed 1 commit.
0d650217f4e805d7d40314bd471be0e53f0fde29 Consistent use of quotes
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5291/files/6e6cfa062ba87e3bd0cf83b0cc975f0b2e00..0d650217f4e805d7d40314bd471be0e53f0fde29
You are receiving this beca
There are articles before "ramp" everywhere,
and it sounds more correct with articles
before "exit" and "roundabout", too.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5292
-- Commit Summary --
* Add articles befo
Ah sorry... I cherry picked and forgot I had updated the danger branch since.
Now fixed.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2439549811
You are receiving this because you are subscribed to this thread
This gets the danger workflow working by switching to my fixed version (current
open upstream as https://github.com/danger/danger/pull/1501) and also tweaks a
few other things:
* Renames the workflow to reflect that this is not just about labelling
* Drops the `run-name` so that he runs will be
Looks good now. The danger failure is expected, you can't test any changes to
Danger with a cross repo PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5290#issuecomment-2439551743
You are receiving this because you are subscri
@tomhughes pushed 3 commits.
754e811b70aa309b080e102ed629672f1558866b Get danger working in GitHub actions
8e566b0bff66e23389a6fb1c7458696c8e06faf1 Avoid suggesting danger is only about
labels
67749e75347ee7ae94ba6f6929846389d8e12118 Make danger labels use consisent
capitalisation
--
View i
It seems you need to update the commit hash in Gemfile.lock. This works for me:
```
diff --git a/Gemfile.lock b/Gemfile.lock
index 346af2baa..d1bf08281 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -8,7 +8,7 @@ GIT
GIT
remote: https://github.com/tomhughes/danger.git
- revision: 5794971ade
Merged #5288 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5288#event-14900309160
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5286 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5286#event-14900309148
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5289 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5289#event-14900309139
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
@tomhughes commented on this pull request.
> @@ -401,6 +401,8 @@ def add_comment(note, text, event, notify: true)
note.comments.map(&:author).uniq.each do |user|
UserMailer.note_comment_notification(comment, user).deliver_later if
notify && user && user != current_user && user.v
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5289#issuecomment-2439476251
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5288#issuecomment-2439475223
You are receiving this because you are subscribed to this thread.
Message ID:
___
19 matches
Mail list logo
