Re: [openstreetmap/openstreetmap-website] GPX email shouldn't say "Import", it should just say "Upload" (Issue #5272)

2024-10-19 Thread 積丹尼 Dan Jacobson via rails-dev
Actually even though the files say they were exported by ... they should also say "DO NOT EDIT". As far as reading guidelines, yes, but we are often taken to the certain spot via a search, so don't remember to read the guidelines. Anyway I recall that after cleaning up the GPX Success message, t

Re: [openstreetmap/openstreetmap-website] Browse node version coordinates (PR #4930)

2024-10-19 Thread 積丹尼 Dan Jacobson via rails-dev
Hmm, Wikipedia also allows one to link to any exact version of anything. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/4930#issuecomment-2424285222 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)

2024-10-19 Thread Anton Khorev via rails-dev
Alright, let's not think about filtering for now. Changed to look only at the last close event. I also wanted the "commented" indication not to be misleading. It includes more than commenting and this change stretches it further by including non-last close events. So I removed the claim that no

Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)

2024-10-19 Thread Anton Khorev via rails-dev
@AntonKhorev pushed 1 commit. 7aeafbd890108734b866df1eaac8ef9b595d5cab Replace submitted note table color with created/resolved -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5269/files/4f4212abd012e1c89b5a5c20ebe5459d7dd80101..7aeafbd890108734b866df1eaac8ef9

Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)

2024-10-19 Thread Tom Hughes via rails-dev
My thinking was literally just to look at the last event which should be the close event unless it's been reopened and if it has then do we want to consider it closed by this user? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/

Re: [openstreetmap/openstreetmap-website] Replace submitted note table colors with created/resolved (PR #5269)

2024-10-19 Thread Anton Khorev via rails-dev
There are some drawbacks in looking only at the last close event. #5255 tried to do filtering by interaction type but the db queries are ugly. To optimize them we could have a users x notes table where we store among other things interaction flags. When a user closed a note, we set a closed flag

Re: [openstreetmap/openstreetmap-website] Share button should preserve the node/way/relation id when creating the URL (Issue #5252)

2024-10-19 Thread Anton Khorev via rails-dev
We could have links to specific versions of elements that don't change but even the actual osm website can't show them currently. There is a pull request for nodes though #4930. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5

Re: [openstreetmap/openstreetmap-website] Add devcontainer configuration (Issue #5264)

2024-10-19 Thread mmd via rails-dev
Thanks, this looks like a great suggestion. I gave it a try, created a new clone of the repo, then added a new devcontainer using `bundle exec rails container.` Initially I was a bit struggling with (Debian, Rails, npm) packages on generated devcontainer. I believe we can probably reuse a lot o

[openstreetmap/openstreetmap-website] GPX email shouldn't say "Import", it should just say "Upload" (Issue #5272)

2024-10-19 Thread 積丹尼 Dan Jacobson via rails-dev
### Problem https://wiki.openstreetmap.org/wiki/Import says > Unlike editing the map or **uploading GPX traces**, importing combines > > an existing dataset with the OSM dataset and thus typically includes a >

Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)

2024-10-19 Thread mmd via rails-dev
@mmd-osm pushed 1 commit. 23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd Danger test -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/9608220336e83cafc6774e1f5637b61d4f678357..23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd You are receiving this because you are s

Re: [openstreetmap/openstreetmap-website] Unauthenticated session expiry (PR #5270)

2024-10-19 Thread mmd via rails-dev
@mmd-osm pushed 0 commits. -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/23d3f6b8701512312a4f2fba2dbeaa8baa7b37bd..9608220336e83cafc6774e1f5637b61d4f678357 You are receiving this because you are subscribed to this thread. Message ID:

Re: [openstreetmap/openstreetmap-website] GPX email shouldn't say "Import", it should just say "Upload" (Issue #5272)

2024-10-19 Thread mmd via rails-dev
> I messed up https://github.com/openstreetmap/openstreetmap-website/pull/5257 > so I'll just open an issue instead. You’ve only changed the wrong file, just do your changes in en.yml instead… -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-w