Very good question. And I think the answer should be just the map only never
mind the sidebar. Because the person doing the in bed should be responsible for
putting the words they want in their own caption for their picture.
For instance I select that road but the OSM way number of that road is
I haven’t checked the code before. They’re using it in their own Dangerfile to
control junit reporting. So it’s really irrelevant for us:
https://github.com/danger/danger/blob/cd913ea817a2fb9536172597303d78492a727668/Dangerfile#L56
--
Reply to this email directly or view it on GitHub:
https://g
Because it serves no purpose - nothing in the danger code ever looks at that.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2421502966
You are receiving this because you are subscribed to this thread.
Message
@mmd-osm pushed 1 commit.
9608220336e83cafc6774e1f5637b61d4f678357 Unauthenticated session expiry
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5270/files/f99b2ad1b82554dbd3a799a7c53fab4f53f7146b..9608220336e83cafc6774e1f5637b61d4f678357
You are receiving thi
Follow up for https://github.com/openstreetmap/operations/issues/1107
The goal of this PR is to set the `expiry_after` value for unauthenticated
users to a fairly low value (read: a few hours). This way, memcached entries
are no longer created with a TTL of 0 (unlimited).
Previously, logged one
I've just created a new PR, let's see how it goes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420157110
You are receiving this because you are subscribed to this thread.
Message ID:
_
Merged #5268 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5268#event-14703126042
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Let's see if
https://github.com/openstreetmap/openstreetmap-website/commit/6d0c2913326fbfdf3578416853e31d7a950d97ed
helps...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420131259
You are receiving this be
The automatic token should be fine if we do things right - no need to configure
a separate one.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420127660
You are receiving this because you are subscribed to th
I wouldn't use my own account to create the token, and rather create some new
"OSM Danger Bot" GH account. You could also keep that token secret and
reference it by variable name only.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/i
Yes but having seen how they configure their own secret I'm not trusting them
to tell me how to do it! Working on a proper solution now...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420114844
You are rece
One of the links I've posted mentioned "public_repo" scope, that's read only
access to public repos.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420107906
You are receiving this because you are subscribed
You say you ignore reopen events but in fact this seems to extend the concept
of submitted/created from who initially opened it to include anybody that
reopens it as well? You are considered to have created it if there are any open
events by you.
Obviously that is mirrored in terms of closing b
No we don't have an enterprise account. What permissions exactly will the token
need?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5267#issuecomment-2420066507
You are receiving this because you are subscribed to this thread.
> ...
> Run bundle exec danger --verbose
> To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
> To use multipart middleware with Faraday v2.0+, install `faraday-multipart`
> gem; note: this is used by the ManageGHES client for uploading licenses
> fatal: couldn't find remote r
@AntonKhorev commented on this pull request.
> + <% Locale.available
+ .map { |locale| Language.find_by(:code => locale.to_s) }
+ .select { |locale| locale }
+ .sort_by { |locale| locale[:english_name] }
+ .each do |language| %>
+
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,16 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Locale.available
+ .map { |locale| Language.find_by(:code => locale.to_s) }
You'll get a ton of db queries:
```
Language Load (0.2ms) SELECT "languages".* F
Instead of *submitted* and *commented* note colors switch to *created*,
*resolved* and *commented*.
Reasons:
- Close actions were colored as *commented* even if notes were closed without
any comments. Now they are going to be colored as *resolved*.
- *Submitted* is not a term we use for notes, w
Besides the [double-join db
query](https://github.com/openstreetmap/openstreetmap-website/pull/5255#discussion_r1801064970),
there's couple more issues with the interaction type: ["blue on blue"
colors](https://github.com/openstreetmap/openstreetmap-website/pull/4700#issuecomment-2221682594)
an
> On a side note, I’ve managed to implement sortable columns on a table UI end
> for created_at and updated_at locally
I looked again at why similar things were rejected in the past like #1656 and
there doesn't seem to be any clear reason.
--
Reply to this email directly or view it on GitHub:
@AntonKhorev commented on this pull request.
> @@ -6,41 +7,69 @@
:commented => tag.span(t(".subheading_commented"), :class => "px-2
py-1 bg-body") %>
<% end %>
-<% if @notes.empty? %>
- <%= t ".no_notes" %>
+<%= form_tag(url_for("controller" => "notes", "action" => "index"), "me
> As for the next steps, I’m not sure whether it’s better to get this PR merged
> as is and refactor later when the notes move to standard pagination, or if we
> should address the pagination issue on user note pages first and then
> refactor this PR accordingly.
You can make a pull request tha
@nertc pushed 1 commit.
80708ff796458168ebb1060bcb16e07ecf2e6fb5 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/41cb49e6a084607132ed9818e9139925f924a19b..80708ff796458168ebb1060bcb16e07ecf2e6fb5
You are receiving this because you
@nertc pushed 1 commit.
41cb49e6a084607132ed9818e9139925f924a19b Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/f5754b8cd7e4c60add5abc9b7f7b247a1b77..41cb49e6a084607132ed9818e9139925f924a19b
You are receiving this because you
24 matches
Mail list logo
