[openstreetmap/openstreetmap-website] Remove Nomatim prefixes mention in contributors guide (PR #5260)

2024-10-14 Thread mmd via rails-dev
See https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2410282588 You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5260 -- Commit Summary -- * Remove Nomatim prefixes mention in contribut

Re: [openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-14 Thread Tom Hughes via rails-dev
It's only efficient if there's also an index on the columns in question and there's a limit to how many of those we want to add, and you also need uniqueness though that can be achieved by appending id to any other cursor field(s) to create a composite cursor. The whole point of moving to curso

Re: [openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-14 Thread Emin Kocan via rails-dev
Reopened #5259. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5259#event-14636898955 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev mail

Re: [openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-14 Thread Emin Kocan via rails-dev
You bring up a valid point about the limitations of cursor-based pagination with sorting. Cursor pagination works efficiently when sorting by a unique or sequential field (like `id`, `created_at`, or `updated_at`), but it breaks down when we try to sort by non-unique columns (e.g., `name`, `stat

Re: [openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-14 Thread Tom Hughes via rails-dev
Just to be clear my concerns are not about how the UI works, it's about the database queries being performed on the backend and whether they are safe/efficient. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5259#issuecomment-

Re: [openstreetmap/openstreetmap-website] Add Sorting with Turbo Pagination and Extend to Sortable Columns (Issue #5259)

2024-10-14 Thread Emin Kocan via rails-dev
Tom, I want to dig a bit deeper into this to explore limitations and what are some solid ways to approach this, after which I will reopen this again. I've read few blog posts where people use Turbo with [Stimulus](https://github.com/hotwired/stimulus) but I'm not sure if that would fit the bill

Re: [openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)

2024-10-14 Thread Sarah Hoffmann via rails-dev
Feel free to add new entries. And feel free to make a PR to get of this section in CONTRIBUTING.md. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5258#issuecomment-2410282588 You are receiving this because you are subscribed t