[openstreetmap/openstreetmap-website] use highway=busway instead of emergency=yes when determining feature type in query results (Issue #5258)

2024-10-12 Thread tguen via rails-dev
### Problem In query results, features with highway=busway and emergency=yes are listed only as "yes" in query results. For example, [this one](https://www.openstreetmap.org/way/334029996) shown below. ### Description _No response_ ### Screenshots ![busway](https://github.com/user-attachme

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 40c71f28be97ffcafb47058fd2590020fb8567a1 Enable eslint and fix eslint errors for osm_test.js -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5216/files/6a3a0e5c02a4e0c54d93414257b8e03fce33eb91..40c71f28be97ffcafb47058fd2590020fb8567a1 Yo

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne pushed 7 commits. 9266180344761718d4068dd62f78ef3a0169b8e1 Use teaspoon to run javascript tests 1c47363ae310ddf11760e64263ca763077a6d3bf Run javascript tests in CI 123c7d10a5e798e2379dfb04df4a22b1deface3c Selenium driver working on local 5c7b7383e71380d4189385c6d05430649e0e7496 Use chai

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne commented on this pull request. > @@ -144,6 +144,9 @@ gem "unicode-display_width" # Keep ruby 3.0 compatibility gem "multi_xml", "~> 0.6.0" +gem "teaspoon" +gem "teaspoon-mocha", "~> 2.3.3" Moved the gems to `group :development, :test` which made a bit more sense to me since running

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
> I suppose the issues listed below are a result of the changes in #5084. I > would simply fix the respective unit tests to re-align them with the current > implementation. > > ``` > 1) OSM .formatHash formats lat/lon/zoom params > Failure/Error: expected '#map=9/57.625/-3.685' to equal

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne commented on this pull request. > @@ -9,6 +9,13 @@ SET xmloption = content; SET client_min_messages = warning; SET row_security = off; +-- +-- Name: public; Type: SCHEMA; Schema: -; Owner: - +-- + +-- *not* creating schema, since initdb creates it + + Removed changes to this file in t

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 97540a304302822d27dffde3d0c843c616a65583 Enable eslint and fix eslint errors for osm_test.js -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5216/files/2306d56b1daeffa2dbecfed6adfff5e5378c4d5f..97540a304302822d27dffde3d0c843c616a65583 Yo

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 2306d56b1daeffa2dbecfed6adfff5e5378c4d5f Enable eslint and fix eslint errors for osm_test.js -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5216/files/9ca88734655f1836fcdc6455cdcdb9dba2535ec4..2306d56b1daeffa2dbecfed6adfff5e5378c4d5f Yo

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 9ca88734655f1836fcdc6455cdcdb9dba2535ec4 Enable eslint and fix eslint errors for osm_test.js -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5216/files/717a8dd4a4193c07a828dc1b92fc7020a0730006..9ca88734655f1836fcdc6455cdcdb9dba2535ec4 Yo

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. bc453f0bb14709adc3997f371c8e6121e7f6e3b3 Enable eslint and fix eslint errors for osm_test.js -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5216/files/7b7e6550ce7ccac73c075257cd71807858cb364d..bc453f0bb14709adc3997f371c8e6121e7f6e3b3 Yo

Re: [openstreetmap/openstreetmap-website] Re-enable JavaScript unit tests using Teaspoon (PR #5216)

2024-10-12 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 7b7e6550ce7ccac73c075257cd71807858cb364d Enable eslint and fix eslint errors for osm_test.js -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5216/files/91e8d556fe976b42a4aabfc594ac905304d37d3d..7b7e6550ce7ccac73c075257cd71807858cb364d Yo