Re: [openstreetmap/openstreetmap-website] Sorting and filtering notes on the profile[TEST RUN] (PR #5255)

2024-10-09 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 721f8d52810673783b48341ecfbb9b7305ae4134 Add tests to note controller and handle edge cases -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/e382dfa8eb4cfbf63d93645542142b98cb19f149..721f8d52810673783b48341ecfbb9b7305ae4134 You

Re: [openstreetmap/openstreetmap-website] Sorting and filtering notes on the profile[TEST RUN] (PR #5255)

2024-10-09 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. e382dfa8eb4cfbf63d93645542142b98cb19f149 Add tests to note controller and handle edge cases -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/63ca32725b6f808e2e5288573643facfcf10300e..e382dfa8eb4cfbf63d93645542142b98cb19f149 You

Re: [openstreetmap/openstreetmap-website] Update link for Austria data sources (PR #5254)

2024-10-09 Thread Tom Hughes via rails-dev
Merged #5254 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5254#event-14577286730 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Update link for Austria data sources (PR #5254)

2024-10-09 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5254#issuecomment-2402979576 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] update link for Austria data sources (Issue #5253)

2024-10-09 Thread Tom Hughes via rails-dev
Closed #5253 as completed via fb73d0770b68f1b6ed50fb40e9b4cd18d9638d65. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5253#event-14577286756 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [openstreetmap/openstreetmap-website] update link for Austria data sources (Issue #5253)

2024-10-09 Thread Tom Hughes via rails-dev
Yes I know, it just wasn't clear that this was an LWG decision/request given it said "it has been reported to" rather than saying that they had decided/agreed that it should be changed. I assume that was the intention though. -- Reply to this email directly or view it on GitHub: https://github.

Re: [openstreetmap/openstreetmap-website] Sorting and filtering notes on the profile[TEST RUN] (PR #5255)

2024-10-09 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 63ca32725b6f808e2e5288573643facfcf10300e Add test to controller and update scopes and filtering to handle edge cases -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/2e18a7cc7552c729dcc147e1391e286fca4d..63ca32725b6f808e2e5

Re: [openstreetmap/openstreetmap-website] Sorting and filtering notes on the profile[TEST RUN] (PR #5255)

2024-10-09 Thread Emin Kocan via rails-dev
@kcne pushed 1 commit. 2e18a7cc7552c729dcc147e1391e286fca4d Add test to controller and update scopes and filtering to handle edge cases -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5255/files/d8d40c10734f3012f854e8eedadc8ba92ee74656..2e18a7cc7552c72

[openstreetmap/openstreetmap-website] Sorting and filtering notes on the profile[TEST RUN] (PR #5255)

2024-10-09 Thread Emin Kocan via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5255 -- Commit Summary -- * Add filter and sort scopes to note model * Add tests for filtering and sort scopes inside note model * Integrate filtering and sorting

Re: [openstreetmap/openstreetmap-website] update link for Austria data sources (Issue #5253)

2024-10-09 Thread mmd via rails-dev
@kathleenlu09 is LWG member, that's why I created the PR right away. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5253#issuecomment-2402862923 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] update link for Austria data sources (Issue #5253)

2024-10-09 Thread Tom Hughes via rails-dev
As we explained in #4470 we're happy to change it if LWG are OK with that, given that the text as currently written is there to record a legally required attribution. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5253#issueco

[openstreetmap/openstreetmap-website] Update link for Austria data sources (PR #5254)

2024-10-09 Thread mmd via rails-dev
Fixes #5253. As requested by LWG. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5254 -- Commit Summary -- * Update link for Austria data sources -- File Changes -- M config/locales/en.yml (2) -- Patch Links