@grekko commented on this pull request.
> @@ -39,6 +49,10 @@ class Note < ApplicationRecord
DEFAULT_FRESHLY_CLOSED_LIMIT = 7.days
+ def comments_with_extra_open_comment
@gravitystorm I've updated the code for the Data-Migration to immediately
destroy the first comment as part of the mi
@grekko pushed 2 commits.
af64942a55b634e33292b9788f10d2de51a261d6 Rename MigrateOpenedComment ->
MigrateFirstComment
92c488e447fca6c1e4bd6f752f7a3c309eb9fd49 MigrateFirstComment should destroy
the first-comment when completing
--
View it on GitHub:
https://github.com/openstreetmap/openstree
### Problem
Check this magnificent genuine working link I created,
https://www.openstreetmap.org/way/579405035?mlat=24.181444&mlon=120.865815#map=16/24.181444/120.865815
It's packed with
1. a way
2. a zoom level
3. a screen center position
4. a marker
5. a (default) map layer
I can't think of muc
@grekko commented on this pull request.
> @@ -39,6 +49,10 @@ class Note < ApplicationRecord
DEFAULT_FRESHLY_CLOSED_LIMIT = 7.days
+ def comments_with_extra_open_comment
> The API can use the first two to make the legacy-first-comment.
Ah ok. You'd rather have the logic in the API contr
Looks like the languages you get from `Language` don't quite match the ones
expected by `Locale.list`. For example, we have `pt-BR` and `pt` in `Language`
but `pt` and `pt-PT` in translations. As a result you can't select European
Portuguese.
--
Reply to this email directly or view it on GitHu
Right, I had another issue in mind where you would see error messages in
whatever language that happens to be set previously. I can't find it at the
moment...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5251#issuecomment-23
Related issue for API error messages: #2227
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5251#issuecomment-2396664674
You are receiving this because you are subscribed to this thread.
Message ID:
Removed "Good" label and rebased again. Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4988#issuecomment-2396594928
You are receiving this because you are subscribed to this thread.
Message ID:
__
@nenad-vujicic pushed 1 commit.
e307b9037a05fb6ea0a8790cb6f6e0824781e949 Added workflow for PR labeling using
Danger
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4988/files/9dd7b1a24607511bb95c15953ff33d38c3ceedb1..e307b9037a05fb6ea0a8790cb6f6e0824781e949
Y
We probably need to review all the `lookup_user` calls and make sure they come
after `set_locale` and probably `web_timeout` as well though that's unlikely to
matter much.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5251#is
### URL
https://www.openstreetmap.org/user/Omaraltab/notes
### How to reproduce the issue?
Refreshing the URL occasionally returns the 404 page in an unexpected language.
https://github.com/openstreetmap/openstreetmap-website/blob/acd899d26dbf09620d598d74759fc6f7aac4846a/app/controllers/notes_c
updates the editor layer index again, this time addressing
https://github.com/openstreetmap/iD/issues/10486
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5250
-- Commit Summary --
* Update to iD v2.30.4
-- File C
@nertc commented on this pull request.
> @@ -0,0 +1,12 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Language.order(:english_name).each do |language| %>
+><%=
language.name %>
If there was not a cookie, none of the options would be preselected. But for
the better UX this
@nertc commented on this pull request.
> @@ -78,6 +78,15 @@
<%= link_to t("layouts.about"), about_path, :class =>
"dropdown-item" %>
+
+<% if current_user && current_user.id %>
+ <%= link_to(preferences_path, :class => "nav-link text-secondary
@grekko pushed 1 commit.
6726fe84d04128998906c53505bdacfd8ab2347c Merge branch 'master' into
notes_refactoring_2
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481/files/a40cd374235fc5d5792700c7de4a27f832e00d39..6726fe84d04128998906c53505bdacfd8ab2347c
You a
> If so, please mark this as a draft so that I don't get too keen and
> accidentally merge it
That's a good compromise for me. Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-2396212733
You are receiving
@nertc pushed 1 commit.
f5754b8cd7e4c60add5abc9b7f7b247a1b77 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/34d2e252b3c9fe2735ea607d43caea8b849613c5..f5754b8cd7e4c60add5abc9b7f7b247a1b77
You are receiving this because you
17 matches
Mail list logo
