updates the editor layer index, adressing
https://github.com/openstreetmap/iD/issues/10483
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5248
-- Commit Summary --
* Update to iD v2.30.3
-- File Changes --
M
There doesn't seem to be anything in the new defaults that is likely to
cause us a problem.
* `enqueue_after_transaction_commit` probably gets disabled by delayed_job in
production anyway
* `web_image_content_types` our production libvips has webp support
* `validate_migration_timestamps` should
Closed #4861 as completed via 83425edd8da6a01047702cbb3ac8642f3ef452fa.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4861#event-14492753495
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5245 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5245#event-14492753539
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5245#issuecomment-2389242090
You are receiving this because you are subscribed to this thread.
Message ID:
___
@gravitystorm requested changes on this pull request.
Great! Well done on getting this working. I've added a couple of points inline,
but otherwise I'm happy to merge.
> @@ -144,6 +144,9 @@ gem "unicode-display_width"
# Keep ruby 3.0 compatibility
gem "multi_xml", "~> 0.6.0"
+gem "teaspoon"
@gravitystorm commented on this pull request.
> @@ -39,6 +49,10 @@ class Note < ApplicationRecord
DEFAULT_FRESHLY_CLOSED_LIMIT = 7.days
+ def comments_with_extra_open_comment
> I am not sure what you mean with that. The idea of
> `Note#comments_with_extra_open_comment` is to hide the l
> you prefer a rebase because you'd like to avoid merge commits
I prefer a rebase so that when everything is ready to go, i.e. the finished
code and branch commits list are both fine, I can just press "Merge pull
request" on the github UI. :smile: We'll have a merge commit when the branch is
m
Closed #4516.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4516#event-14491776937
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mailing
I'm going to close this one now, but feel free to reopen if you want to discuss
it further.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4516#issuecomment-2389097290
You are receiving this because you are subscribed to this thr
Ah, I created https://github.com/openstreetmap/openstreetmap-website/pull/5246
before I saw your comment, so the work is done if you want it. I've no idea
whether rails 7.2.2 or canonical-rails will be the first to be released.
--
Reply to this email directly or view it on GitHub:
https://githu
canonical-rails compatibility was fixed in
https://github.com/jumph4x/canonical-rails/pull/92 but this is not yet released.
This PR allows us to update to rails point releases, by using the version of
canonical-rails from their master branch that includes the compatibility fix.
We can go back t
I don't think we need to worry for now but it's a way out if we do need to do a
rails update urgently.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5070#issuecomment-2389069887
You are receiving this because you are subscribed
> Oh I was going to wait until we could do 7.2.x updates in case there security
> issues that couldn't wait...
Ah, I didn't realise it was blocked for any reason. I saw that the
canonical-rails PR had been merged already, but I guess the problem is that it
hasn't been included in a release.
I
> Shouldn't we just be converting changesets to use the same pagination logic
> as everything else, rather than copying parts of classic pagination into the
> controller just so we can pretend we got rid of it?
I agree.
> * Changesets have an upper bound on the number of elements. There can be
It looks like 7.2.1 is OK at least as there don't look to be any security fixes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5070#issuecomment-2389051326
You are receiving this because you are subscribed to this thread.
Messag
Oh I was going to wait until we could do 7.2.x updates in case there security
issues that couldn't wait...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5070#issuecomment-2389048582
You are receiving this because you are subscri
Fixes #4861
Since the around_action is defined before authorize_resource is called, the
handler needs to pass on the CanCan::AccessDenied exception.
I've added the timeouts where I think they were missing (e.g.
UserPreferencesController) but I've kept the exception for changeset#upload
and tra
Looks good to me, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5070#issuecomment-2389044299
You are receiving this because you are subscribed to this thread.
Message ID:
___
Merged #5070 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5070#event-14491427559
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
I don't think this is important enough to spend much time on.
Using the osm.org domain helps, and I think is sufficient. That's available
today, and works, and so there's not much more to do here.
After that, we're only discussing a small number of characters changing e.g.
`changeset -> c` whic
21 matches
Mail list logo
