Re: [openstreetmap/openstreetmap-website] Email links in text/plain ending in "." - break links (#1844)

2024-09-30 Thread Jörn Heissler via rails-dev
A few suggestions on how to so solve this: * Remove the trailing dot, even though this might be considered a grammar mistake: ``Reply or learn more about the note at https://www.openstreetmap.org/note/4153625`` * Rewrite the sentences to use a colon: ``Reply or learn more about the note at: http

Re: [openstreetmap/openstreetmap-website] Support Panoramax in feature links (browse tags helper) (Issue #5200)

2024-09-30 Thread mmd via rails-dev
This could probably all be handled automatically by #2621. However, I believe Sophox database is still not up to date with most recent wiki updates. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5200#issuecomment-2384907195 Yo

Re: [openstreetmap/openstreetmap-website] Support Panoramax in feature links (browse tags helper) (Issue #5200)

2024-09-30 Thread Thibault Molleman via rails-dev
Also worth mentioning that Mapcomplete.org has it's own instance since last week (which will be available in the federated meta catalog later this week) which is used for images being uploaded through the app to be stored. And in general mapcomplete will also pull from all other federated instan

Re: [openstreetmap/openstreetmap-website] Support Panoramax in feature links (browse tags helper) (Issue #5200)

2024-09-30 Thread Mael via rails-dev
For reference, Panoramax is fully integrated in [cartes.app](https://cartes.app/?allez=chemin+fleury%7Cw84864029&panoramax=6023ce64-8442-4787-8c05-68cb8690393f#16.69/46.570001/0.274989). ![image](https://github.com/user-attachments/assets/0aedd5f4-0da1-4843-8eb9-9a7c92b1) -- Reply to this

Re: [openstreetmap/openstreetmap-website] Masks off unused translation keys in activerecord (PR #5242)

2024-09-30 Thread mmd via rails-dev
I was also wondering about this. IMHO the right place to address this issue would be a proper parser in https://github.com/glebm/i18n-tasks, which is able to handle model validation error messages. I didn't find anything in there, maybe we could raise an issue? -- Reply to this email directly

Re: [openstreetmap/openstreetmap-website] Masks off unused translation keys in activerecord (PR #5242)

2024-09-30 Thread Nenad Vujicic via rails-dev
I agree, thanks. Honestly, I couldn't decide which one I didn't like more, hardcoding translating or adding to ignore list in i18n-tasks.yml (the latest commit). Is there a better way to solve this, or should this translation remain reported as unused? -- Reply to this email directly or view i

Re: [openstreetmap/openstreetmap-website] Improves unused translation keys in activerecord (PR #5242)

2024-09-30 Thread Nenad Vujicic via rails-dev
@nenad-vujicic pushed 1 commit. f862880a6cd4a4d18fd3a37b3db792331cf252c8 Ignores activerecord translation keys as unused -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5242/files/8c90725cc3e8ea7a7125efd8ed528429cec5201e..f862880a6cd4a4d18fd3a37b3db792331cf252

Re: [openstreetmap/openstreetmap-website] Improves unused translation keys in activerecord (PR #5242)

2024-09-30 Thread Tom Hughes via rails-dev
Is this really an improvement though? We're hard coding something that rails does for us automatically in order to keep i18n-tasks happy - is that a good thing? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5242#issuecomment-23

Re: [openstreetmap/openstreetmap-website] Masked off reporting as unused various keys (PR #5243)

2024-09-30 Thread Tom Hughes via rails-dev
Merged #5243 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5243#event-14460578487 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Masked off reporting as unused various keys (PR #5243)

2024-09-30 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5243#issuecomment-2383867793 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Removed unused translations in user_blocks (PR #5241)

2024-09-30 Thread Tom Hughes via rails-dev
Merged #5241 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5241#event-14460578489 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Removed unused translations in user_blocks (PR #5241)

2024-09-30 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5241#issuecomment-2383855457 You are receiving this because you are subscribed to this thread. Message ID: ___

[openstreetmap/openstreetmap-website] Masked off reporting as unused various keys (PR #5243)

2024-09-30 Thread Nenad Vujicic via rails-dev
This PR: - adds time.formats.{blog, friendly} translation keys under ignore_unused in i18n-tasks.yml since used on numerous places for formatting dates / times, - removes site.sidebar.close because started being used at 3a51160 and ended being used at 6adcce4 and - removes sessions.new.title bec

[openstreetmap/openstreetmap-website] Improves unused translation keys in activerecord (PR #5242)

2024-09-30 Thread Nenad Vujicic via rails-dev
PR replaces .is_already_muted with I18n.t("activerecord.errors.models.user_mute.is_already_muted") in user_mute.rb and adds activerecord.errors.models.user_mute.attributes.subject.format under ignore_unused (in i18n-tasks.yml) since used for formatting above validation error message, so they a

[openstreetmap/openstreetmap-website] Removed unused translations in user_blocks (PR #5241)

2024-09-30 Thread Nenad Vujicic via rails-dev
PR removes user_blocks.show.{confirm, needs_view, show} translation keys added at daa2496. confirm and show has never been used, while needs_view ended being used at ca06b3c. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-30 Thread mmd via rails-dev
> > Assuming we need to convert SVGs to PNGs > > I'm not suggesting that. Ok, I think you would need to further elaborate on your proposal, because it’s still not clear to me how this looks in detail. Please provide some working code snippets which addresses both position and coloring of svg. A