Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-27 Thread mmd via rails-dev
@mmd-osm pushed 1 commit. f5302501bec349d46bea6731827c722f3c04bc30 Remove white background for amenity bus_station svg -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/7ea4e8b0f6e003abf5097660179713b50b3c62a8..f5302501bec349d46bea6731827c722f3c04bc30

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

2024-09-27 Thread mmd via rails-dev
A few years back, I've introduced both the activerecord-import gem and `import!` method call to speed up Tracepoint imports. Alternative options weren't available then. Now with the recent Rails version, it's a good time to move to the core Rails code. At least today, we have exactly one locati

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-27 Thread mmd via rails-dev
@mmd-osm pushed 1 commit. 7ea4e8b0f6e003abf5097660179713b50b3c62a8 Added historic ruins svg -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/4a0ab792a46d28ea9f7db5d4114944a9897ede42..7ea4e8b0f6e003abf5097660179713b50b3c62a8 You are receiving this beca

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-27 Thread mmd via rails-dev
@mmd-osm pushed 1 commit. 4a0ab792a46d28ea9f7db5d4114944a9897ede42 Added estate agent svg -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/dc0863b71f7eea9828a7364f0cb80d5bdad17546..4a0ab792a46d28ea9f7db5d4114944a9897ede42 You are receiving this becaus

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

2024-09-27 Thread Anton Khorev via rails-dev
> Rubocop is reporting a false positive here and we mark it as such. Any use of `insert_all` etc that you want to keep is a false positive. You'll have to disable Rubocop for it one way or another. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreet

Re: [openstreetmap/openstreetmap-website] add changeset visualisation when seeing a changeset (Issue #5240)

2024-09-27 Thread mmd via rails-dev
Changeset visualization is very similar to #1376. Please add your comments there as well. Tag coloring is already covered in #738 -> closing as duplicate -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5240#issuecomment-2378779

Re: [openstreetmap/openstreetmap-website] Change the way changesets are displayed to use achavi (#1376)

2024-09-27 Thread mmd via rails-dev
Alternative approach to Achavi is being proposed here: https://www.openstreetmap.org/user/TrickyFoxy/diary/405188 -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/1376#issuecomment-2378784232 You are receiving this because you a

Re: [openstreetmap/openstreetmap-website] add changeset visualisation when seeing a changeset (Issue #5240)

2024-09-27 Thread mmd via rails-dev
Closed #5240 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/issues/5240#event-14427757207 You are receiving this because you are subscribed to this thread. Message ID: ___ r