This comment still refers to the previous version where the whole file was
added to .rubocop.yml.
@tomhughes hasn’t commented on the inline annotation variant yet, and I would
suggest to wait for feedback before continuing.
Like I said, I don’t really have an issue with this annotation.
--
Re
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,12 @@
+
+
+
+
+ <% unless disabled %>
+
+ <% Language.order(:english_name).each do |language| %>
+><%=
language.name %>
Shouldn't the comparison here be with `I18n.locale.to_s` instead of
`request.cookies["_os
@AntonKhorev commented on this pull request.
> @@ -78,6 +78,15 @@
<%= link_to t("layouts.about"), about_path, :class =>
"dropdown-item" %>
+
+<% if current_user && current_user.id %>
+ <%= link_to(preferences_path, :class => "nav-link text-sec
This PR wasn't merged because
> we have to jump through hoops and disable cops
and I'm saying that we shouldn't worry here about model validations and what
Rubocop thinks about them.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pu
@mmd-osm pushed 1 commit.
dc0863b71f7eea9828a7364f0cb80d5bdad17546 Added historic wreck svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/97e5251a8064be4f982f12f0fe21d77b78c47cb8..dc0863b71f7eea9828a7364f0cb80d5bdad17546
You are receiving this beca
@mmd-osm pushed 1 commit.
97e5251a8064be4f982f12f0fe21d77b78c47cb8 Added amenity university svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/39a14376de10e1d7eb7a0d8a88422eaab3cdd041..97e5251a8064be4f982f12f0fe21d77b78c47cb8
You are receiving this
@mmd-osm pushed 1 commit.
39a14376de10e1d7eb7a0d8a88422eaab3cdd041 Added railway level_crossing svg
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/af134de5eb1fa394aa906bc10875eb1bfca1d484..39a14376de10e1d7eb7a0d8a88422eaab3cdd041
You are receiving t
How about "All notes" tab to be able to see the list like it's shown now?
"Open" and "closed" are not the only possible states. This list currently gives
the only easy way to see hidden notes because #3934 is not merged.
--
Reply to this email directly or view it on GitHub:
https://github.com/o
My goal was to remove the activerecord-import gem by a built in equivalent
method. Since the validations are not automatically executed anymore, I added
the call to the validate method. Rubocop is not clever enough to figure out
that we're validating the model contents earlier on, so we need an
@nertc commented on this pull request.
> @@ -76,6 +85,15 @@
<%= link_to t("layouts.copyright"), copyright_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.help"), help_path, :class =>
"dropdown-item" %>
<%= link_to t("layouts.about"), about_path, :clas
@nertc pushed 1 commit.
34d2e252b3c9fe2735ea607d43caea8b849613c5 Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/713eaaaff248f5b0a91680e081f7217f69fd7c4b..34d2e252b3c9fe2735ea607d43caea8b849613c5
You are receiving this because you
11 matches
Mail list logo
