Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
Tracepoint.import! calls model validations internally, like we discussed above. Try to upload data without timestamp and see what happens. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2373075375 You are receiv
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
Tracepoint model doesn't need validations because nothing is written using that model. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2372559392 You are receiving this because you are subscribed to this thread.
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm pushed 1 commit. 2b83a6dfc6cf6f9cf574afe8f568404a1de797a0 Added svg symbols for school and car share -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/6642c0517243448031c2e4f0667aa12da57693ba..2b83a6dfc6cf6f9cf574afe8f568404a1de797a0 You are
Re: [openstreetmap/openstreetmap-website] Login screen for OAuth 2 authorization shows "sign up" tab that triggers googles android policy violation bot (Issue #5118)
> But what's the solution? I'm certainly not interested in removing the account > creation option because we want people to be able to signup! I was assuming a solution along Antons suggestion, aka adding an option to the app configuration that gets passed to the signup page, and if it is set not
Re: [openstreetmap/openstreetmap-website] Login screen for OAuth 2 authorization shows "sign up" tab that triggers googles android policy violation bot (Issue #5118)
But what's the solution? I'm certainly not interested in removing the account creation option because we want people to be able to signup! Is the answer that clients shouldn't be trying to embed the oauth flow in the app and should be letting it go through a web browser? or would that still be a
Re: [openstreetmap/openstreetmap-website] Login screen for OAuth 2 authorization shows "sign up" tab that triggers googles android policy violation bot (Issue #5118)
> I haven't seen other projects with similar requirements. The reason for that is likely that a lot of them don't actually render the HTML of the login/permissions screens and fake things. Highly problematic from a legal pov, but that is something that I've long given up on being concerned abou
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@nertc commented on this pull request. > @@ -76,6 +85,15 @@ <%= link_to t("layouts.copyright"), copyright_path, :class => "dropdown-item" %> <%= link_to t("layouts.help"), help_path, :class => "dropdown-item" %> <%= link_to t("layouts.about"), about_path, :clas
Re: [openstreetmap/openstreetmap-website] Login screen for OAuth 2 authorization shows "sign up" tab that triggers googles android policy violation bot (Issue #5118)
It's been a while. The javascript workaround is in place and appears to be working ok. I haven't seen other projects with similar requirements. Should we keep this open, and assign it to @simonpoole, or close it? Any other ideas? -- Reply to this email directly or view it on GitHub: https://git
Re: [openstreetmap/openstreetmap-website] Process trace files once (PR #5233)
I was wondering about the memory overhead of this and the answer seems to be that the worse case we allow of one million points used about 11Mb for each array which seems acceptable. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pul
Re: [openstreetmap/openstreetmap-website] Process trace files once (PR #5233)
I think this winds up with quite a confused interface - you can now read multiple files into a GPX object and they get appended to the set of points which is a perfectly valid design but if you're going to go that way then I don't think read should also be calling the callback for each point. E
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
The question is what happens with validations. Do we want to maintain them in two different places (Tracepoint model and trace.rb)? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2371894309 You are receiving thi
Re: [openstreetmap/openstreetmap-website] Bump webrick from 1.8.1 to 1.8.2 (PR #5237)
Merged #5237 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5237#event-14385348798 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
[openstreetmap/openstreetmap-website] Bump webrick from 1.8.1 to 1.8.2 (PR #5237)
Bumps [webrick](https://github.com/ruby/webrick) from 1.8.1 to 1.8.2.
Re: [openstreetmap/openstreetmap-website] Improved unused translation keys in users (PR #5236)
Merged #5236 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5236#event-14385272488 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Removed unused translation keys from diary_entries (PR #5235)
Merged #5235 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5235#event-14385272499 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Bump eslint from 9.11.0 to 9.11.1 (PR #5234)
Merged #5234 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5234#event-14385272522 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-
Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)
@mmd-osm pushed 1 commit. 6642c0517243448031c2e4f0667aa12da57693ba Added childcare svg -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/2ff0b3617bde2fe206875ef8bc004fdf41aec894..6642c0517243448031c2e4f0667aa12da57693ba You are receiving this because y
Re: [openstreetmap/openstreetmap-website] Improved unused translation keys in users (PR #5236)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5236#issuecomment-2371858242 You are receiving this because you are subscribed to this thread. Message ID: ___
Re: [openstreetmap/openstreetmap-website] Removed unused translation keys from diary_entries (PR #5235)
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5235#issuecomment-2371853743 You are receiving this because you are subscribed to this thread. Message ID: ___
[openstreetmap/openstreetmap-website] Improved unused translation keys in users (PR #5236)
PR removes users.new.tou (added 9649b19 and has never been used, used layouts.tou instead), replaces users.terms.decline with users.terms.cancel and together with users.terms.continue starts being used at /users/terms.html.erb (where both were added at 9a9e13a and removed at 1be8d59, probably fo
[openstreetmap/openstreetmap-website] Removed unused translation keys from diary_entries (PR #5235)
PR removes diary_entries.location.{edit,view} unused translation keys. They were added at 0b913ef and stopped being used at 53fc3e8 / aa121fa. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5235 -- Commit Summary --
Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
Do we even need to build `Tracepoint` models? The only nontrivial thing there is tile calculation. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038#issuecomment-2371090446 You are receiving this because you are subscribed to t
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@AntonKhorev commented on this pull request. > @@ -76,6 +85,15 @@ <%= link_to t("layouts.copyright"), copyright_path, :class => "dropdown-item" %> <%= link_to t("layouts.help"), help_path, :class => "dropdown-item" %> <%= link_to t("layouts.about"), about_path,
Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)
@nertc commented on this pull request. > @@ -76,6 +85,15 @@ <%= link_to t("layouts.copyright"), copyright_path, :class => "dropdown-item" %> <%= link_to t("layouts.help"), help_path, :class => "dropdown-item" %> <%= link_to t("layouts.about"), about_path, :clas
