Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2024-09-22 Thread David Tsiklauri via rails-dev
PR was updated to include SVG in the HTML. I tried several different methods to move SVG from sprite, including adding it to the SvgHelper module and adding separate file for it, but current solution turned out to be the most optimal one (SvgHelper had conflicts with the linter because of long l

Re: [openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

2024-09-22 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 713eaaaff248f5b0a91680e081f7217f69fd7c4b Add locale selector -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/e02866a8b5003ae8a8c82c141db9c522b209680b..713eaaaff248f5b0a91680e081f7217f69fd7c4b You are receiving this because you

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-22 Thread mmd via rails-dev
I've added dedicated css formatting for 9 SVG symbols now, to improve positioning and/or size of the respective symbols. Maybe you could take another look now. If necessary, please suggest exactly which symbol should be changed and how. The approach should be flexible enough to allow for furthe

Re: [openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)

2024-09-22 Thread mmd via rails-dev
@mmd-osm pushed 1 commit. d41d61856f499de9a40969bd676cd34d99bbc529 Trace import: remove activerecord-import gem -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5038/files/8367e6d6d86ae7849fd3238546e55a52baec1c78..d41d61856f499de9a40969bd676cd34d99bbc529 You ar

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-22 Thread mmd via rails-dev
@mmd-osm pushed 3 commits. a8037a2329d761901eb303657b533ae24535697a Browse icons as svg 872eb6f885c55a7dcb0d882dd259e45694ffa16d Visibility improvements for dark mode 783a05b16398ba8626f8fd3b6be2430e5a336ccc Fine tune position of 9 svg symbols -- View it on GitHub: https://github.com/openstre

Re: [openstreetmap/openstreetmap-website] OCI: ignore invalid replacement token (PR #5231)

2024-09-22 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5231#issuecomment-2366853029 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] OCI: ignore invalid replacement token (PR #5231)

2024-09-22 Thread Tom Hughes via rails-dev
Merged #5231 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5231#event-14355007789 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Trace import: validate background job results (PR #5232)

2024-09-22 Thread Tom Hughes via rails-dev
Looks good to me, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5232#issuecomment-2366853937 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [openstreetmap/openstreetmap-website] Trace import: validate background job results (PR #5232)

2024-09-22 Thread Tom Hughes via rails-dev
Merged #5232 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5232#event-14355007787 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-22 Thread Anton Khorev via rails-dev
> Assuming we need to convert SVGs to PNGs I'm not suggesting that. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2366790325 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-22 Thread Anton Khorev via rails-dev
> I've checked all 219 SVGs, and found that less than 10 of them might need > some fine tuning. The vast majority of new SVGs is just fine. Why making a pull request with 219 svgs with *the vast majority* just fine instead of a smaller pull request with all svg fine? -- Reply to this email dir

Re: [openstreetmap/openstreetmap-website] Browse icons as svg (PR #5080)

2024-09-22 Thread Anton Khorev via rails-dev
>> do we need a smaller icon for waste baskets here just because it's smaller >> on the map render? > Yes, it matches exactly the size you see on the map. No, we don't need it to match *exactly the size you see on the (one particular rendering of the) map*. We need to decide what size the icons