While the discussion in #5038 is still ongoing, I have moved the unit test to a
new PR.
Validating the results of trace import background job is useful for both
scenarios
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pul
@mmd-osm commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ transfo
@mmd-osm pushed 1 commit.
ea30534be46a5150295a53c2c67b45332fd91c52 Visibility improvements for dark mode
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5080/files/40c07ec9b7b87923f3236ea09b9e30c35f973bb4..ea30534be46a5150295a53c2c67b45332fd91c52
You are receiv
Thank you for reviewing this PR another time.
> some icons are too dark, I inverted and hue-rotated them; here it's not done
> I suppose; see place_of_worship icon for an extreme example
Agree, that's also something I've noticed. I'm pushing another commit now which
should improve the situation
I still think it's
[easier](https://github.com/openstreetmap/openstreetmap-website/pull/5080#issuecomment-2298987792)
to switch to ``s first, then start replacing them with svgs, assuming all
of the images have the same size. Hopefully we can avoid random pixel offsets
in css.
--
Reply to thi
@AntonKhorev commented on this pull request.
> @@ -945,6 +945,76 @@ img.trace_image {
.node, .way, .relation {
margin-left: 25px;
}
+
+ .svg_icon {
+overflow: hidden;
+display: inline-block;
+margin-left: -25px;
+width: 25px;
+height: 18px;
+/*rtl:ignore*/ tra
Some icons before/after in dark mode:
;
;
- });
+ if (endpoint.latlng.distanceTo(L.latLng(json.lat, json.lon)) >
200.0) {
+input.val(endpoint.value);
+ } else {
+endpoint.value = json.display_name;
+inpu
@AntonKhorev commented on this pull request.
> @@ -0,0 +1,27 @@
+// Opening pop-ups with share URL
+function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
+ if (typeof url !== "string" || !url.startsWith("http")) {
+console.error("Invalid URL"); // Consider removing this line
I have updated the example URLs from above to only require start lat/lon and
end lat/lon values as well as a profile.
* Valhalla:
`https://valhalla.openstreetmap.de/directions?profile=pedestrian&wps=120.8635823%2C24.1893169%2C120.8648163%2C24.1825192`
* OSRM:
`https://routing.openstreetmap.de/
In #5210, updating the OSM community index failed due to invalid replacement
tokens. This issue needs to be resolved upstream. However, we can add a bit of
error handling and still apply the update. EN is used for erroneous
translations.
You can view, comment on, or merge this pull request onli
11 matches
Mail list logo
