It's the difference between being a closed source and open source website.
@mmd-osm's suggestion would allow the OSM website to keep fully open.
Yes, it's not exactly source code in this case, but source data. Same thing.
--
Reply to this email directly or view it on GitHub:
https://github.com/op
Thanks, I've just made following updates:
1. Removed 1 in favor of #5225
2. Removed 2 in favor of #4872
3. Rebased
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5223#issuecomment-2362335144
You are receiving this because you a
@nenad-vujicic pushed 1 commit.
3f27dc3abb853c71b7fae1cf39cf0865ac364838 Removed unused translation keys from
changesets.*
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5223/files/306d3980ee62ceba7ed917bc2454f08416386bff..3f27dc3abb853c71b7fae1cf39cf0865ac36
Is there a valid editing use case for this? It sounds like an end-user feature
request to me?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5224#issuecomment-2362197899
You are receiving this because you are subscribed to this
I don't think it makes a whole lot of sense to reimplement the GPX export for 3
different routing engines. However, it might be a better idea to add some links
underneath the direction results which point to the respective engine demo
pages.
These pages anyway have much more capabilities, like
@grekko pushed 16 commits.
80a8cb968019d324e59d62f4293384cdfe9096ba Extend Note with body & author,
update controllers & views
eb8e94b675279286693449dd27f9661fb1bb5eed Update Tests to reflect Note
refactoring
b1f2af361a83ec1687b51b632823dfadc3a49a8e Add migration task for Notes
bb399bd17af452
It's not test runner spitting, it's the xml library. You can pass an option to
suppress it. I was going to do another pull request to silence it when I find
all of the places where this can happen.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreet
Merged #5225 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5225#event-14327950216
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5227 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5227#event-14327950198
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Well except that the test runner is spitting out the XML error to the console:
```
Entity: line 1: parser error : Start tag expected, '<' not found
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2361720276
Y
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2361704409
You are receiving this because you are subscribed to this thread.
Message ID:
___
Well they should be detected as xml but I doubt they will be identified any
further than that by file magic.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2361696253
You are receiving this because you are subsc
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5225#issuecomment-2361690644
You are receiving this because you are subscribed to this thread.
Message ID:
___
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from
3.25.4 to 3.25.5.
Commits
70e85ae;
Updating version.json and repo
Alternatively or in addition to this we can check file types. We already do, to
detect archives
https://github.com/openstreetmap/openstreetmap-website/blob/6595d43e3cda580508a069e174d0059febcdc6ea/lib/gpx.rb#L55-L58
I don't know if we can reliably detect gpx. We could detect obviously wrong
fil
We've been including stack backtraces in gpx failure notifications since
https://github.com/openstreetmap/openstreetmap-website/commit/93dab8a1272f8c807da841c0a55b37f74b65b8c3,
but they are not useful for xml parse errors. If your file can't be
parsed, the error is inside it, not in the code tha
I merged this because it's an improvement, it tells now about file formats. But
it doesn't fix #2630 as stack backtraces are still included in emails. Those
backtraces are either sometimes (in case of xml parse errors) or maybe even
always useless to the end user.
--
Reply to this email direct
Closed #2630 as completed via ef2c6ef026f263303d8c9fdd633c437f288d362c.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2630#event-14325034278
You are receiving this because you are subscribed to this thread.
Message ID:
__
Merged #5117 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5117#event-14325034369
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Reopened #2630.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2630#event-14325052660
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-dev mail
Does what
https://github.com/openstreetmap/openstreetmap-website/pull/5223/commits/4564073106d5d48f3781a207693c39a13c130b66
did but without triggering extra ignores by i18n-tasks.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-web
@AntonKhorev commented on this pull request.
> @@ -132,6 +132,7 @@ ignore_unused:
- 'reports.new.categories.*' # double interpolation in reports_helper
- 'shared.pagination.*'
- 'auth.providers.*'
+ - 'changesets.paging_nav.*' # used by string interpolation in elements
pagination
Won
@AntonKhorev commented on this pull request.
> @@ -40,9 +40,10 @@
<% next unless comment.visible || current_user&.moderator? %>
-<%= t comment.visible ? ".comment_by_html" :
".hidden_comment_by_html",
+<% comment_info = comment.visible ? "c
### Problem
Directions tracks are great,
> https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=24.18978%2C120.86377%3B24.18252%2C120.86482
But the website needs to provide a free and open export method, like
- [ ] Export track to GPX
- [ ] Export track to KML
else the directio
24 matches
Mail list logo
