Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)

2024-09-17 Thread David Tsiklauri via rails-dev
This PR was updated. Now truncation is handled in the back end. After 1000 characters, entry is truncated and `...` are added to it. Every image is handled as 500 characters to avoid entries with a big number of images. @kcne @AntonKhorev Thank you for reviews and recommendations -- Reply to th

Re: [openstreetmap/openstreetmap-website] Provide a truncated view of recent diaries (PR #5121)

2024-09-17 Thread David Tsiklauri via rails-dev
@nertc pushed 1 commit. 2f6e72a8c8f2215847fc23e6afd70fe1e7ce0d0c Provide a truncated view of recent diaries -- View it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5121/files/d71a59541a80c6f5a821ee6bc7c1d08900d69a6b..2f6e72a8c8f2215847fc23e6afd70fe1e7ce0d0c You are re

[openstreetmap/openstreetmap-website] Added greeting to friendship notification (PR #5221)

2024-09-17 Thread Nenad Vujicic via rails-dev
PR adds greeting 'Hi {user display name},' to friendship notification messages (both HTML and TEXT). As a side effect, user_mailer.friendship_notification.hi is not anymore reported as unused. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/open

Re: [openstreetmap/openstreetmap-website] Update to rails 7.2.0 (PR #5070)

2024-09-17 Thread Tom Hughes via rails-dev
@tomhughes pushed 3 commits. 6789fc30813990710c5fb786bf90a70867f77339 Drop support for ruby 3.0 be2678e0dd256de10ad176118583aab5914ef671 Update to rails 7.2.0 60c1ae79d6c56f3e6d892043dc0f9681ae8cfa92 Fix warnings about tests with no assertions -- View it on GitHub: https://github.com/openstr

Re: [openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)

2024-09-17 Thread mmd via rails-dev
You can pretty much ignore this hint, there’s no need for further action here. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5217#issuecomment-2356743397 You are receiving this because you are subscribed to this thread. Message

Re: [openstreetmap/openstreetmap-website] Some more i18n unused translation fixes (PR #5217)

2024-09-17 Thread Nenad Vujicic via rails-dev
![image](https://github.com/user-attachments/assets/d2d72177-be5e-43fc-9985-58b87fccf049) CONTRIBUTING.md states "I18n keys under the geocoder.search_osm_nominatim keyspace are managed by the Nominatim maintainers.". Do we need to update CONTRIBUTING.md or to revert this removal (cities, towns,

Re: [openstreetmap/openstreetmap-website] Update Copyright Page (Issue #5132)

2024-09-17 Thread Mikel Maron via rails-dev
@mmd-osm agree keep it actionable. some of these open topics could be refined quickly, once we have momentum of implementation. is there anyone willing and able to jump in an assist in implementation? -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openst

Re: [openstreetmap/openstreetmap-website] Remove unnecessary comma from several translatable messages (PR #5220)

2024-09-17 Thread Amir E. Aharoni via rails-dev
Yes, but it's still unnecessary :) "data" or "history" is the subject (подлежащее), "took" is the verb (сказуемое), and there's no need for a comma between a subject and a verb. The old message with the unnecessary comma was probably copied to the recently-added ones, and it should be removed f

Re: [openstreetmap/openstreetmap-website] Remove unnecessary comma from several translatable messages (PR #5220)

2024-09-17 Thread Anton Khorev via rails-dev
That comma is from ages ago https://github.com/openstreetmap/openstreetmap-website/commit/e0e849c91c66232c986a54da4a848d77f29bcb5b -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5220#issuecomment-2356278081 You are receiving this

[openstreetmap/openstreetmap-website] Remove unnecessary comma from several translatable messages (PR #5220)

2024-09-17 Thread Amir E. Aharoni via rails-dev
You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5220 -- Commit Summary -- * Remove unnecessary comma from several translatable messages -- File Changes -- M config/locales/en.yml (14) -- Patch Links -- https

Re: [openstreetmap/openstreetmap-website] Drop creation_ip column (PR #5212)

2024-09-17 Thread Anton Khorev via rails-dev
Merged, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5212#issuecomment-2355636900 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-dev

Re: [openstreetmap/openstreetmap-website] Drop creation_ip column (PR #5212)

2024-09-17 Thread Anton Khorev via rails-dev
Merged #5212 into master. -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5212#event-14290646338 You are receiving this because you are subscribed to this thread. Message ID: ___ rails-