Thank you for the review
@tomhughes I've updated accordingly
@AntonKhorev If it's okay to directly use SVG instead of the `.icon` class
practice of the project, I am all for it. I think it's even better solution and
produces cleaner, more reusable code.
--
Reply to this email directly or view
@nertc pushed 1 commit.
e02866a8b5003ae8a8c82c141db9c522b209680b Add locale selector
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201/files/64c4f7e97c2dcf835e6ed9c1fc1242310def14d9..e02866a8b5003ae8a8c82c141db9c522b209680b
You are receiving this because you
@AntonKhorev Currently, as I found in the project, for icons we use `.icon`
class, which uses sprite with `background-image` and `background-position`
properties. Adding icon to the sprite was solely for the accordance with the
current state and practices of the project.
--
Reply to this email
@AntonKhorev It's a good point, I'll try to fix it and, as we will need more
complex solution than just adding `max-height`, I'll also take @kcne's
recommendations into account.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/51
@tomhughes pushed 1 commit.
5bac49c51fcd8a619f0ae515ce734aa9ca31e43b Ignore the creation_ip column which
is no longer used
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5218/files/8bb463318d98db6c9b24e3a1d9de403e916cdf28..5bac49c51fcd8a619f0ae515ce734aa9ca31
I've opened #5218 for the first phase and rebased this on that and switched it
to draft for now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5212#issuecomment-2351741641
You are receiving this because you are subscribed to thi
This replaces `creation_ip` with `creation_address` and ignores `creation_ip`
in preparation for removing it.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5218
-- Commit Summary --
* Replace creation_ip with crea
@tomhughes pushed 3 commits.
fe96c0a524c9ce092eed8e8ac14e6f9309e778cc Replace creation_ip with
creation_address
8bb463318d98db6c9b24e3a1d9de403e916cdf28 Ignore the creation_ip column which
is no longer used
5f7e177e99654e4b21fe5c6f5dc4228a218ae55d Drop creation_ip column
--
View it on GitHu
Merged #5203 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5203#event-14264175180
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Closed #5199 as completed via 8d77891fd6796f32f665f7524e0ed8f098507f6d.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5199#event-14264175175
You are receiving this because you are subscribed to this thread.
Message ID:
__
@tomhughes approved this pull request.
Thanks - that looks good now.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5203#pullrequestreview-2305543018
You are receiving this because you are subscribed to this thread.
Message ID
Merged #5213 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5213#event-14264105544
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5214 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5214#event-14264105172
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Merged #5217 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5217#event-14264105629
You are receiving this because you are subscribed to this thread.
Message ID:
___
rails-
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5217#issuecomment-2351715900
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5214#issuecomment-2351709374
You are receiving this because you are subscribed to this thread.
Message ID:
___
Looks good to me, thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5213#issuecomment-2351708027
You are receiving this because you are subscribed to this thread.
Message ID:
___
@mmd-osm pushed 1 commit.
bcc07e87bf29997fb5935918f923c8f2551d Remove unused Namefinder translation
strings
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5217/files/5aa63c60ec7ab98eeb6f595a527f7a525e807a47..bcc07e87bf29997fb5935918f923c8f2551d
You ar
@mmd-osm pushed 1 commit.
5aa63c60ec7ab98eeb6f595a527f7a525e807a47 Remove unused .greeting translation
in changeset_comment_notification
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5217/files/57b402f8fe9667c44093eea16ecb5592617f..5aa63c60ec7ab98eeb6f59
@mmd-osm pushed 2 commits.
efb3e0c81be04b2c40f131fefabd3d8bd768cb61 Ignore users.auth_failure.* as unused
translation
57b402f8fe9667c44093eea16ecb5592617f Remove unused translation key
users.new.external auth
--
View it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pu
Some more cleanups for `bundle exec i18n-tasks health`.
* ChangesetHelper: we have multiple definitions and translations of the same
"anonymous" string. Key "changesets.*" is more in line with
the other translation keys used in the changeset helper file.
Further details in respective commit me
21 matches
Mail list logo
